From: Marc Zyngier <marc.zyngier@arm.com> To: Nishanth Menon <nm@ti.com> Cc: Benoit Cousson <bcousson@baylibre.com>, Tony Lindgren <tony@atomide.com>, Santosh Shilimkar <ssantosh@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Stefan Agner <stefan@agner.ch>, Jason Cooper <jason@lakedaemon.net>, Thomas Gleixner <tglx@linutronix.de>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org> Subject: Re: [PATCH 0/5] irqchip: kill the GIC routable domain Date: Tue, 09 Dec 2014 18:40:35 +0000 [thread overview] Message-ID: <54874223.2000805@arm.com> (raw) In-Reply-To: <20141209181719.GA2569@kahuna> On 09/12/14 18:17, Nishanth Menon wrote: > On 09:53-20141209, Marc Zyngier wrote: >> On 08/12/14 22:41, Nishanth Menon wrote: >> >>> Anyways.. The following diff[1] on top of your branch makes DRA7 work - I >>> assume you will squash as needed and repost with linux-omap mailing list >>> in CC. >> >> Brilliant. I'll squash that into my tree and repost at some point. > > K, it will be nice to have a reflow of the series based on v3.19-rc1 > since there are dts dependencies and we dont want folks to have > regressions on their platforms of choice.. > > Obviously, my tests are basic boot tests and should get a few weeks(as > you already mentioned) on linux-next to get properly soaked > >> >>> I increased the scope of testing knowing that WUGEN is present in many >>> A9 based TI platforms as well.. and at least OMAP4 showed flakiness in >>> my testing.. Also a few notes: >>> >>> Stuff like: am437x is a bit questionable (interrupt-parent probably should be wugen?) >>> 175: 0 GIC 39 tps65218 >>> >>> OMAP5: (should be wugen?) >>> 308: 4323 0 GIC 106 OMAP UART2 >>> 411: 0 0 GIC 151 twl6040 >>> 405: 1 0 GIC 39 palmas >> >> Well, I can't really tell. Someone with access to the documentation >> should be able to find out. > > AM437x: http://www.ti.com/lit/pdf/spruhl7 > OMAP5: http://www.ti.com/lit/pdf/swpu249 > > yeah, we should be able to do them as well - trivially since they follow > the same structure as other SoCs without crossbar. Done some stuff in that department. >> >>> OMAP4 serial port is flaky -> not sure if it is due to routing of GIC to UART2 and not via WUGEN >>> IRQ branch: with my fix applied: >>> --------------------------------- >> >> [...] >> >>> 18: pandaboard-es: Boot FAIL: http://slexy.org/raw/s20ty0Z6i5 (not expected) >>> 19: pandaboard-vanilla: Boot FAIL: http://slexy.org/raw/s20BYfaMd2 (not expected) >> >> If I read the log correctly, the serial port stops responding after a while? > > yeah - dug at the omap4 ones a bit, obviously once the deeper c states > are hit, we'd like wakeupgen to wakeup CPU else we will be "sluggish" in > the sense that the event is detected when some other wakeupgen enabled > interrupt takes place. I realised that as well once I got a panda up and running. > Adding the following makes my panda work fine. > 1: pandaboard-es: Boot PASS: http://slexy.org/raw/s20o8DaBvh > 2: pandaboard-vanilla: Boot PASS: http://slexy.org/raw/s222JndDdh > > > diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi > index 1505135..8b6d50e 100644 > --- a/arch/arm/boot/dts/omap4-panda-common.dtsi > +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi > @@ -371,8 +371,8 @@ > twl: twl@48 { > reg = <0x48>; > /* IRQ# = 7 */ > - interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */ > - interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to wakeupgen to gic */ > + interrupt-parent = <&wakeupgen>; > }; [...] I already fixed those in my tree, in a slightly different way: no need to have an interrupt parent at all, as we're going to inherit the default anyway. I've pushed another version of the branch, with the crossbar rework sitting *before* the WUGEN hacks. That should hopefully make bisection work. If you can give it a shake, that'd be most appreciated. I'll repost the branch in a couple of days. Thanks, M. -- Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/5] irqchip: kill the GIC routable domain Date: Tue, 09 Dec 2014 18:40:35 +0000 [thread overview] Message-ID: <54874223.2000805@arm.com> (raw) In-Reply-To: <20141209181719.GA2569@kahuna> On 09/12/14 18:17, Nishanth Menon wrote: > On 09:53-20141209, Marc Zyngier wrote: >> On 08/12/14 22:41, Nishanth Menon wrote: >> >>> Anyways.. The following diff[1] on top of your branch makes DRA7 work - I >>> assume you will squash as needed and repost with linux-omap mailing list >>> in CC. >> >> Brilliant. I'll squash that into my tree and repost at some point. > > K, it will be nice to have a reflow of the series based on v3.19-rc1 > since there are dts dependencies and we dont want folks to have > regressions on their platforms of choice.. > > Obviously, my tests are basic boot tests and should get a few weeks(as > you already mentioned) on linux-next to get properly soaked > >> >>> I increased the scope of testing knowing that WUGEN is present in many >>> A9 based TI platforms as well.. and at least OMAP4 showed flakiness in >>> my testing.. Also a few notes: >>> >>> Stuff like: am437x is a bit questionable (interrupt-parent probably should be wugen?) >>> 175: 0 GIC 39 tps65218 >>> >>> OMAP5: (should be wugen?) >>> 308: 4323 0 GIC 106 OMAP UART2 >>> 411: 0 0 GIC 151 twl6040 >>> 405: 1 0 GIC 39 palmas >> >> Well, I can't really tell. Someone with access to the documentation >> should be able to find out. > > AM437x: http://www.ti.com/lit/pdf/spruhl7 > OMAP5: http://www.ti.com/lit/pdf/swpu249 > > yeah, we should be able to do them as well - trivially since they follow > the same structure as other SoCs without crossbar. Done some stuff in that department. >> >>> OMAP4 serial port is flaky -> not sure if it is due to routing of GIC to UART2 and not via WUGEN >>> IRQ branch: with my fix applied: >>> --------------------------------- >> >> [...] >> >>> 18: pandaboard-es: Boot FAIL: http://slexy.org/raw/s20ty0Z6i5 (not expected) >>> 19: pandaboard-vanilla: Boot FAIL: http://slexy.org/raw/s20BYfaMd2 (not expected) >> >> If I read the log correctly, the serial port stops responding after a while? > > yeah - dug at the omap4 ones a bit, obviously once the deeper c states > are hit, we'd like wakeupgen to wakeup CPU else we will be "sluggish" in > the sense that the event is detected when some other wakeupgen enabled > interrupt takes place. I realised that as well once I got a panda up and running. > Adding the following makes my panda work fine. > 1: pandaboard-es: Boot PASS: http://slexy.org/raw/s20o8DaBvh > 2: pandaboard-vanilla: Boot PASS: http://slexy.org/raw/s222JndDdh > > > diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi > index 1505135..8b6d50e 100644 > --- a/arch/arm/boot/dts/omap4-panda-common.dtsi > +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi > @@ -371,8 +371,8 @@ > twl: twl at 48 { > reg = <0x48>; > /* IRQ# = 7 */ > - interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */ > - interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to wakeupgen to gic */ > + interrupt-parent = <&wakeupgen>; > }; [...] I already fixed those in my tree, in a slightly different way: no need to have an interrupt parent at all, as we're going to inherit the default anyway. I've pushed another version of the branch, with the crossbar rework sitting *before* the WUGEN hacks. That should hopefully make bisection work. If you can give it a shake, that'd be most appreciated. I'll repost the branch in a couple of days. Thanks, M. -- Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-12-09 18:40 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-06 13:46 [PATCH 0/5] irqchip: kill the GIC routable domain Marc Zyngier 2014-12-06 13:46 ` [PATCH 1/5] genirq: Add irqchip_set_wake_parent Marc Zyngier 2014-12-06 15:34 ` Stefan Agner 2014-12-08 11:18 ` Marc Zyngier 2014-12-06 13:46 ` [PATCH 2/5] irqchip: crossbar: convert dra7 crossbar to stacked domains Marc Zyngier 2014-12-06 13:46 ` [PATCH 3/5] DT: update ti,irq-crossbar binding Marc Zyngier 2014-12-06 13:46 ` [PATCH 4/5] irqchip: GIC: get rid of routable domain Marc Zyngier 2014-12-06 13:46 ` [PATCH 5/5] DT: arm,gic: kill arm,routable-irqs Marc Zyngier 2014-12-07 17:16 ` [PATCH 0/5] irqchip: kill the GIC routable domain Nishanth Menon 2014-12-07 17:16 ` Nishanth Menon 2014-12-07 18:03 ` Nishanth Menon 2014-12-07 18:03 ` Nishanth Menon 2014-12-08 9:10 ` Marc Zyngier 2014-12-08 9:10 ` Marc Zyngier 2014-12-08 22:41 ` Nishanth Menon 2014-12-08 22:41 ` Nishanth Menon 2014-12-09 9:53 ` Marc Zyngier 2014-12-09 9:53 ` Marc Zyngier 2014-12-09 18:17 ` Nishanth Menon 2014-12-09 18:17 ` Nishanth Menon 2014-12-09 18:40 ` Marc Zyngier [this message] 2014-12-09 18:40 ` Marc Zyngier 2014-12-10 18:21 ` Nishanth Menon 2014-12-10 18:21 ` Nishanth Menon 2015-01-07 16:14 ` Nishanth Menon 2015-01-07 16:14 ` Nishanth Menon 2015-01-07 16:09 ` Jason Cooper 2015-01-07 16:09 ` Jason Cooper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54874223.2000805@arm.com \ --to=marc.zyngier@arm.com \ --cc=bcousson@baylibre.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=nm@ti.com \ --cc=ssantosh@kernel.org \ --cc=stefan@agner.ch \ --cc=tglx@linutronix.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.