From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, "Wu, Feng" <feng.wu@intel.com>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"eric.auger@linaro.org" <eric.auger@linaro.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu()
Date: Fri, 18 Sep 2015 18:17:29 +0200 [thread overview]
Message-ID: <55FC3919.9030204@redhat.com> (raw)
In-Reply-To: <20150918161631.GA27908@potion.brq.redhat.com>
On 18/09/2015 18:16, Radim Krčmář wrote:
>>> >> Ok, I was wondering whether this was the correct interpretation. Thanks!
>> >
>> > Paolo, I don't think Radim clarify your concern, right? Since mda is 8-bit, it
>> > is wrong with mda >> 16, this is your concern, right?
> In case it was: mda is u32 so the bitshift is defined by C.
> (xAPIC destinations in KVM's x2APIC mode are stored in lowest 8 bits of
> mda, hence the cluster is always 0.)
>
> Or am I still missing the point?
Yes, remembering that the cluster is always 0 solved my doubt.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Radim Krčmář" <rkrcmar-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Wu, Feng" <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu()
Date: Fri, 18 Sep 2015 18:17:29 +0200 [thread overview]
Message-ID: <55FC3919.9030204@redhat.com> (raw)
In-Reply-To: <20150918161631.GA27908-KfRq7+sF/6zkZJWtSm8s3NvLeJWuRmrY@public.gmane.org>
On 18/09/2015 18:16, Radim Krčmář wrote:
>>> >> Ok, I was wondering whether this was the correct interpretation. Thanks!
>> >
>> > Paolo, I don't think Radim clarify your concern, right? Since mda is 8-bit, it
>> > is wrong with mda >> 16, this is your concern, right?
> In case it was: mda is u32 so the bitshift is defined by C.
> (xAPIC destinations in KVM's x2APIC mode are stored in lowest 8 bits of
> mda, hence the cluster is always 0.)
>
> Or am I still missing the point?
Yes, remembering that the cluster is always 0 solved my doubt.
Paolo
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2015-09-18 16:17 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 8:49 [PATCH v8 00/13] Add VT-d Posted-Interrupts support Feng Wu
2015-09-16 8:49 ` Feng Wu
2015-09-16 8:49 ` [PATCH v8 01/13] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-09-16 8:49 ` Feng Wu
2015-09-16 8:49 ` [PATCH v8 02/13] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-09-16 8:49 ` Feng Wu
2015-09-16 8:49 ` [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-09-16 8:49 ` Feng Wu
2015-09-16 9:23 ` Paolo Bonzini
2015-09-16 9:23 ` Paolo Bonzini
2015-09-17 3:17 ` Wu, Feng
2015-09-17 3:17 ` Wu, Feng
2015-09-17 9:42 ` Paolo Bonzini
2015-09-17 13:36 ` Wu, Feng
2015-09-17 13:36 ` Wu, Feng
2015-09-17 14:24 ` Paolo Bonzini
2015-09-17 14:24 ` Paolo Bonzini
2015-09-17 15:58 ` Radim Krčmář
2015-09-17 16:00 ` Paolo Bonzini
2015-09-17 16:00 ` Paolo Bonzini
2015-09-17 23:18 ` Wu, Feng
2015-09-17 23:18 ` Wu, Feng
2015-09-18 16:16 ` Radim Krčmář
2015-09-18 16:16 ` Radim Krčmář
2015-09-18 16:17 ` Paolo Bonzini [this message]
2015-09-18 16:17 ` Paolo Bonzini
2015-09-17 23:15 ` Wu, Feng
2015-09-17 23:15 ` Wu, Feng
2015-09-16 8:50 ` [PATCH v8 04/13] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 8:50 ` [PATCH v8 05/13] KVM: make kvm_set_msi_irq() public Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 8:50 ` [PATCH v8 06/13] vfio: Register/unregister irq_bypass_producer Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 8:50 ` [PATCH v8 07/13] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 8:50 ` [PATCH v8 08/13] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 8:50 ` [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 9:27 ` Paolo Bonzini
2015-09-16 9:27 ` Paolo Bonzini
2015-09-17 1:51 ` Wu, Feng
2015-09-17 1:51 ` Wu, Feng
2015-09-17 9:38 ` Paolo Bonzini
2015-09-17 9:38 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 10/13] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 9:29 ` Paolo Bonzini
2015-09-16 9:29 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 11/13] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 9:32 ` Paolo Bonzini
2015-09-16 9:32 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 12/13] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 9:32 ` Paolo Bonzini
2015-09-16 9:32 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 13/13] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-09-16 8:50 ` Feng Wu
2015-09-16 9:34 ` [PATCH v8 00/13] Add VT-d Posted-Interrupts support Paolo Bonzini
2015-09-16 9:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC3919.9030204@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=feng.wu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.