From: "Wu, Feng" <feng.wu@intel.com> To: Paolo Bonzini <pbonzini@redhat.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "joro@8bytes.org" <joro@8bytes.org>, "mtosatti@redhat.com" <mtosatti@redhat.com> Cc: "eric.auger@linaro.org" <eric.auger@linaro.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Wu, Feng" <feng.wu@intel.com> Subject: RE: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Date: Thu, 17 Sep 2015 01:51:01 +0000 [thread overview] Message-ID: <E959C4978C3B6342920538CF579893F002716E32@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <55F935E9.6070707@redhat.com> > -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > Sent: Wednesday, September 16, 2015 5:27 PM > To: Wu, Feng; alex.williamson@redhat.com; joro@8bytes.org; > mtosatti@redhat.com > Cc: eric.auger@linaro.org; kvm@vger.kernel.org; > iommu@lists.linux-foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct > kvm_kernel_irqfd' > > > > On 16/09/2015 10:50, Feng Wu wrote: > > +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, > > + uint32_t guest_irq, bool set) > > +{ > > + return !kvm_x86_ops->update_pi_irte ? -EINVAL : > > + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); > > +} > > + > > Just use "if" here. No need to resend if this is the only comment. I am sorry, I don't quite understand. Do you mean I don't need to include this patch in v9? If so, what about other patches with your Reviewed-by? Thanks, Feng > > > > > } > > +int __attribute__((weak)) kvm_arch_update_irqfd_routing( > > + struct kvm *kvm, unsigned > > Empty line after "}". > > Paolo
WARNING: multiple messages have this Message-ID (diff)
From: "Wu, Feng" <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> To: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>, "mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" <mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" <eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Subject: RE: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Date: Thu, 17 Sep 2015 01:51:01 +0000 [thread overview] Message-ID: <E959C4978C3B6342920538CF579893F002716E32@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <55F935E9.6070707-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org] > Sent: Wednesday, September 16, 2015 5:27 PM > To: Wu, Feng; alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org; > mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org > Cc: eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct > kvm_kernel_irqfd' > > > > On 16/09/2015 10:50, Feng Wu wrote: > > +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, > > + uint32_t guest_irq, bool set) > > +{ > > + return !kvm_x86_ops->update_pi_irte ? -EINVAL : > > + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); > > +} > > + > > Just use "if" here. No need to resend if this is the only comment. I am sorry, I don't quite understand. Do you mean I don't need to include this patch in v9? If so, what about other patches with your Reviewed-by? Thanks, Feng > > > > > } > > +int __attribute__((weak)) kvm_arch_update_irqfd_routing( > > + struct kvm *kvm, unsigned > > Empty line after "}". > > Paolo
next prev parent reply other threads:[~2015-09-17 1:54 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-16 8:49 [PATCH v8 00/13] Add VT-d Posted-Interrupts support Feng Wu 2015-09-16 8:49 ` Feng Wu 2015-09-16 8:49 ` [PATCH v8 01/13] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu 2015-09-16 8:49 ` Feng Wu 2015-09-16 8:49 ` [PATCH v8 02/13] KVM: Add some helper functions for Posted-Interrupts Feng Wu 2015-09-16 8:49 ` Feng Wu 2015-09-16 8:49 ` [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu 2015-09-16 8:49 ` Feng Wu 2015-09-16 9:23 ` Paolo Bonzini 2015-09-16 9:23 ` Paolo Bonzini 2015-09-17 3:17 ` Wu, Feng 2015-09-17 3:17 ` Wu, Feng 2015-09-17 9:42 ` Paolo Bonzini 2015-09-17 13:36 ` Wu, Feng 2015-09-17 13:36 ` Wu, Feng 2015-09-17 14:24 ` Paolo Bonzini 2015-09-17 14:24 ` Paolo Bonzini 2015-09-17 15:58 ` Radim Krčmář 2015-09-17 16:00 ` Paolo Bonzini 2015-09-17 16:00 ` Paolo Bonzini 2015-09-17 23:18 ` Wu, Feng 2015-09-17 23:18 ` Wu, Feng 2015-09-18 16:16 ` Radim Krčmář 2015-09-18 16:16 ` Radim Krčmář 2015-09-18 16:17 ` Paolo Bonzini 2015-09-18 16:17 ` Paolo Bonzini 2015-09-17 23:15 ` Wu, Feng 2015-09-17 23:15 ` Wu, Feng 2015-09-16 8:50 ` [PATCH v8 04/13] KVM: Make struct kvm_irq_routing_table accessible Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 8:50 ` [PATCH v8 05/13] KVM: make kvm_set_msi_irq() public Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 8:50 ` [PATCH v8 06/13] vfio: Register/unregister irq_bypass_producer Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 8:50 ` [PATCH v8 07/13] KVM: x86: Update IRTE for posted-interrupts Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 8:50 ` [PATCH v8 08/13] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 8:50 ` [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 9:27 ` Paolo Bonzini 2015-09-16 9:27 ` Paolo Bonzini 2015-09-17 1:51 ` Wu, Feng [this message] 2015-09-17 1:51 ` Wu, Feng 2015-09-17 9:38 ` Paolo Bonzini 2015-09-17 9:38 ` Paolo Bonzini 2015-09-16 8:50 ` [PATCH v8 10/13] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 9:29 ` Paolo Bonzini 2015-09-16 9:29 ` Paolo Bonzini 2015-09-16 8:50 ` [PATCH v8 11/13] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 9:32 ` Paolo Bonzini 2015-09-16 9:32 ` Paolo Bonzini 2015-09-16 8:50 ` [PATCH v8 12/13] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 9:32 ` Paolo Bonzini 2015-09-16 9:32 ` Paolo Bonzini 2015-09-16 8:50 ` [PATCH v8 13/13] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu 2015-09-16 8:50 ` Feng Wu 2015-09-16 9:34 ` [PATCH v8 00/13] Add VT-d Posted-Interrupts support Paolo Bonzini 2015-09-16 9:34 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E959C4978C3B6342920538CF579893F002716E32@SHSMSX104.ccr.corp.intel.com \ --to=feng.wu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=eric.auger@linaro.org \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.