From: Yakir Yang <ykk@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Inki Dae <inki.dae@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Yao <mark.yao@rock-chips.com>,
Russell King <linux@arm.linux.org.uk>,
emil.l.velikov@gmail.com,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Kishon Vijay Abraham I <kishon@ti.com>,
javier@osg.samsung.com, Andy Yan <andy.yan@rock-chips.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver
Date: Fri, 22 Jan 2016 09:37:08 +0800 [thread overview]
Message-ID: <56A187C4.2030100@rock-chips.com> (raw)
In-Reply-To: <7132332.jmLRiUjx3U@phil>
Hi Heiko,
On 01/22/2016 03:11 AM, Heiko Stuebner wrote:
> Hi Yakir,
>
> Am Dienstag, 19. Januar 2016, 18:04:53 schrieb Yakir Yang:
>> Rockchip have three clocks for dp controller, we leave pclk_edp
>> to analogix_dp driver control, and keep the sclk_edp_24m and
>> sclk_edp in platform driver.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
> [...]
>
>> +static int rockchip_dp_drm_create_encoder(struct rockchip_dp_device *dp)
>> +{
>> + struct drm_encoder *encoder = &dp->encoder;
>> + struct drm_device *drm_dev = dp->drm_dev;
>> + struct device *dev = dp->dev;
>> + int ret;
>> +
>> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev,
>> + dev->of_node);
>> + DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs);
>> +
>> + ret = drm_encoder_init(drm_dev, encoder, &rockchip_dp_encoder_funcs,
>> + DRM_MODE_ENCODER_TMDS);
> should be
> + DRM_MODE_ENCODER_TMDS, NULL);
Ops, :-|
> Exynos-side seems to be ok though.
>
> With the adapted v12.1 patches it applies cleanly and display is working as
> well. So with the thing above fixed, you could resubmit a full v13,
> especially as you want to drop patch 16 as discussed there.
Got it :)
Thanks,
Yakir
>
> Heiko
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Yakir Yang <ykk@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Jingoo Han <jingoohan1@gmail.com>,
emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Kishon Vijay Abraham I <kishon@ti.com>,
javier@osg.samsung.com, Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
linux-rockchip@lists.infradead.org,
Andy Yan <andy.yan@rock-chips.com>,
Thierry Reding <treding@nvidia.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver
Date: Fri, 22 Jan 2016 09:37:08 +0800 [thread overview]
Message-ID: <56A187C4.2030100@rock-chips.com> (raw)
In-Reply-To: <7132332.jmLRiUjx3U@phil>
Hi Heiko,
On 01/22/2016 03:11 AM, Heiko Stuebner wrote:
> Hi Yakir,
>
> Am Dienstag, 19. Januar 2016, 18:04:53 schrieb Yakir Yang:
>> Rockchip have three clocks for dp controller, we leave pclk_edp
>> to analogix_dp driver control, and keep the sclk_edp_24m and
>> sclk_edp in platform driver.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
> [...]
>
>> +static int rockchip_dp_drm_create_encoder(struct rockchip_dp_device *dp)
>> +{
>> + struct drm_encoder *encoder = &dp->encoder;
>> + struct drm_device *drm_dev = dp->drm_dev;
>> + struct device *dev = dp->dev;
>> + int ret;
>> +
>> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev,
>> + dev->of_node);
>> + DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs);
>> +
>> + ret = drm_encoder_init(drm_dev, encoder, &rockchip_dp_encoder_funcs,
>> + DRM_MODE_ENCODER_TMDS);
> should be
> + DRM_MODE_ENCODER_TMDS, NULL);
Ops, :-|
> Exynos-side seems to be ok though.
>
> With the adapted v12.1 patches it applies cleanly and display is working as
> well. So with the thing above fixed, you could resubmit a full v13,
> especially as you want to drop patch 16 as discussed there.
Got it :)
Thanks,
Yakir
>
> Heiko
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: ykk@rock-chips.com (Yakir Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver
Date: Fri, 22 Jan 2016 09:37:08 +0800 [thread overview]
Message-ID: <56A187C4.2030100@rock-chips.com> (raw)
In-Reply-To: <7132332.jmLRiUjx3U@phil>
Hi Heiko,
On 01/22/2016 03:11 AM, Heiko Stuebner wrote:
> Hi Yakir,
>
> Am Dienstag, 19. Januar 2016, 18:04:53 schrieb Yakir Yang:
>> Rockchip have three clocks for dp controller, we leave pclk_edp
>> to analogix_dp driver control, and keep the sclk_edp_24m and
>> sclk_edp in platform driver.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
> [...]
>
>> +static int rockchip_dp_drm_create_encoder(struct rockchip_dp_device *dp)
>> +{
>> + struct drm_encoder *encoder = &dp->encoder;
>> + struct drm_device *drm_dev = dp->drm_dev;
>> + struct device *dev = dp->dev;
>> + int ret;
>> +
>> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev,
>> + dev->of_node);
>> + DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs);
>> +
>> + ret = drm_encoder_init(drm_dev, encoder, &rockchip_dp_encoder_funcs,
>> + DRM_MODE_ENCODER_TMDS);
> should be
> + DRM_MODE_ENCODER_TMDS, NULL);
Ops, :-|
> Exynos-side seems to be ok though.
>
> With the adapted v12.1 patches it applies cleanly and display is working as
> well. So with the thing above fixed, you could resubmit a full v13,
> especially as you want to drop patch 16 as discussed there.
Got it :)
Thanks,
Yakir
>
> Heiko
>
>
>
next prev parent reply other threads:[~2016-01-22 1:37 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:25 [PATCH v12 0/18] Add Analogix Core Display Port Driver Yakir Yang
2015-12-23 12:25 ` Yakir Yang
2015-12-23 12:25 ` Yakir Yang
2015-12-23 12:29 ` [PATCH v12 01/18] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2015-12-23 12:29 ` Yakir Yang
2015-12-23 12:31 ` [PATCH v12 02/18] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang
2015-12-23 12:31 ` Yakir Yang
2015-12-23 12:31 ` Yakir Yang
2015-12-23 12:31 ` [PATCH v12 03/18] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang
2015-12-23 12:31 ` Yakir Yang
2015-12-23 12:31 ` Yakir Yang
2015-12-23 12:31 ` [PATCH v12 04/18] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang
2015-12-23 12:31 ` Yakir Yang
2015-12-23 12:31 ` Yakir Yang
2015-12-23 12:32 ` [PATCH v12 05/18] dt-bindings: add document for analogix display port driver Yakir Yang
2015-12-23 12:32 ` Yakir Yang
2015-12-23 12:32 ` Yakir Yang
2015-12-23 12:32 ` [PATCH v12 06/18] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2015-12-23 12:32 ` Yakir Yang
2015-12-23 12:32 ` Yakir Yang
2015-12-23 12:32 ` [PATCH v12 07/18] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2015-12-23 12:32 ` Yakir Yang
2015-12-23 12:34 ` [PATCH v12 08/18] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2015-12-23 12:34 ` Yakir Yang
2015-12-23 12:36 ` [PATCH v12 09/18] phy: Add driver for rockchip Display Port PHY Yakir Yang
2015-12-23 12:36 ` Yakir Yang
2015-12-23 12:38 ` [PATCH v12 10/18] dt-bindings: add document for rockchip dp phy Yakir Yang
2015-12-23 12:38 ` Yakir Yang
2015-12-23 12:40 ` [PATCH v12 11/18] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang
2015-12-23 12:40 ` Yakir Yang
2015-12-23 12:42 ` [PATCH v12 12/18] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang
2015-12-23 12:42 ` Yakir Yang
2015-12-23 12:42 ` Yakir Yang
2015-12-23 12:44 ` [PATCH v12 13/18] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2015-12-23 12:44 ` Yakir Yang
2015-12-23 12:46 ` [PATCH v12 14/18] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang
2015-12-23 12:46 ` Yakir Yang
2015-12-23 12:46 ` Yakir Yang
2015-12-23 12:49 ` [PATCH v12 15/18] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang
2015-12-23 12:49 ` Yakir Yang
2015-12-23 12:49 ` Yakir Yang
2015-12-23 12:51 ` [PATCH v12 16/18] drm: bridge: analogix/dp: expand the wait time for looking AUX CH reply flag Yakir Yang
2015-12-23 12:51 ` Yakir Yang
2015-12-23 15:10 ` Jingoo Han
2015-12-23 15:10 ` Jingoo Han
2015-12-23 15:10 ` Jingoo Han
2015-12-24 1:23 ` Yakir Yang
2015-12-24 1:23 ` Yakir Yang
2015-12-24 1:23 ` Yakir Yang
2015-12-25 13:01 ` Jingoo Han
2015-12-25 13:01 ` Jingoo Han
2015-12-25 13:01 ` Jingoo Han
2015-12-23 12:53 ` [PATCH v12 17/18] drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time Yakir Yang
2015-12-23 12:53 ` Yakir Yang
2015-12-23 12:55 ` [PATCH v12 18/18] drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time Yakir Yang
2015-12-23 12:55 ` Yakir Yang
2015-12-23 12:55 ` Yakir Yang
2016-01-13 14:59 ` [PATCH v12 0/18] Add Analogix Core Display Port Driver Heiko Stuebner
2016-01-13 14:59 ` Heiko Stuebner
2016-01-13 14:59 ` Heiko Stuebner
2016-01-17 14:25 ` Heiko Stuebner
2016-01-17 14:25 ` Heiko Stuebner
2016-01-17 14:25 ` Heiko Stuebner
2016-01-17 14:25 ` Heiko Stuebner
2016-01-18 10:48 ` Yakir Yang
2016-01-18 10:48 ` Yakir Yang
2016-01-18 10:48 ` Yakir Yang
2016-01-19 9:58 ` [PATCH v12.1 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2016-01-19 9:58 ` Yakir Yang
2016-01-19 10:00 ` [PATCH v12.1 05/17] dt-bindings: add document for analogix display port driver Yakir Yang
2016-01-19 10:00 ` Yakir Yang
2016-01-19 10:00 ` Yakir Yang
2016-01-19 10:02 ` [PATCH v12.1 06/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2016-01-19 10:02 ` Yakir Yang
2016-01-19 10:02 ` Yakir Yang
2016-01-19 10:04 ` [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2016-01-19 10:04 ` Yakir Yang
2016-01-21 19:11 ` Heiko Stuebner
2016-01-21 19:11 ` Heiko Stuebner
2016-01-22 1:37 ` Yakir Yang [this message]
2016-01-22 1:37 ` Yakir Yang
2016-01-22 1:37 ` Yakir Yang
2016-01-19 10:06 ` [PATCH v12.1 13/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2016-01-19 10:06 ` Yakir Yang
2016-01-19 10:06 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A187C4.2030100@rock-chips.com \
--to=ykk@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jingoohan1@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.yao@rock-chips.com \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.