From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [PATCH v2 04/11] acpi: add aml_concatenate()
Date: Sun, 14 Feb 2016 13:52:53 +0800 [thread overview]
Message-ID: <56C01635.6090501@linux.intel.com> (raw)
In-Reply-To: <20160208115103.00dc44db@nial.brq.redhat.com>
On 02/08/2016 06:51 PM, Igor Mammedov wrote:
> On Wed, 13 Jan 2016 02:50:03 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> It will be used by nvdimm acpi
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>> ---
>> hw/acpi/aml-build.c | 14 ++++++++++++++
>> include/hw/acpi/aml-build.h | 1 +
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> index 97c9efb..421dd84 100644
>> --- a/hw/acpi/aml-build.c
>> +++ b/hw/acpi/aml-build.c
>> @@ -1440,6 +1440,20 @@ Aml *aml_alias(const char *source_object, const char *alias_object)
>> return var;
>> }
>>
>> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
>> +Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
>> +{
>> + Aml *var = aml_opcode(0x73 /* ConcatOp */);
>> + aml_append(var, source1);
>> + aml_append(var, source2);
>> +
>> + if (target) {
>> + aml_append(var, target);
>> + }
> target is not an optional, pls looks at aml_add and use
> helper to make patch correct and smaller
>
Indeed, i will change it to:
/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
{
return build_opcode_2arg_dst(0x73 /* ConcatOp */, arg1, arg2, dst);
}
Thank you, Igor!
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 04/11] acpi: add aml_concatenate()
Date: Sun, 14 Feb 2016 13:52:53 +0800 [thread overview]
Message-ID: <56C01635.6090501@linux.intel.com> (raw)
In-Reply-To: <20160208115103.00dc44db@nial.brq.redhat.com>
On 02/08/2016 06:51 PM, Igor Mammedov wrote:
> On Wed, 13 Jan 2016 02:50:03 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> It will be used by nvdimm acpi
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>> ---
>> hw/acpi/aml-build.c | 14 ++++++++++++++
>> include/hw/acpi/aml-build.h | 1 +
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> index 97c9efb..421dd84 100644
>> --- a/hw/acpi/aml-build.c
>> +++ b/hw/acpi/aml-build.c
>> @@ -1440,6 +1440,20 @@ Aml *aml_alias(const char *source_object, const char *alias_object)
>> return var;
>> }
>>
>> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
>> +Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
>> +{
>> + Aml *var = aml_opcode(0x73 /* ConcatOp */);
>> + aml_append(var, source1);
>> + aml_append(var, source2);
>> +
>> + if (target) {
>> + aml_append(var, target);
>> + }
> target is not an optional, pls looks at aml_add and use
> helper to make patch correct and smaller
>
Indeed, i will change it to:
/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
{
return build_opcode_2arg_dst(0x73 /* ConcatOp */, arg1, arg2, dst);
}
Thank you, Igor!
next prev parent reply other threads:[~2016-02-14 5:52 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 18:49 [PATCH v2 00/11] NVDIMM ACPI: introduce the framework of QEMU emulated Xiao Guangrong
2016-01-12 18:49 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 01/11] tests: acpi: test multiple SSDT tables Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 02/11] tests: acpi: test NVDIMM tables Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-02-04 16:20 ` Michael S. Tsirkin
2016-02-04 16:20 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-14 5:36 ` Xiao Guangrong
2016-02-14 5:36 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 03/11] acpi: add aml_create_field() Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-02-08 10:47 ` Igor Mammedov
2016-02-08 10:47 ` [Qemu-devel] " Igor Mammedov
2016-02-14 5:41 ` Xiao Guangrong
2016-02-14 5:41 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 04/11] acpi: add aml_concatenate() Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-02-08 10:51 ` Igor Mammedov
2016-02-08 10:51 ` [Qemu-devel] " Igor Mammedov
2016-02-14 5:52 ` Xiao Guangrong [this message]
2016-02-14 5:52 ` Xiao Guangrong
2016-02-14 5:55 ` Xiao Guangrong
2016-02-14 5:55 ` [Qemu-devel] " Xiao Guangrong
2016-02-15 9:02 ` Igor Mammedov
2016-02-15 9:02 ` [Qemu-devel] " Igor Mammedov
2016-02-15 10:32 ` Xiao Guangrong
2016-02-15 10:32 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 05/11] acpi: allow using object as offset for OperationRegion Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-02-08 10:57 ` Igor Mammedov
2016-02-08 10:57 ` [Qemu-devel] " Igor Mammedov
2016-01-12 18:50 ` [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-02-04 16:22 ` Michael S. Tsirkin
2016-02-04 16:22 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-08 11:03 ` Igor Mammedov
2016-02-08 11:03 ` [Qemu-devel] " Igor Mammedov
2016-02-14 5:57 ` Xiao Guangrong
2016-02-14 5:57 ` [Qemu-devel] " Xiao Guangrong
2016-02-15 9:11 ` Igor Mammedov
2016-02-15 9:18 ` Michael S. Tsirkin
2016-02-15 10:13 ` Xiao Guangrong
2016-02-15 10:30 ` Michael S. Tsirkin
2016-02-15 10:30 ` Michael S. Tsirkin
2016-02-15 10:47 ` Igor Mammedov
2016-02-15 10:47 ` Igor Mammedov
2016-02-15 11:22 ` Xiao Guangrong
2016-02-15 11:22 ` Xiao Guangrong
2016-02-15 11:45 ` Michael S. Tsirkin
2016-02-15 13:32 ` Igor Mammedov
2016-02-15 15:53 ` Xiao Guangrong
2016-02-15 17:24 ` Igor Mammedov
2016-02-15 17:24 ` Igor Mammedov
2016-02-15 18:35 ` Xiao Guangrong
2016-02-15 18:35 ` Xiao Guangrong
2016-02-16 11:00 ` Igor Mammedov
2016-02-17 2:04 ` Xiao Guangrong
2016-02-17 17:26 ` Michael S. Tsirkin
2016-02-17 17:26 ` Michael S. Tsirkin
2016-02-18 4:03 ` Xiao Guangrong
2016-02-18 4:03 ` Xiao Guangrong
2016-02-18 10:05 ` Igor Mammedov
2016-02-18 10:05 ` [Qemu-devel] " Igor Mammedov
2016-02-19 8:08 ` Michael S. Tsirkin
2016-02-19 8:43 ` Dan Williams
2016-02-19 8:43 ` Dan Williams
2016-02-22 10:30 ` Xiao Guangrong
2016-02-22 10:30 ` Xiao Guangrong
2016-02-22 10:34 ` Xiao Guangrong
2016-02-18 10:20 ` Michael S. Tsirkin
2016-02-18 10:20 ` Michael S. Tsirkin
2016-02-15 11:36 ` Michael S. Tsirkin
2016-02-15 11:36 ` Michael S. Tsirkin
2016-01-12 18:50 ` [PATCH v2 07/11] nvdimm acpi: introduce patched dsm memory Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 08/11] nvdimm acpi: let qemu handle _DSM method Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 09/11] nvdimm acpi: emulate dsm method Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 10/11] nvdimm acpi: add _CRS Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-01-12 18:50 ` [PATCH v2 11/11] tests: acpi: update nvdimm ssdt table Xiao Guangrong
2016-01-12 18:50 ` [Qemu-devel] " Xiao Guangrong
2016-01-20 2:21 ` [PATCH v2 00/11] NVDIMM ACPI: introduce the framework of QEMU emulated Xiao Guangrong
2016-01-20 2:21 ` [Qemu-devel] " Xiao Guangrong
2016-01-28 4:42 ` Xiao Guangrong
2016-01-28 4:42 ` [Qemu-devel] " Xiao Guangrong
2016-02-04 16:24 ` Michael S. Tsirkin
2016-02-04 16:24 ` [Qemu-devel] " Michael S. Tsirkin
2016-02-14 5:38 ` Xiao Guangrong
2016-02-14 5:38 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C01635.6090501@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.