From: Mark yao <mark.yao@rock-chips.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm
Date: Wed, 8 Feb 2017 08:28:12 +0800 [thread overview]
Message-ID: <589A661C.5070505@rock-chips.com> (raw)
In-Reply-To: <20170207121909.GA18315@ulmo.ba.sec>
On 2017年02月07日 20:19, Thierry Reding wrote:
> On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote:
>> drm_mm_insert_node_generic and drm_mm_remove_node may access same
>> resource with list ops, it's not threads safe, so protect this context
>> with mutex lock.
>>
>> Fix bug:
>> [49451.856244] ==================================================================
>> [49451.856350] BUG: KASAN: wild-memory-access on address dead000000000108
>> [49451.856379] Write of size 8 by task Binder:218_4/683
>> [49451.856417] CPU: 2 PID: 683 Comm: Binder:218_4 Not tainted 4.4.36 #62
>> [49451.856443] Hardware name: Rockchip RK3399 Excavator Board edp (Android) (DT)
>> [49451.856469] Call trace:
>> [49451.856519] [<ffffff900808a9d0>] dump_backtrace+0x0/0x230
>> [49451.856556] [<ffffff900808ac14>] show_stack+0x14/0x1c
>> [49451.856592] [<ffffff90084a4de0>] dump_stack+0xa0/0xc8
>> [49451.856633] [<ffffff900821b700>] kasan_report+0x110/0x4dc
>> [49451.856670] [<ffffff900821aa84>] __asan_store8+0x24/0x7c
>> [49451.856715] [<ffffff90086158c4>] drm_mm_insert_node_generic+0x2dc/0x464
>> [49451.856760] [<ffffff90086406a8>] rockchip_gem_iommu_map+0x60/0x158
>> [49451.856794] [<ffffff9008640bb4>] rockchip_gem_create_object+0x278/0x488
>> [49451.856827] [<ffffff9008641020>] rockchip_gem_create_with_handle+0x24/0x10c
>> [49451.856862] [<ffffff9008641364>] rockchip_gem_create_ioctl+0x3c/0x50
>> [49451.856896] [<ffffff900860aee4>] drm_ioctl+0x354/0x52c
>> [49451.856939] [<ffffff900823d948>] do_vfs_ioctl+0x670/0x78c
>> [49451.856976] [<ffffff900823dac4>] SyS_ioctl+0x60/0x88
>> [49451.857009] [<ffffff9008082ef0>] el0_svc_naked+0x24/0x28
>>
>> Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891
> This is meaningless in an upstream tree. Please remove.
>
> Thierry
Right, Forget to remove "Change-Id: "
Thanks.
--
Ｍark Yao
WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm
Date: Wed, 8 Feb 2017 08:28:12 +0800 [thread overview]
Message-ID: <589A661C.5070505@rock-chips.com> (raw)
In-Reply-To: <20170207121909.GA18315@ulmo.ba.sec>
On 2017年02月07日 20:19, Thierry Reding wrote:
> On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote:
>> drm_mm_insert_node_generic and drm_mm_remove_node may access same
>> resource with list ops, it's not threads safe, so protect this context
>> with mutex lock.
>>
>> Fix bug:
>> [49451.856244] ==================================================================
>> [49451.856350] BUG: KASAN: wild-memory-access on address dead000000000108
>> [49451.856379] Write of size 8 by task Binder:218_4/683
>> [49451.856417] CPU: 2 PID: 683 Comm: Binder:218_4 Not tainted 4.4.36 #62
>> [49451.856443] Hardware name: Rockchip RK3399 Excavator Board edp (Android) (DT)
>> [49451.856469] Call trace:
>> [49451.856519] [<ffffff900808a9d0>] dump_backtrace+0x0/0x230
>> [49451.856556] [<ffffff900808ac14>] show_stack+0x14/0x1c
>> [49451.856592] [<ffffff90084a4de0>] dump_stack+0xa0/0xc8
>> [49451.856633] [<ffffff900821b700>] kasan_report+0x110/0x4dc
>> [49451.856670] [<ffffff900821aa84>] __asan_store8+0x24/0x7c
>> [49451.856715] [<ffffff90086158c4>] drm_mm_insert_node_generic+0x2dc/0x464
>> [49451.856760] [<ffffff90086406a8>] rockchip_gem_iommu_map+0x60/0x158
>> [49451.856794] [<ffffff9008640bb4>] rockchip_gem_create_object+0x278/0x488
>> [49451.856827] [<ffffff9008641020>] rockchip_gem_create_with_handle+0x24/0x10c
>> [49451.856862] [<ffffff9008641364>] rockchip_gem_create_ioctl+0x3c/0x50
>> [49451.856896] [<ffffff900860aee4>] drm_ioctl+0x354/0x52c
>> [49451.856939] [<ffffff900823d948>] do_vfs_ioctl+0x670/0x78c
>> [49451.856976] [<ffffff900823dac4>] SyS_ioctl+0x60/0x88
>> [49451.857009] [<ffffff9008082ef0>] el0_svc_naked+0x24/0x28
>>
>> Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891
> This is meaningless in an upstream tree. Please remove.
>
> Thierry
Right, Forget to remove "Change-Id: "
Thanks.
--
Ｍark Yao
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm
Date: Wed, 8 Feb 2017 08:28:12 +0800 [thread overview]
Message-ID: <589A661C.5070505@rock-chips.com> (raw)
In-Reply-To: <20170207121909.GA18315@ulmo.ba.sec>
On 2017?02?07? 20:19, Thierry Reding wrote:
> On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote:
>> drm_mm_insert_node_generic and drm_mm_remove_node may access same
>> resource with list ops, it's not threads safe, so protect this context
>> with mutex lock.
>>
>> Fix bug:
>> [49451.856244] ==================================================================
>> [49451.856350] BUG: KASAN: wild-memory-access on address dead000000000108
>> [49451.856379] Write of size 8 by task Binder:218_4/683
>> [49451.856417] CPU: 2 PID: 683 Comm: Binder:218_4 Not tainted 4.4.36 #62
>> [49451.856443] Hardware name: Rockchip RK3399 Excavator Board edp (Android) (DT)
>> [49451.856469] Call trace:
>> [49451.856519] [<ffffff900808a9d0>] dump_backtrace+0x0/0x230
>> [49451.856556] [<ffffff900808ac14>] show_stack+0x14/0x1c
>> [49451.856592] [<ffffff90084a4de0>] dump_stack+0xa0/0xc8
>> [49451.856633] [<ffffff900821b700>] kasan_report+0x110/0x4dc
>> [49451.856670] [<ffffff900821aa84>] __asan_store8+0x24/0x7c
>> [49451.856715] [<ffffff90086158c4>] drm_mm_insert_node_generic+0x2dc/0x464
>> [49451.856760] [<ffffff90086406a8>] rockchip_gem_iommu_map+0x60/0x158
>> [49451.856794] [<ffffff9008640bb4>] rockchip_gem_create_object+0x278/0x488
>> [49451.856827] [<ffffff9008641020>] rockchip_gem_create_with_handle+0x24/0x10c
>> [49451.856862] [<ffffff9008641364>] rockchip_gem_create_ioctl+0x3c/0x50
>> [49451.856896] [<ffffff900860aee4>] drm_ioctl+0x354/0x52c
>> [49451.856939] [<ffffff900823d948>] do_vfs_ioctl+0x670/0x78c
>> [49451.856976] [<ffffff900823dac4>] SyS_ioctl+0x60/0x88
>> [49451.857009] [<ffffff9008082ef0>] el0_svc_naked+0x24/0x28
>>
>> Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891
> This is meaningless in an upstream tree. Please remove.
>
> Thierry
Right, Forget to remove "Change-Id: "
Thanks.
--
?ark Yao
next prev parent reply other threads:[~2017-02-08 0:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 8:35 [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` [PATCH v2 1/7] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` [PATCH v2 2/7] drm/rockchip: Use common IOMMU API to attach devices Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 12:19 ` Thierry Reding
2017-02-07 12:19 ` Thierry Reding
2017-02-07 12:19 ` Thierry Reding
2017-02-08 0:28 ` Mark yao [this message]
2017-02-08 0:28 ` Mark yao
2017-02-08 0:28 ` Mark yao
2017-02-07 8:35 ` [PATCH v2 4/7] drm/rockchip: gem: fixup iommu_map_sg error path Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:39 ` [PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 12:33 ` Thierry Reding
2017-02-07 12:33 ` Thierry Reding
2017-02-07 12:33 ` Thierry Reding
2017-02-07 8:39 ` [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 12:37 ` Thierry Reding
2017-02-07 12:37 ` Thierry Reding
2017-02-07 12:37 ` Thierry Reding
2017-02-07 13:05 ` Tomasz Figa
2017-02-07 13:05 ` Tomasz Figa
2017-02-07 13:05 ` Tomasz Figa
2017-02-07 12:38 ` [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu Thierry Reding
2017-02-07 12:38 ` Thierry Reding
2017-02-07 12:38 ` Thierry Reding
2017-02-08 1:15 ` Mark yao
2017-02-08 1:15 ` Mark yao
2017-02-08 1:15 ` Mark yao
2017-02-08 23:36 ` Heiko Stübner
2017-02-08 23:36 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589A661C.5070505@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.