From: Tomasz Figa <tfiga@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>,
dri-devel <dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base
Date: Tue, 7 Feb 2017 22:05:39 +0900 [thread overview]
Message-ID: <CAAFQd5DX9fTzKr8OA8eFs6QN2Mb2cSTSJCwgy3_Wd=ioxJ1oOg@mail.gmail.com> (raw)
In-Reply-To: <20170207123707.GC18315@ulmo.ba.sec>
Hi Mark,
On Tue, Feb 7, 2017 at 9:37 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote:
>> From: Tomasz Figa <tfiga@chromium.org>
>>
>> When converting the driver to use shmem-backed GEMs for IOMMU-enabled
>> systems, we forgot to add calls to drm_gem_object_release(), which gave
>> us a quite nice memory leak. This patch adds the missing calls.
>>
>> Fixes: f11d5f0 ("FROMLIST: drm/rockchip: Do not use DMA mapping API if
>> attached to IOMMU domain")
Since the patch being fixed is also a part of this series, the fix
could be just squashed directly (with sign-off lists merged). Same for
patch 6/7.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base
Date: Tue, 7 Feb 2017 22:05:39 +0900 [thread overview]
Message-ID: <CAAFQd5DX9fTzKr8OA8eFs6QN2Mb2cSTSJCwgy3_Wd=ioxJ1oOg@mail.gmail.com> (raw)
In-Reply-To: <20170207123707.GC18315@ulmo.ba.sec>
Hi Mark,
On Tue, Feb 7, 2017 at 9:37 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote:
>> From: Tomasz Figa <tfiga@chromium.org>
>>
>> When converting the driver to use shmem-backed GEMs for IOMMU-enabled
>> systems, we forgot to add calls to drm_gem_object_release(), which gave
>> us a quite nice memory leak. This patch adds the missing calls.
>>
>> Fixes: f11d5f0 ("FROMLIST: drm/rockchip: Do not use DMA mapping API if
>> attached to IOMMU domain")
Since the patch being fixed is also a part of this series, the fix
could be just squashed directly (with sign-off lists merged). Same for
patch 6/7.
Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: tfiga@chromium.org (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base
Date: Tue, 7 Feb 2017 22:05:39 +0900 [thread overview]
Message-ID: <CAAFQd5DX9fTzKr8OA8eFs6QN2Mb2cSTSJCwgy3_Wd=ioxJ1oOg@mail.gmail.com> (raw)
In-Reply-To: <20170207123707.GC18315@ulmo.ba.sec>
Hi Mark,
On Tue, Feb 7, 2017 at 9:37 PM, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote:
>> From: Tomasz Figa <tfiga@chromium.org>
>>
>> When converting the driver to use shmem-backed GEMs for IOMMU-enabled
>> systems, we forgot to add calls to drm_gem_object_release(), which gave
>> us a quite nice memory leak. This patch adds the missing calls.
>>
>> Fixes: f11d5f0 ("FROMLIST: drm/rockchip: Do not use DMA mapping API if
>> attached to IOMMU domain")
Since the patch being fixed is also a part of this series, the fix
could be just squashed directly (with sign-off lists merged). Same for
patch 6/7.
Best regards,
Tomasz
next prev parent reply other threads:[~2017-02-07 13:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 8:35 [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` [PATCH v2 1/7] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` [PATCH v2 2/7] drm/rockchip: Use common IOMMU API to attach devices Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 12:19 ` Thierry Reding
2017-02-07 12:19 ` Thierry Reding
2017-02-07 12:19 ` Thierry Reding
2017-02-08 0:28 ` Mark yao
2017-02-08 0:28 ` Mark yao
2017-02-08 0:28 ` Mark yao
2017-02-07 8:35 ` [PATCH v2 4/7] drm/rockchip: gem: fixup iommu_map_sg error path Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:35 ` Mark Yao
2017-02-07 8:39 ` [PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 12:33 ` Thierry Reding
2017-02-07 12:33 ` Thierry Reding
2017-02-07 12:33 ` Thierry Reding
2017-02-07 8:39 ` [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 8:39 ` Mark Yao
2017-02-07 12:37 ` Thierry Reding
2017-02-07 12:37 ` Thierry Reding
2017-02-07 12:37 ` Thierry Reding
2017-02-07 13:05 ` Tomasz Figa [this message]
2017-02-07 13:05 ` Tomasz Figa
2017-02-07 13:05 ` Tomasz Figa
2017-02-07 12:38 ` [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu Thierry Reding
2017-02-07 12:38 ` Thierry Reding
2017-02-07 12:38 ` Thierry Reding
2017-02-08 1:15 ` Mark yao
2017-02-08 1:15 ` Mark yao
2017-02-08 1:15 ` Mark yao
2017-02-08 23:36 ` Heiko Stübner
2017-02-08 23:36 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAFQd5DX9fTzKr8OA8eFs6QN2Mb2cSTSJCwgy3_Wd=ioxJ1oOg@mail.gmail.com' \
--to=tfiga@chromium.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.