From: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: knaack.h-Mmb7MZpHnFY@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
Michael.Hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alexandru.ardelean-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v3 2/2] iio: ad5272: Add support for Analog Devices digital potentiometers
Date: Mon, 29 Jan 2018 10:08:16 +0800 [thread overview]
Message-ID: <59571332-0fd7-940a-7c45-c32a5e224195@electromag.com.au> (raw)
In-Reply-To: <20180120171241.7d36898d@archlinux>
On 21/01/2018 01:12, Jonathan Cameron wrote:
> On Wed, 17 Jan 2018 11:38:28 +0800
> Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org> wrote:
>
>> Add implementation for Analog Devices AD5272 and AD5274 digital
>> potentiometer devices.
>>
>> Signed-off-by: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
> A couple more minor comments.
>
...
>> menu "Digital potentiometers"
>>
>> +config AD5272
>> + tristate "Analog Devices AD5272 Digital Potentiometer driver"
>> + depends on I2C
>> + help
>> + Say yes here to build support for the Analog Devices AD5272
>> + digital potentiometer chip.
>
> You need to list he compatible parts here so that people looking for
> the driver can find it. Usually the short text states 'and similar'
> and the help text contains a list of parts. AD5274 is missing here.
ok
...
>> + if (reset_gpio) {
>> + udelay(1);
>> + gpiod_set_value(reset_gpio, 1);
>> + } else {
>> + ad5272_write(data, AD5272_RESET, 0);
>> + }
>> + usleep_range(1000, 2000);
> kernel coding conventions (and readability) put a blank line
> before return statements.
> ok
--
Regards
Phil Reid
WARNING: multiple messages have this Message-ID (diff)
From: Phil Reid <preid@electromag.com.au>
To: Jonathan Cameron <jic23@kernel.org>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
robh+dt@kernel.org, mark.rutland@arm.com,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, alexandru.ardelean@analog.com
Subject: Re: [PATCH v3 2/2] iio: ad5272: Add support for Analog Devices digital potentiometers
Date: Mon, 29 Jan 2018 10:08:16 +0800 [thread overview]
Message-ID: <59571332-0fd7-940a-7c45-c32a5e224195@electromag.com.au> (raw)
In-Reply-To: <20180120171241.7d36898d@archlinux>
On 21/01/2018 01:12, Jonathan Cameron wrote:
> On Wed, 17 Jan 2018 11:38:28 +0800
> Phil Reid <preid@electromag.com.au> wrote:
>
>> Add implementation for Analog Devices AD5272 and AD5274 digital
>> potentiometer devices.
>>
>> Signed-off-by: Phil Reid <preid@electromag.com.au>
> A couple more minor comments.
>
...
>> menu "Digital potentiometers"
>>
>> +config AD5272
>> + tristate "Analog Devices AD5272 Digital Potentiometer driver"
>> + depends on I2C
>> + help
>> + Say yes here to build support for the Analog Devices AD5272
>> + digital potentiometer chip.
>
> You need to list he compatible parts here so that people looking for
> the driver can find it. Usually the short text states 'and similar'
> and the help text contains a list of parts. AD5274 is missing here.
ok
...
>> + if (reset_gpio) {
>> + udelay(1);
>> + gpiod_set_value(reset_gpio, 1);
>> + } else {
>> + ad5272_write(data, AD5272_RESET, 0);
>> + }
>> + usleep_range(1000, 2000);
> kernel coding conventions (and readability) put a blank line
> before return statements.
> ok
--
Regards
Phil Reid
next prev parent reply other threads:[~2018-01-29 2:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 3:38 [PATCH v3 0/2] iio: ad5272: Add support for Analog Devices digital potentiometers Phil Reid
2018-01-17 3:38 ` Phil Reid
[not found] ` <1516160308-16937-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2018-01-17 3:38 ` [PATCH v3 1/2] dt-bindings: ad5272: Add bindings " Phil Reid
2018-01-17 3:38 ` Phil Reid
2018-01-17 3:38 ` [PATCH v3 2/2] iio: ad5272: Add support " Phil Reid
2018-01-17 3:38 ` Phil Reid
[not found] ` <1516160308-16937-3-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2018-01-20 17:12 ` Jonathan Cameron
2018-01-20 17:12 ` Jonathan Cameron
2018-01-29 2:08 ` Phil Reid [this message]
2018-01-29 2:08 ` Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59571332-0fd7-940a-7c45-c32a5e224195@electromag.com.au \
--to=preid-qgqnfa1juf/o2in0hyhwsidd74u8msao@public.gmane.org \
--cc=Michael.Hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
--cc=alexandru.ardelean-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.