Re: [PATCH] MAINTAINERS: Add explicit check-in policy section

From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
	Lars Kurth <lars.kurth@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>,
	george.dunlap@citrix.com, Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] MAINTAINERS: Add explicit check-in policy section
Date: Thu, 09 May 2019 05:36:41 -0600	[thread overview]
Message-ID: <5CD410C9020000780022D1D7@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <23764.2442.337734.122162@mariner.uk.xensource.com>

>>> On 09.05.19 at 13:05, <ian.jackson@citrix.com> wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit 
> check-in policy section"):
>> On 5/8/19 12:59 PM, Juergen Gross wrote:
>> > 2. In the case the submitter is a maintainer of a modified file it must
>> > have an Ack or Review from either a "nested" maintainer or a Designated
>> > reviewer of that file.
>> 
>> That changes the current meaning of "Designated Reviewer" somewhat.  At
>> the moment, it only means "Send this person an email"; if we did that,
>> it would mean, "This person is more trusted to do reviews than others".
>> 
>> Not sure what I think about that yet.
> 
> I think this is a bad idea.  The purpose was to provide a way for
> someone to be emailed which doesn't involve giving them authority,
> and which is therefore a status which can be granted on request and
> does not require any assessment etc.
> 
> If we chane this we will have to invent a new status to perform this
> function.

I think we will want to do this anyway: "Designated Reviewer" isn't
the same as "Cc <person> on patches" (which may be just because
someone wants to monitor what's being submitted / discussed). At
least that's my (non-native-English) understanding of "designated".

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel