From: George Dunlap <george.dunlap@citrix.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Lars Kurth <lars.kurth@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH] MAINTAINERS: Add explicit check-in policy section
Date: Wed, 8 May 2019 14:45:01 +0100 [thread overview]
Message-ID: <fa19ab5c-0d20-a198-74f4-6ee2fbf00c92@citrix.com> (raw)
In-Reply-To: <d56ae8a0-7770-cb30-7996-a0d68d85e073@suse.com>
On 5/8/19 12:59 PM, Juergen Gross wrote:
> What about variant 2b:
>
> 1. In order to get a change to a given file committed, it must have
> an Ack or Review from at least one maintainer of that file other than
> the submitter.
>
> 2. In the case the submitter is a maintainer of a modified file it must
> have an Ack or Review from either a "nested" maintainer or a Designated
> reviewer of that file.
That changes the current meaning of "Designated Reviewer" somewhat. At
the moment, it only means "Send this person an email"; if we did that,
it would mean, "This person is more trusted to do reviews than others".
Not sure what I think about that yet.
>> + The meaning of nesting
>> + ======================
>
> Everywhere else tabs are used for indenting.
I did try to get my editor to use tabs. I'll try harder next time I
guess. :-/
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: George Dunlap <george.dunlap@citrix.com>
To: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>
Cc: Lars Kurth <lars.kurth@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit check-in policy section
Date: Wed, 8 May 2019 14:45:01 +0100 [thread overview]
Message-ID: <fa19ab5c-0d20-a198-74f4-6ee2fbf00c92@citrix.com> (raw)
Message-ID: <20190508134501.4IJPt6OO1UtYdYuFKSzwJa123jreUeIV1cE3usqQeaY@z> (raw)
In-Reply-To: <d56ae8a0-7770-cb30-7996-a0d68d85e073@suse.com>
On 5/8/19 12:59 PM, Juergen Gross wrote:
> What about variant 2b:
>
> 1. In order to get a change to a given file committed, it must have
> an Ack or Review from at least one maintainer of that file other than
> the submitter.
>
> 2. In the case the submitter is a maintainer of a modified file it must
> have an Ack or Review from either a "nested" maintainer or a Designated
> reviewer of that file.
That changes the current meaning of "Designated Reviewer" somewhat. At
the moment, it only means "Send this person an email"; if we did that,
it would mean, "This person is more trusted to do reviews than others".
Not sure what I think about that yet.
>> + The meaning of nesting
>> + ======================
>
> Everywhere else tabs are used for indenting.
I did try to get my editor to use tabs. I'll try harder next time I
guess. :-/
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-08 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 11:39 [PATCH] MAINTAINERS: Add explicit check-in policy section George Dunlap
2019-05-08 11:39 ` [Xen-devel] " George Dunlap
2019-05-08 11:59 ` Juergen Gross
2019-05-08 11:59 ` [Xen-devel] " Juergen Gross
2019-05-08 13:45 ` George Dunlap [this message]
2019-05-08 13:45 ` George Dunlap
2019-05-09 11:05 ` Ian Jackson
2019-05-09 11:05 ` [Xen-devel] " Ian Jackson
2019-05-09 11:36 ` Jan Beulich
2019-05-09 11:36 ` [Xen-devel] " Jan Beulich
2019-05-08 13:49 ` Jan Beulich
2019-05-08 13:49 ` [Xen-devel] " Jan Beulich
2019-05-08 15:32 ` Stefano Stabellini
2019-05-08 15:32 ` [Xen-devel] " Stefano Stabellini
2019-05-09 11:16 ` Ian Jackson
2019-05-09 11:16 ` [Xen-devel] " Ian Jackson
2019-05-09 11:45 ` George Dunlap
2019-05-09 11:45 ` [Xen-devel] " George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa19ab5c-0d20-a198-74f4-6ee2fbf00c92@citrix.com \
--to=george.dunlap@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.kurth@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.