From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run> Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson <andersson@kernel.org>, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com> Subject: Re: [Freedreno] [RFC PATCH v2 04/13] drm/msm/dpu: remove unused fields from dpu_encoder_virt Date: Tue, 6 Jun 2023 23:29:18 +0300 [thread overview] Message-ID: <5bcbee05-5468-d853-df48-82bf3ae448d8@linaro.org> (raw) In-Reply-To: <94d7d0bf-ad61-628b-f10e-2d676ebe3838@quicinc.com> On 06/06/2023 23:25, Abhinav Kumar wrote: > > > On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: >> Remove historical fields intfs_swapped and topology fields from struct >> dpu_encoder_virt and also remove even more historical docs. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> index 28729c77364f..4ee708264f3b 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> @@ -130,18 +130,12 @@ enum dpu_enc_rc_states { >> * pingpong blocks can be different than num_phys_encs. >> * @hw_dsc: Handle to the DSC blocks used for the display. >> * @dsc_mask: Bitmask of used DSC blocks. >> - * @intfs_swapped: Whether or not the phys_enc interfaces have >> been swapped >> - * for partial update right-only cases, such as pingpong >> - * split where virtual pingpong does not generate IRQs >> * @crtc: Pointer to the currently assigned crtc. Normally you >> * would use crtc->state->encoder_mask to determine the >> * link between encoder/crtc. However in this case we need >> * to track crtc in the disable() hook which is called >> * _after_ encoder_mask is cleared. >> * @connector: If a mode is set, cached pointer to the active >> connector >> - * @crtc_kickoff_cb: Callback into CRTC that will flush & start >> - * all CTL paths >> - * @crtc_kickoff_cb_data: Opaque user data given to crtc_kickoff_cb > > no concerns with the above 3 > >> * @enc_lock: Lock around physical encoder >> * create/destroy/enable/disable >> * @frame_busy_mask: Bitmask tracking which phys_enc we are >> still >> @@ -160,7 +154,6 @@ enum dpu_enc_rc_states { >> * @delayed_off_work: delayed worker to schedule disabling of >> * clks and resources after IDLE_TIMEOUT time. >> * @vsync_event_work: worker to handle vsync event for >> autorefresh >> - * @topology: topology of the display > > As we are still going to go ahead with encoder based allocation for now, > we should keep this topology and start using it for DP DSC's 1:1:1 > topology. It is currently unused, so it can be dropped. Your patchset would have to reintroduce it. And I'm still not happy about the encoder-based allocation. You persuaded me that it is irrelevant for the wide planes. So I'd split it and post the allocation patchset after the virtual-wide is fully reviewed (when would come that blissful moment, btw?). > >> * @idle_timeout: idle timeout duration in milliseconds >> * @wide_bus_en: wide bus is enabled on this interface >> * @dsc: drm_dsc_config pointer, for DSC-enabled encoders >> @@ -180,8 +173,6 @@ struct dpu_encoder_virt { >> unsigned int dsc_mask; >> - bool intfs_swapped; >> - >> struct drm_crtc *crtc; >> struct drm_connector *connector; >> @@ -201,7 +192,6 @@ struct dpu_encoder_virt { >> enum dpu_enc_rc_states rc_state; >> struct delayed_work delayed_off_work; >> struct kthread_work vsync_event_work; >> - struct msm_display_topology topology; >> u32 idle_timeout; -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run> Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson <andersson@kernel.org>, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [RFC PATCH v2 04/13] drm/msm/dpu: remove unused fields from dpu_encoder_virt Date: Tue, 6 Jun 2023 23:29:18 +0300 [thread overview] Message-ID: <5bcbee05-5468-d853-df48-82bf3ae448d8@linaro.org> (raw) In-Reply-To: <94d7d0bf-ad61-628b-f10e-2d676ebe3838@quicinc.com> On 06/06/2023 23:25, Abhinav Kumar wrote: > > > On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: >> Remove historical fields intfs_swapped and topology fields from struct >> dpu_encoder_virt and also remove even more historical docs. >> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> index 28729c77364f..4ee708264f3b 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >> @@ -130,18 +130,12 @@ enum dpu_enc_rc_states { >> * pingpong blocks can be different than num_phys_encs. >> * @hw_dsc: Handle to the DSC blocks used for the display. >> * @dsc_mask: Bitmask of used DSC blocks. >> - * @intfs_swapped: Whether or not the phys_enc interfaces have >> been swapped >> - * for partial update right-only cases, such as pingpong >> - * split where virtual pingpong does not generate IRQs >> * @crtc: Pointer to the currently assigned crtc. Normally you >> * would use crtc->state->encoder_mask to determine the >> * link between encoder/crtc. However in this case we need >> * to track crtc in the disable() hook which is called >> * _after_ encoder_mask is cleared. >> * @connector: If a mode is set, cached pointer to the active >> connector >> - * @crtc_kickoff_cb: Callback into CRTC that will flush & start >> - * all CTL paths >> - * @crtc_kickoff_cb_data: Opaque user data given to crtc_kickoff_cb > > no concerns with the above 3 > >> * @enc_lock: Lock around physical encoder >> * create/destroy/enable/disable >> * @frame_busy_mask: Bitmask tracking which phys_enc we are >> still >> @@ -160,7 +154,6 @@ enum dpu_enc_rc_states { >> * @delayed_off_work: delayed worker to schedule disabling of >> * clks and resources after IDLE_TIMEOUT time. >> * @vsync_event_work: worker to handle vsync event for >> autorefresh >> - * @topology: topology of the display > > As we are still going to go ahead with encoder based allocation for now, > we should keep this topology and start using it for DP DSC's 1:1:1 > topology. It is currently unused, so it can be dropped. Your patchset would have to reintroduce it. And I'm still not happy about the encoder-based allocation. You persuaded me that it is irrelevant for the wide planes. So I'd split it and post the allocation patchset after the virtual-wide is fully reviewed (when would come that blissful moment, btw?). > >> * @idle_timeout: idle timeout duration in milliseconds >> * @wide_bus_en: wide bus is enabled on this interface >> * @dsc: drm_dsc_config pointer, for DSC-enabled encoders >> @@ -180,8 +173,6 @@ struct dpu_encoder_virt { >> unsigned int dsc_mask; >> - bool intfs_swapped; >> - >> struct drm_crtc *crtc; >> struct drm_connector *connector; >> @@ -201,7 +192,6 @@ struct dpu_encoder_virt { >> enum dpu_enc_rc_states rc_state; >> struct delayed_work delayed_off_work; >> struct kthread_work vsync_event_work; >> - struct msm_display_topology topology; >> u32 idle_timeout; -- With best wishes Dmitry
next prev parent reply other threads:[~2023-06-06 20:29 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-21 1:18 [RFC PATCH v2 00/13] drm/msm/dpu: support virtual wide planes Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 01/13] drm/atomic-helper: split not-scaling part of drm_atomic_helper_check_plane_state Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-12 22:12 ` Abhinav Kumar 2023-05-12 22:12 ` Abhinav Kumar 2023-05-14 17:01 ` Dmitry Baryshkov 2023-05-14 17:01 ` Dmitry Baryshkov 2023-05-15 18:45 ` Abhinav Kumar 2023-05-15 18:45 ` Abhinav Kumar 2023-05-15 19:12 ` Dmitry Baryshkov 2023-05-15 19:12 ` Dmitry Baryshkov 2023-05-15 19:32 ` Abhinav Kumar 2023-05-15 19:32 ` Abhinav Kumar 2023-03-21 1:18 ` [RFC PATCH v2 03/13] drm/msm/dpu: encoder: simplify debugfs handling Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-12 22:18 ` Abhinav Kumar 2023-05-12 22:18 ` Abhinav Kumar 2023-05-14 17:02 ` Dmitry Baryshkov 2023-05-14 17:02 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 04/13] drm/msm/dpu: remove unused fields from dpu_encoder_virt Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-06-06 20:25 ` [Freedreno] " Abhinav Kumar 2023-06-06 20:25 ` Abhinav Kumar 2023-06-06 20:29 ` Dmitry Baryshkov [this message] 2023-06-06 20:29 ` Dmitry Baryshkov 2023-06-06 20:36 ` Abhinav Kumar 2023-06-06 20:36 ` Abhinav Kumar 2023-03-21 1:18 ` [RFC PATCH v2 05/13] drm/msm/dpu: get rid of struct dpu_rm_requirements Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-12 22:39 ` Abhinav Kumar 2023-05-12 22:39 ` Abhinav Kumar 2023-05-14 17:06 ` Dmitry Baryshkov 2023-05-14 17:06 ` Dmitry Baryshkov 2023-05-17 23:53 ` Abhinav Kumar 2023-05-17 23:53 ` Abhinav Kumar 2023-05-18 23:19 ` Abhinav Kumar 2023-05-18 23:19 ` Abhinav Kumar 2023-03-21 1:18 ` [RFC PATCH v2 06/13] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-18 23:46 ` Abhinav Kumar 2023-05-18 23:46 ` Abhinav Kumar 2023-05-19 1:50 ` Dmitry Baryshkov 2023-05-19 1:50 ` Dmitry Baryshkov 2023-05-22 22:22 ` [Freedreno] " Abhinav Kumar 2023-05-22 22:22 ` Abhinav Kumar 2023-05-23 7:25 ` Dmitry Baryshkov 2023-05-23 7:25 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 07/13] drm/msm/dpu: move resource allocation to CRTC Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 08/13] drm/msm/dpu: fill CRTC resources in dpu_crtc.c Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-24 22:46 ` Abhinav Kumar 2023-05-24 22:46 ` Abhinav Kumar 2023-05-24 23:04 ` [Freedreno] " Abhinav Kumar 2023-05-24 23:04 ` Abhinav Kumar 2023-05-25 1:40 ` Dmitry Baryshkov 2023-05-25 1:40 ` Dmitry Baryshkov 2023-06-06 20:27 ` Abhinav Kumar 2023-06-06 20:27 ` Abhinav Kumar 2023-03-21 1:18 ` [RFC PATCH v2 10/13] drm/msm/dpu: add list of supported formats to the DPU caps Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-24 23:16 ` Abhinav Kumar 2023-05-24 23:16 ` Abhinav Kumar 2023-05-25 1:47 ` Dmitry Baryshkov 2023-05-25 1:47 ` Dmitry Baryshkov 2023-06-06 21:14 ` Abhinav Kumar 2023-06-06 21:14 ` Abhinav Kumar 2023-06-06 21:29 ` Dmitry Baryshkov 2023-06-06 21:29 ` Dmitry Baryshkov 2023-06-06 21:47 ` Abhinav Kumar 2023-06-06 21:47 ` Abhinav Kumar 2023-06-06 21:52 ` Dmitry Baryshkov 2023-06-06 21:52 ` Dmitry Baryshkov 2023-06-06 22:47 ` Abhinav Kumar 2023-06-06 22:47 ` Abhinav Kumar 2023-06-06 22:50 ` Dmitry Baryshkov 2023-06-06 22:50 ` Dmitry Baryshkov 2023-06-06 22:57 ` [Freedreno] " Abhinav Kumar 2023-06-06 22:57 ` Abhinav Kumar 2023-06-06 22:59 ` Dmitry Baryshkov 2023-06-06 22:59 ` Dmitry Baryshkov 2023-06-06 23:14 ` Abhinav Kumar 2023-06-06 23:14 ` Abhinav Kumar 2023-06-06 23:21 ` Dmitry Baryshkov 2023-06-06 23:21 ` Dmitry Baryshkov 2023-06-07 1:12 ` Abhinav Kumar 2023-06-07 1:12 ` Abhinav Kumar 2023-03-21 1:18 ` [RFC PATCH v2 11/13] drm/msm/dpu: add a field describing inline rotation to dpu_caps Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-05-24 23:20 ` Abhinav Kumar 2023-05-24 23:20 ` Abhinav Kumar 2023-05-25 1:47 ` Dmitry Baryshkov 2023-05-25 1:47 ` Dmitry Baryshkov 2023-03-21 1:18 ` [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov 2023-06-07 21:05 ` Abhinav Kumar 2023-06-07 21:05 ` Abhinav Kumar 2023-06-07 21:56 ` Dmitry Baryshkov 2023-06-07 21:56 ` Dmitry Baryshkov 2023-06-08 19:51 ` Abhinav Kumar 2023-06-08 19:51 ` Abhinav Kumar 2023-06-10 0:00 ` Abhinav Kumar 2023-06-10 0:00 ` Abhinav Kumar 2023-03-21 1:18 ` [RFC PATCH v2 13/13] drm/msm/dpu: allow using two SSPP blocks for a single plane Dmitry Baryshkov 2023-03-21 1:18 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5bcbee05-5468-d853-df48-82bf3ae448d8@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@gmail.com \ --cc=andersson@kernel.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.