From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: <freedreno@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
<dri-devel@lists.freedesktop.org>,
Stephen Boyd <swboyd@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>
Subject: Re: [Freedreno] [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check
Date: Wed, 24 May 2023 16:04:33 -0700 [thread overview]
Message-ID: <f010d346-fdbe-62b9-c403-4928b2e929fc@quicinc.com> (raw)
In-Reply-To: <4af411bf-290c-0818-bdf2-878b2da15146@quicinc.com>
On 5/24/2023 3:46 PM, Abhinav Kumar wrote:
>
>
> On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote:
>> In preparation to virtualized planes support, move pstate->pipe
>> initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In
>> case of virtual planes the plane's pipe will not be known up to the
>> point of atomic_check() callback.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>
> Will legacy paths be broken with this? So lets say there is no
> atomic_check we will not have a valid sspp anymore.
I think it should still work, even if goes through the modeset crtc, it
should still call drm_atomic_commit() internally which should have the
call to atomic_check, once you confirm this , i can ack this particular
change.
WARNING: multiple messages have this Message-ID (diff)
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
freedreno@lists.freedesktop.org
Subject: Re: [Freedreno] [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check
Date: Wed, 24 May 2023 16:04:33 -0700 [thread overview]
Message-ID: <f010d346-fdbe-62b9-c403-4928b2e929fc@quicinc.com> (raw)
In-Reply-To: <4af411bf-290c-0818-bdf2-878b2da15146@quicinc.com>
On 5/24/2023 3:46 PM, Abhinav Kumar wrote:
>
>
> On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote:
>> In preparation to virtualized planes support, move pstate->pipe
>> initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In
>> case of virtual planes the plane's pipe will not be known up to the
>> point of atomic_check() callback.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>
> Will legacy paths be broken with this? So lets say there is no
> atomic_check we will not have a valid sspp anymore.
I think it should still work, even if goes through the modeset crtc, it
should still call drm_atomic_commit() internally which should have the
call to atomic_check, once you confirm this , i can ack this particular
change.
next prev parent reply other threads:[~2023-05-24 23:05 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 1:18 [RFC PATCH v2 00/13] drm/msm/dpu: support virtual wide planes Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 01/13] drm/atomic-helper: split not-scaling part of drm_atomic_helper_check_plane_state Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-12 22:12 ` Abhinav Kumar
2023-05-12 22:12 ` Abhinav Kumar
2023-05-14 17:01 ` Dmitry Baryshkov
2023-05-14 17:01 ` Dmitry Baryshkov
2023-05-15 18:45 ` Abhinav Kumar
2023-05-15 18:45 ` Abhinav Kumar
2023-05-15 19:12 ` Dmitry Baryshkov
2023-05-15 19:12 ` Dmitry Baryshkov
2023-05-15 19:32 ` Abhinav Kumar
2023-05-15 19:32 ` Abhinav Kumar
2023-03-21 1:18 ` [RFC PATCH v2 03/13] drm/msm/dpu: encoder: simplify debugfs handling Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-12 22:18 ` Abhinav Kumar
2023-05-12 22:18 ` Abhinav Kumar
2023-05-14 17:02 ` Dmitry Baryshkov
2023-05-14 17:02 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 04/13] drm/msm/dpu: remove unused fields from dpu_encoder_virt Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-06-06 20:25 ` [Freedreno] " Abhinav Kumar
2023-06-06 20:25 ` Abhinav Kumar
2023-06-06 20:29 ` Dmitry Baryshkov
2023-06-06 20:29 ` Dmitry Baryshkov
2023-06-06 20:36 ` Abhinav Kumar
2023-06-06 20:36 ` Abhinav Kumar
2023-03-21 1:18 ` [RFC PATCH v2 05/13] drm/msm/dpu: get rid of struct dpu_rm_requirements Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-12 22:39 ` Abhinav Kumar
2023-05-12 22:39 ` Abhinav Kumar
2023-05-14 17:06 ` Dmitry Baryshkov
2023-05-14 17:06 ` Dmitry Baryshkov
2023-05-17 23:53 ` Abhinav Kumar
2023-05-17 23:53 ` Abhinav Kumar
2023-05-18 23:19 ` Abhinav Kumar
2023-05-18 23:19 ` Abhinav Kumar
2023-03-21 1:18 ` [RFC PATCH v2 06/13] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-18 23:46 ` Abhinav Kumar
2023-05-18 23:46 ` Abhinav Kumar
2023-05-19 1:50 ` Dmitry Baryshkov
2023-05-19 1:50 ` Dmitry Baryshkov
2023-05-22 22:22 ` [Freedreno] " Abhinav Kumar
2023-05-22 22:22 ` Abhinav Kumar
2023-05-23 7:25 ` Dmitry Baryshkov
2023-05-23 7:25 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 07/13] drm/msm/dpu: move resource allocation to CRTC Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 08/13] drm/msm/dpu: fill CRTC resources in dpu_crtc.c Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-24 22:46 ` Abhinav Kumar
2023-05-24 22:46 ` Abhinav Kumar
2023-05-24 23:04 ` Abhinav Kumar [this message]
2023-05-24 23:04 ` [Freedreno] " Abhinav Kumar
2023-05-25 1:40 ` Dmitry Baryshkov
2023-05-25 1:40 ` Dmitry Baryshkov
2023-06-06 20:27 ` Abhinav Kumar
2023-06-06 20:27 ` Abhinav Kumar
2023-03-21 1:18 ` [RFC PATCH v2 10/13] drm/msm/dpu: add list of supported formats to the DPU caps Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-24 23:16 ` Abhinav Kumar
2023-05-24 23:16 ` Abhinav Kumar
2023-05-25 1:47 ` Dmitry Baryshkov
2023-05-25 1:47 ` Dmitry Baryshkov
2023-06-06 21:14 ` Abhinav Kumar
2023-06-06 21:14 ` Abhinav Kumar
2023-06-06 21:29 ` Dmitry Baryshkov
2023-06-06 21:29 ` Dmitry Baryshkov
2023-06-06 21:47 ` Abhinav Kumar
2023-06-06 21:47 ` Abhinav Kumar
2023-06-06 21:52 ` Dmitry Baryshkov
2023-06-06 21:52 ` Dmitry Baryshkov
2023-06-06 22:47 ` Abhinav Kumar
2023-06-06 22:47 ` Abhinav Kumar
2023-06-06 22:50 ` Dmitry Baryshkov
2023-06-06 22:50 ` Dmitry Baryshkov
2023-06-06 22:57 ` [Freedreno] " Abhinav Kumar
2023-06-06 22:57 ` Abhinav Kumar
2023-06-06 22:59 ` Dmitry Baryshkov
2023-06-06 22:59 ` Dmitry Baryshkov
2023-06-06 23:14 ` Abhinav Kumar
2023-06-06 23:14 ` Abhinav Kumar
2023-06-06 23:21 ` Dmitry Baryshkov
2023-06-06 23:21 ` Dmitry Baryshkov
2023-06-07 1:12 ` Abhinav Kumar
2023-06-07 1:12 ` Abhinav Kumar
2023-03-21 1:18 ` [RFC PATCH v2 11/13] drm/msm/dpu: add a field describing inline rotation to dpu_caps Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-05-24 23:20 ` Abhinav Kumar
2023-05-24 23:20 ` Abhinav Kumar
2023-05-25 1:47 ` Dmitry Baryshkov
2023-05-25 1:47 ` Dmitry Baryshkov
2023-03-21 1:18 ` [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
2023-06-07 21:05 ` Abhinav Kumar
2023-06-07 21:05 ` Abhinav Kumar
2023-06-07 21:56 ` Dmitry Baryshkov
2023-06-07 21:56 ` Dmitry Baryshkov
2023-06-08 19:51 ` Abhinav Kumar
2023-06-08 19:51 ` Abhinav Kumar
2023-06-10 0:00 ` Abhinav Kumar
2023-06-10 0:00 ` Abhinav Kumar
2023-03-21 1:18 ` [RFC PATCH v2 13/13] drm/msm/dpu: allow using two SSPP blocks for a single plane Dmitry Baryshkov
2023-03-21 1:18 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f010d346-fdbe-62b9-c403-4928b2e929fc@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.