From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it
Date: Tue, 20 Oct 2020 11:26:34 +0200 [thread overview]
Message-ID: <5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net> (raw)
In-Reply-To: 20201020073839.29226-1-geert@linux-m68k.org
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
Hi Geert,
Thank you for the patch!
On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
> is done for all other IPv6 features.
Here again, the intension was to select IPv6 from MPTCP but I understand
the issue: if we enable MPTCP, we will select IPV6 as well by default.
Maybe not what we want on some embedded devices with very limited memory
where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
IPV6=y. LGTM then!
Reviewed-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
WARNING: multiple messages have this Message-ID (diff)
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Florian Westphal <fw@strlen.de>,
Peter Krystad <peter.krystad@linux.intel.com>
Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it
Date: Tue, 20 Oct 2020 11:26:34 +0200 [thread overview]
Message-ID: <5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net> (raw)
In-Reply-To: <20201020073839.29226-1-geert@linux-m68k.org>
Hi Geert,
Thank you for the patch!
On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
> is done for all other IPv6 features.
Here again, the intension was to select IPv6 from MPTCP but I understand
the issue: if we enable MPTCP, we will select IPV6 as well by default.
Maybe not what we want on some embedded devices with very limited memory
where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
IPV6=y. LGTM then!
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next reply other threads:[~2020-10-20 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:26 Matthieu Baerts [this message]
2020-10-20 9:26 ` [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2020-10-21 10:54 [MPTCP] " Matthieu Baerts
2020-10-21 10:54 ` Matthieu Baerts
2020-10-21 9:52 [MPTCP] " Geert Uytterhoeven
2020-10-21 9:52 ` Geert Uytterhoeven
2020-10-21 9:47 [MPTCP] " Matthieu Baerts
2020-10-21 9:47 ` Matthieu Baerts
2020-10-21 9:43 [MPTCP] " Geert Uytterhoeven
2020-10-21 9:43 ` Geert Uytterhoeven
2020-10-21 3:56 [MPTCP] " Jakub Kicinski
2020-10-21 3:56 ` Jakub Kicinski
2020-10-20 7:38 [MPTCP] " Geert Uytterhoeven
2020-10-20 7:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.