From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it
Date: Wed, 21 Oct 2020 11:47:09 +0200 [thread overview]
Message-ID: <619601b2-40c1-9257-ef2a-2c667361aa75@tessares.net> (raw)
In-Reply-To: CAMuHMdW=1LfE8UoGRVBvrvrintQMNKUdTe5PPQz=PN3=gJmw=Q@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
Hi Geert,
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
> Hi Jakub,
>
> On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski <kuba(a)kernel.org> wrote:
>> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
>>> On 20/10/2020 09:38, Geert Uytterhoeven wrote:
>>>> MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
>>>> not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
>>>> is done for all other IPv6 features.
>>>
>>> Here again, the intension was to select IPv6 from MPTCP but I understand
>>> the issue: if we enable MPTCP, we will select IPV6 as well by default.
>>> Maybe not what we want on some embedded devices with very limited memory
>>> where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
>>> IPV6=y. LGTM then!
>>>
>>> Reviewed-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
>>
>> Applied, thanks!
>
> My apologies, this fails for the CONFIG_IPV6=m and CONFIG_MPTCP=y
> case:
Good point, MPTCP cannot be compiled as a module (like TCP). It should
then depends on IPV6=y. I thought it would be the case.
Do you want me to send a patch or do you already have one?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
WARNING: multiple messages have this Message-ID (diff)
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Jakub Kicinski <kuba@kernel.org>
Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Peter Krystad <peter.krystad@linux.intel.com>,
netdev <netdev@vger.kernel.org>,
mptcp@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it
Date: Wed, 21 Oct 2020 11:47:09 +0200 [thread overview]
Message-ID: <619601b2-40c1-9257-ef2a-2c667361aa75@tessares.net> (raw)
In-Reply-To: <CAMuHMdW=1LfE8UoGRVBvrvrintQMNKUdTe5PPQz=PN3=gJmw=Q@mail.gmail.com>
Hi Geert,
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
> Hi Jakub,
>
> On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski <kuba@kernel.org> wrote:
>> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
>>> On 20/10/2020 09:38, Geert Uytterhoeven wrote:
>>>> MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
>>>> not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
>>>> is done for all other IPv6 features.
>>>
>>> Here again, the intension was to select IPv6 from MPTCP but I understand
>>> the issue: if we enable MPTCP, we will select IPV6 as well by default.
>>> Maybe not what we want on some embedded devices with very limited memory
>>> where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
>>> IPV6=y. LGTM then!
>>>
>>> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>>
>> Applied, thanks!
>
> My apologies, this fails for the CONFIG_IPV6=m and CONFIG_MPTCP=y
> case:
Good point, MPTCP cannot be compiled as a module (like TCP). It should
then depends on IPV6=y. I thought it would be the case.
Do you want me to send a patch or do you already have one?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next reply other threads:[~2020-10-21 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 9:47 Matthieu Baerts [this message]
2020-10-21 9:47 ` [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2020-10-21 10:54 [MPTCP] " Matthieu Baerts
2020-10-21 10:54 ` Matthieu Baerts
2020-10-21 9:52 [MPTCP] " Geert Uytterhoeven
2020-10-21 9:52 ` Geert Uytterhoeven
2020-10-21 9:43 [MPTCP] " Geert Uytterhoeven
2020-10-21 9:43 ` Geert Uytterhoeven
2020-10-21 3:56 [MPTCP] " Jakub Kicinski
2020-10-21 3:56 ` Jakub Kicinski
2020-10-20 9:26 [MPTCP] " Matthieu Baerts
2020-10-20 9:26 ` Matthieu Baerts
2020-10-20 7:38 [MPTCP] " Geert Uytterhoeven
2020-10-20 7:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=619601b2-40c1-9257-ef2a-2c667361aa75@tessares.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.