From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> To: Brad Larson <brad@pensando.io>, linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control Date: Fri, 5 Mar 2021 12:25:39 +0100 [thread overview] Message-ID: <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> (raw) In-Reply-To: <20210304034141.7062-2-brad@pensando.io> On 04/03/2021 04:41, Brad Larson wrote: > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > drivers/gpio/Kconfig | 6 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-elba-spics.c | 120 +++++++++++++++++++++++++++++++++ > 3 files changed, 127 insertions(+) > create mode 100644 drivers/gpio/gpio-elba-spics.c (...) > +static int elba_spics_probe(struct platform_device *pdev) > +{ > + struct elba_spics_priv *p; > + struct resource *res; > + int ret; > + > + p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL); > + if (!p) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + p->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(p->base)) { > + dev_err(&pdev->dev, "failed to remap I/O memory\n"); > + return PTR_ERR(p->base); > + } > + spin_lock_init(&p->lock); > + platform_set_drvdata(pdev, p); > + > + p->chip.ngpio = 4; /* 2 cs pins for spi0, and 2 for spi1 */ > + p->chip.base = -1; > + p->chip.direction_input = elba_spics_direction_input; > + p->chip.direction_output = elba_spics_direction_output; > + p->chip.get = elba_spics_get_value; > + p->chip.set = elba_spics_set_value; > + p->chip.label = dev_name(&pdev->dev); > + p->chip.parent = &pdev->dev; > + p->chip.owner = THIS_MODULE; > + > + ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p); > + if (ret) { > + dev_err(&pdev->dev, "unable to add gpio chip\n"); > + return ret; > + } > + > + dev_info(&pdev->dev, "elba spics registered\n"); Don't print trivial probe results, unless you print here something useful. If you need it for debugging, keep it dev_dbg. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> To: Brad Larson <brad@pensando.io>, linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control Date: Fri, 5 Mar 2021 12:25:39 +0100 [thread overview] Message-ID: <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> (raw) In-Reply-To: <20210304034141.7062-2-brad@pensando.io> On 04/03/2021 04:41, Brad Larson wrote: > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > drivers/gpio/Kconfig | 6 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-elba-spics.c | 120 +++++++++++++++++++++++++++++++++ > 3 files changed, 127 insertions(+) > create mode 100644 drivers/gpio/gpio-elba-spics.c (...) > +static int elba_spics_probe(struct platform_device *pdev) > +{ > + struct elba_spics_priv *p; > + struct resource *res; > + int ret; > + > + p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL); > + if (!p) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + p->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(p->base)) { > + dev_err(&pdev->dev, "failed to remap I/O memory\n"); > + return PTR_ERR(p->base); > + } > + spin_lock_init(&p->lock); > + platform_set_drvdata(pdev, p); > + > + p->chip.ngpio = 4; /* 2 cs pins for spi0, and 2 for spi1 */ > + p->chip.base = -1; > + p->chip.direction_input = elba_spics_direction_input; > + p->chip.direction_output = elba_spics_direction_output; > + p->chip.get = elba_spics_get_value; > + p->chip.set = elba_spics_set_value; > + p->chip.label = dev_name(&pdev->dev); > + p->chip.parent = &pdev->dev; > + p->chip.owner = THIS_MODULE; > + > + ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p); > + if (ret) { > + dev_err(&pdev->dev, "unable to add gpio chip\n"); > + return ret; > + } > + > + dev_info(&pdev->dev, "elba spics registered\n"); Don't print trivial probe results, unless you print here something useful. If you need it for debugging, keep it dev_dbg. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-05 11:26 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-04 3:41 [PATCH 0/8] Support Pensando Elba SoC Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 3:41 ` [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 8:29 ` Linus Walleij 2021-03-04 8:29 ` Linus Walleij 2021-03-04 9:10 ` Serge Semin 2021-03-04 9:10 ` Serge Semin 2021-03-04 13:38 ` Linus Walleij 2021-03-04 13:38 ` Linus Walleij 2021-08-23 1:05 ` Brad Larson 2021-08-23 1:05 ` Brad Larson 2021-08-29 21:09 ` Linus Walleij 2021-08-29 21:09 ` Linus Walleij 2021-10-04 16:46 ` Brad Larson 2021-10-04 16:46 ` Brad Larson 2021-10-12 23:51 ` Linus Walleij 2021-10-12 23:51 ` Linus Walleij 2021-10-14 20:06 ` Brad Larson 2021-10-14 20:06 ` Brad Larson 2021-03-30 2:44 ` Brad Larson 2021-03-30 2:44 ` Brad Larson 2021-08-23 1:05 ` Brad Larson 2021-08-23 1:05 ` Brad Larson 2021-03-04 20:43 ` Elliott, Robert (Servers) 2021-03-04 20:43 ` Elliott, Robert (Servers) 2021-08-23 1:06 ` Brad Larson 2021-08-23 1:06 ` Brad Larson 2021-03-05 11:25 ` Krzysztof Kozlowski [this message] 2021-03-05 11:25 ` Krzysztof Kozlowski 2021-08-23 1:07 ` Brad Larson 2021-08-23 1:07 ` Brad Larson 2021-03-05 13:57 ` Geert Uytterhoeven 2021-03-05 13:57 ` Geert Uytterhoeven 2021-08-23 1:08 ` Brad Larson 2021-08-23 1:08 ` Brad Larson 2021-03-07 19:21 ` Andy Shevchenko 2021-03-07 19:21 ` Andy Shevchenko 2021-03-29 1:19 ` Brad Larson 2021-03-29 1:19 ` Brad Larson 2021-03-29 10:39 ` Andy Shevchenko 2021-03-29 10:39 ` Andy Shevchenko 2021-08-23 1:13 ` Brad Larson 2021-08-23 1:13 ` Brad Larson 2021-08-23 7:50 ` Geert Uytterhoeven 2021-08-23 7:50 ` Geert Uytterhoeven 2021-08-23 16:30 ` Brad Larson 2021-08-23 16:30 ` Brad Larson 2021-08-23 20:11 ` Geert Uytterhoeven 2021-08-23 20:11 ` Geert Uytterhoeven 2021-10-04 17:14 ` Brad Larson 2021-10-04 17:14 ` Brad Larson 2021-10-04 17:16 ` Geert Uytterhoeven 2021-10-04 17:16 ` Geert Uytterhoeven 2021-08-23 1:10 ` Brad Larson 2021-08-23 1:10 ` Brad Larson 2021-03-04 3:41 ` [PATCH 2/8] spi: cadence-quadspi: Add QSPI support for Pensando Elba SoC Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 9:29 ` Arnd Bergmann 2021-03-04 9:29 ` Arnd Bergmann 2021-03-04 3:41 ` [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 6:44 ` Serge Semin 2021-03-04 6:44 ` Serge Semin 2021-08-23 1:17 ` Brad Larson 2021-08-23 1:17 ` Brad Larson 2021-03-04 8:48 ` Linus Walleij 2021-03-04 8:48 ` Linus Walleij 2021-03-10 3:52 ` Brad Larson 2021-03-10 3:52 ` Brad Larson 2021-03-04 3:41 ` [PATCH 4/8] spidev: Add Pensando CPLD compatible Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 9:33 ` Arnd Bergmann 2021-03-04 9:33 ` Arnd Bergmann 2021-03-04 3:41 ` [PATCH 5/8] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 9:41 ` Arnd Bergmann 2021-03-04 9:41 ` Arnd Bergmann 2021-03-04 3:41 ` [PATCH 6/8] arm64: Add config for Pensando SoC platforms Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 9:42 ` Arnd Bergmann 2021-03-04 9:42 ` Arnd Bergmann 2021-03-04 3:41 ` [PATCH 7/8] arm64: dts: Add Pensando Elba SoC support Brad Larson 2021-03-04 3:41 ` Brad Larson 2021-03-04 8:03 ` Serge Semin 2021-03-04 8:03 ` Serge Semin 2021-03-29 1:07 ` Brad Larson 2021-03-29 1:07 ` Brad Larson 2021-08-23 0:54 ` Brad Larson 2021-08-23 0:54 ` Brad Larson 2021-03-04 8:51 ` Linus Walleij 2021-03-04 8:51 ` Linus Walleij 2021-03-29 0:54 ` Brad Larson 2021-03-29 0:54 ` Brad Larson 2021-03-04 9:06 ` Arnd Bergmann 2021-03-04 9:06 ` Arnd Bergmann 2021-03-04 20:47 ` Rob Herring 2021-03-04 20:47 ` Rob Herring 2021-03-05 11:22 ` Krzysztof Kozlowski 2021-03-05 11:22 ` Krzysztof Kozlowski 2021-03-04 3:41 ` [PATCH 8/8] MAINTAINERS: Add entry for PENSANDO Brad Larson 2021-03-04 3:41 ` Brad Larson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com \ --to=krzysztof.kozlowski@canonical.com \ --cc=adrian.hunter@intel.com \ --cc=arnd@arndb.de \ --cc=bgolaszewski@baylibre.com \ --cc=brad@pensando.io \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=fancer.lancer@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=olof@lixom.net \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.