All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] tpm: Move pcr extend to tpm2-cmd.c
Date: Thu, 15 Mar 2018 18:47:58 +0200	[thread overview]
Message-ID: <62dcb95fa349f0b195afd3c28c9fa9aeac60fe98.camel@linux.intel.com> (raw)
In-Reply-To: <20180310082428.31519-8-tomas.winkler@intel.com>

On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote:
> Add tpm2_pcr_extend function to tpm2-cmd.c with signature required
> by tpm-interface.c. It wraps the original open code
> implementation. The original original tpm2_pcr_extend function
> is renamed and made static, called only from new tpm2_pcr_extend.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This might concern some of the earlier patches too but please use exact
names for functions in the short and long summary i.e.

  tpm: migrate all of the PCR extension code to tpm2_pcr_extend()

Check this also for your long descriptions and previous that I gave
reviewed-by (I think they were otherwise fine). And you refer to a
function in text use parentheses after the name. I don't like
hastily written commit messages.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 7/8] tpm: Move pcr extend to tpm2-cmd.c
Date: Thu, 15 Mar 2018 18:47:58 +0200	[thread overview]
Message-ID: <62dcb95fa349f0b195afd3c28c9fa9aeac60fe98.camel@linux.intel.com> (raw)
In-Reply-To: <20180310082428.31519-8-tomas.winkler@intel.com>

On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote:
> Add tpm2_pcr_extend function to tpm2-cmd.c with signature required
> by tpm-interface.c. It wraps the original open code
> implementation. The original original tpm2_pcr_extend function
> is renamed and made static, called only from new tpm2_pcr_extend.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This might concern some of the earlier patches too but please use exact
names for functions in the short and long summary i.e.

  tpm: migrate all of the PCR extension code to tpm2_pcr_extend()

Check this also for your long descriptions and previous that I gave
reviewed-by (I think they were otherwise fine). And you refer to a
function in text use parentheses after the name. I don't like
hastily written commit messages.

/Jarkko


--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-03-15 16:48 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10  8:24 [PATCH v2 0/8] tpm: factor out tpm1 code into tpm1-cmd.c Tomas Winkler
2018-03-10  8:24 ` Tomas Winkler
2018-03-10  8:24 ` [PATCH v2 1/8] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:27   ` Jarkko Sakkinen
2018-03-15 16:27     ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 2/8] tpm: move tpm_getcap " Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:29   ` Jarkko Sakkinen
2018-03-15 16:29     ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:32   ` Jarkko Sakkinen
2018-03-15 16:32     ` Jarkko Sakkinen
2018-03-15 23:24     ` Winkler, Tomas
2018-03-15 23:24       ` Winkler, Tomas
2018-03-16 14:02       ` Jarkko Sakkinen
2018-03-16 14:02         ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 4/8] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:37   ` Jarkko Sakkinen
2018-03-15 16:37     ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 5/8] tpm: factor out tpm1 pm suspend flow into tpm1-cmd.c Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:40   ` Jarkko Sakkinen
2018-03-15 16:40     ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 6/8] tpm: factor out tpm_startup function Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:41   ` Jarkko Sakkinen
2018-03-15 16:41     ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 7/8] tpm: Move pcr extend to tpm2-cmd.c Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:47   ` Jarkko Sakkinen [this message]
2018-03-15 16:47     ` Jarkko Sakkinen
2018-03-15 23:28     ` Winkler, Tomas
2018-03-15 23:28       ` Winkler, Tomas
2018-03-16 14:08       ` Jarkko Sakkinen
2018-03-16 14:08         ` Jarkko Sakkinen
2018-03-10  8:24 ` [PATCH v2 8/8] tpm: move tpm2 code validation to tpm2-space.c Tomas Winkler
2018-03-10  8:24   ` Tomas Winkler
2018-03-15 16:49   ` Jarkko Sakkinen
2018-03-15 16:49     ` Jarkko Sakkinen
2018-03-15 16:35 ` [PATCH v2 0/8] tpm: factor out tpm1 code into tpm1-cmd.c Jarkko Sakkinen
2018-03-15 16:35   ` Jarkko Sakkinen
2018-03-15 23:25   ` Winkler, Tomas
2018-03-15 23:25     ` Winkler, Tomas
2018-03-16 14:03     ` Jarkko Sakkinen
2018-03-16 14:03       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62dcb95fa349f0b195afd3c28c9fa9aeac60fe98.camel@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.