From: Satendra Singh Thakur <satendra.t@samsung.com> To: Maxime Ripard <maxime.ripard@bootlin.com>, David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Satendra Singh Thakur <satendra.t@samsung.com>, Madhur Verma <madhur.verma@samsung.com>, Hemanshu Srivastava <hemanshu.s@samsung.com> Subject: [PATCH 09/13] drm/kms/mode/sun4i-tv: using helper func drm_display_mode_from_videomode for calculating timing parameters Date: Thu, 3 May 2018 16:28:06 +0530 [thread overview] Message-ID: <6919c8943505fe0c1f700e223a77194f85e64a58.1525087679.git.satendra.t@samsung.com> (raw) In-Reply-To: <cover.1525087679.git.satendra.t@samsung.com> To avoid duplicate logic for horizonal/vertical sync_start/end helper func drm_display_mode_from_videomode is used Signed-off-by: Satendra Singh Thakur <satendra.t@samsung.com> Cc: Madhur Verma <madhur.verma@samsung.com> Cc: Hemanshu Srivastava <hemanshu.s@samsung.com> --- drivers/gpu/drm/sun4i/sun4i_tv.c | 67 +++++++++++++++------------------------- 1 file changed, 25 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index b070d52..7ffa930 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -21,6 +21,7 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_of.h> #include <drm/drm_panel.h> +#include <video/videomode.h> #include "sun4i_crtc.h" #include "sun4i_drv.h" @@ -147,16 +148,7 @@ struct tv_mode { u16 front_porch; u16 line_number; u16 vblank_level; - - u32 hdisplay; - u16 hfront_porch; - u16 hsync_len; - u16 hback_porch; - - u32 vdisplay; - u16 vfront_porch; - u16 vsync_len; - u16 vback_porch; + struct videomode vm; bool yc_en; bool dac3_en; @@ -223,16 +215,16 @@ static const struct tv_mode tv_modes[] = { .back_porch = 118, .front_porch = 32, .line_number = 525, - - .hdisplay = 720, - .hfront_porch = 18, - .hsync_len = 2, - .hback_porch = 118, - - .vdisplay = 480, - .vfront_porch = 26, - .vsync_len = 2, - .vback_porch = 17, + .vm = { + .hactive = 720, + .hfront_porch = 18, + .hsync_len = 2, + .hback_porch = 118, + .vactive = 480, + .vfront_porch = 26, + .vsync_len = 2, + .vback_porch = 17, + }, .vblank_level = 240, @@ -249,16 +241,16 @@ static const struct tv_mode tv_modes[] = { .back_porch = 138, .front_porch = 24, .line_number = 625, - - .hdisplay = 720, - .hfront_porch = 3, - .hsync_len = 2, - .hback_porch = 139, - - .vdisplay = 576, - .vfront_porch = 28, - .vsync_len = 2, - .vback_porch = 19, + .vm = { + .hactive = 720, + .hfront_porch = 3, + .hsync_len = 2, + .hback_porch = 139, + .vactive = 576, + .vfront_porch = 28, + .vsync_len = 2, + .vback_porch = 19, + }, .vblank_level = 252, @@ -311,9 +303,9 @@ static const struct tv_mode *sun4i_tv_find_tv_by_mode(const struct drm_display_m DRM_DEBUG_DRIVER("Comparing mode %s vs %s (X: %d vs %d)", mode->name, tv_mode->name, - mode->vdisplay, tv_mode->vdisplay); + mode->vdisplay, tv_mode->vm.vactive); - if (mode->vdisplay == tv_mode->vdisplay) + if (mode->vdisplay == tv_mode->vm.vactive) return tv_mode; } @@ -325,19 +317,10 @@ static void sun4i_tv_mode_to_drm_mode(const struct tv_mode *tv_mode, { DRM_DEBUG_DRIVER("Creating mode %s\n", mode->name); + drm_display_mode_from_videomode(&tv_mode->vm, mode); mode->type = DRM_MODE_TYPE_DRIVER; mode->clock = 13500; mode->flags = DRM_MODE_FLAG_INTERLACE; - - mode->hdisplay = tv_mode->hdisplay; - mode->hsync_start = mode->hdisplay + tv_mode->hfront_porch; - mode->hsync_end = mode->hsync_start + tv_mode->hsync_len; - mode->htotal = mode->hsync_end + tv_mode->hback_porch; - - mode->vdisplay = tv_mode->vdisplay; - mode->vsync_start = mode->vdisplay + tv_mode->vfront_porch; - mode->vsync_end = mode->vsync_start + tv_mode->vsync_len; - mode->vtotal = mode->vsync_end + tv_mode->vback_porch; } static void sun4i_tv_disable(struct drm_encoder *encoder) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: satendra.t@samsung.com (Satendra Singh Thakur) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/13] drm/kms/mode/sun4i-tv: using helper func drm_display_mode_from_videomode for calculating timing parameters Date: Thu, 3 May 2018 16:28:06 +0530 [thread overview] Message-ID: <6919c8943505fe0c1f700e223a77194f85e64a58.1525087679.git.satendra.t@samsung.com> (raw) In-Reply-To: <cover.1525087679.git.satendra.t@samsung.com> To avoid duplicate logic for horizonal/vertical sync_start/end helper func drm_display_mode_from_videomode is used Signed-off-by: Satendra Singh Thakur <satendra.t@samsung.com> Cc: Madhur Verma <madhur.verma@samsung.com> Cc: Hemanshu Srivastava <hemanshu.s@samsung.com> --- drivers/gpu/drm/sun4i/sun4i_tv.c | 67 +++++++++++++++------------------------- 1 file changed, 25 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index b070d52..7ffa930 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -21,6 +21,7 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_of.h> #include <drm/drm_panel.h> +#include <video/videomode.h> #include "sun4i_crtc.h" #include "sun4i_drv.h" @@ -147,16 +148,7 @@ struct tv_mode { u16 front_porch; u16 line_number; u16 vblank_level; - - u32 hdisplay; - u16 hfront_porch; - u16 hsync_len; - u16 hback_porch; - - u32 vdisplay; - u16 vfront_porch; - u16 vsync_len; - u16 vback_porch; + struct videomode vm; bool yc_en; bool dac3_en; @@ -223,16 +215,16 @@ static const struct tv_mode tv_modes[] = { .back_porch = 118, .front_porch = 32, .line_number = 525, - - .hdisplay = 720, - .hfront_porch = 18, - .hsync_len = 2, - .hback_porch = 118, - - .vdisplay = 480, - .vfront_porch = 26, - .vsync_len = 2, - .vback_porch = 17, + .vm = { + .hactive = 720, + .hfront_porch = 18, + .hsync_len = 2, + .hback_porch = 118, + .vactive = 480, + .vfront_porch = 26, + .vsync_len = 2, + .vback_porch = 17, + }, .vblank_level = 240, @@ -249,16 +241,16 @@ static const struct tv_mode tv_modes[] = { .back_porch = 138, .front_porch = 24, .line_number = 625, - - .hdisplay = 720, - .hfront_porch = 3, - .hsync_len = 2, - .hback_porch = 139, - - .vdisplay = 576, - .vfront_porch = 28, - .vsync_len = 2, - .vback_porch = 19, + .vm = { + .hactive = 720, + .hfront_porch = 3, + .hsync_len = 2, + .hback_porch = 139, + .vactive = 576, + .vfront_porch = 28, + .vsync_len = 2, + .vback_porch = 19, + }, .vblank_level = 252, @@ -311,9 +303,9 @@ static const struct tv_mode *sun4i_tv_find_tv_by_mode(const struct drm_display_m DRM_DEBUG_DRIVER("Comparing mode %s vs %s (X: %d vs %d)", mode->name, tv_mode->name, - mode->vdisplay, tv_mode->vdisplay); + mode->vdisplay, tv_mode->vm.vactive); - if (mode->vdisplay == tv_mode->vdisplay) + if (mode->vdisplay == tv_mode->vm.vactive) return tv_mode; } @@ -325,19 +317,10 @@ static void sun4i_tv_mode_to_drm_mode(const struct tv_mode *tv_mode, { DRM_DEBUG_DRIVER("Creating mode %s\n", mode->name); + drm_display_mode_from_videomode(&tv_mode->vm, mode); mode->type = DRM_MODE_TYPE_DRIVER; mode->clock = 13500; mode->flags = DRM_MODE_FLAG_INTERLACE; - - mode->hdisplay = tv_mode->hdisplay; - mode->hsync_start = mode->hdisplay + tv_mode->hfront_porch; - mode->hsync_end = mode->hsync_start + tv_mode->hsync_len; - mode->htotal = mode->hsync_end + tv_mode->hback_porch; - - mode->vdisplay = tv_mode->vdisplay; - mode->vsync_start = mode->vdisplay + tv_mode->vfront_porch; - mode->vsync_end = mode->vsync_start + tv_mode->vsync_len; - mode->vtotal = mode->vsync_end + tv_mode->vback_porch; } static void sun4i_tv_disable(struct drm_encoder *encoder) -- 2.7.4
next prev parent reply other threads:[~2018-05-03 10:58 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20180503082417epcas5p19ee919d68eb5ae18f183a41881869cc1@epcas5p1.samsung.com> 2018-05-03 8:23 ` [PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode for calculating timing parameters Satendra Singh Thakur 2018-05-03 8:23 ` Satendra Singh Thakur 2018-05-03 8:23 ` Satendra Singh Thakur 2018-05-03 8:23 ` Satendra Singh Thakur [not found] ` <CGME20180503083608epcas5p4c9cda0f0b42af8232691baa7cbde96c9@epcas5p4.samsung.com> 2018-05-03 8:36 ` [PATCH 01/13] drm/kms/mode/atmel-hlcdc: using helper func drm_display_mode_to_videomode " Satendra Singh Thakur 2018-05-03 8:36 ` Satendra Singh Thakur [not found] ` <CGME20180503083729epcas5p16b374ea53fd3cf338ce7085d6467da13@epcas5p1.samsung.com> 2018-05-03 8:37 ` [PATCH 02/13] drm/kms/mode/bridge-tc358767: " Satendra Singh Thakur [not found] ` <CGME20180503083956epcas5p1eb97f7bd534e58e7154f5f11733e7aa0@epcas5p1.samsung.com> 2018-05-03 8:39 ` [PATCH 03/13] drm/kms/mode/exynos-dsi: " Satendra Singh Thakur 2018-05-03 8:39 ` Satendra Singh Thakur 2018-05-03 12:21 ` Robin Murphy 2018-05-03 12:21 ` Robin Murphy 2018-05-03 12:21 ` Robin Murphy [not found] ` <CGME20180504081613epcas5p405d342fe333975048175c4a360067f52@epcas5p4.samsung.com> 2018-05-04 8:15 ` [PATCH v1 " Satendra Singh Thakur 2018-05-04 8:15 ` Satendra Singh Thakur 2018-05-04 11:25 ` Robin Murphy 2018-05-04 11:25 ` Robin Murphy 2018-05-04 11:25 ` Robin Murphy [not found] ` <CGME20180507033238epcas5p2601b5ccbba8fa02cdde4f1375e90abe9@epcas5p2.samsung.com> 2018-05-07 3:32 ` [PATCH v2 " Satendra Singh Thakur 2018-05-07 3:32 ` Satendra Singh Thakur 2018-05-07 9:33 ` Andrzej Hajda 2018-05-07 9:33 ` Andrzej Hajda 2018-05-07 9:33 ` Andrzej Hajda [not found] ` <CGME20180503084441epcas5p371997e3772a2fe2bfb4dc26447dafe65@epcas5p3.samsung.com> 2018-05-03 8:44 ` [PATCH 04/13] drm/kms/mode/fsl-dcu: " Satendra Singh Thakur 2018-05-07 20:46 ` Stefan Agner 2018-05-07 20:46 ` Stefan Agner [not found] ` <CGME20180508041658epcas5p2deee8f1a13c2b00d7d628063d8b16b00@epcas5p2.samsung.com> 2018-05-08 4:15 ` [PATCH v1 " Satendra Singh Thakur [not found] ` <CGME20180503084655epcas5p127066f560b7c2d75f679e682c914abd6@epcas5p1.samsung.com> 2018-05-03 8:46 ` [PATCH 05/13] drm/kms/mode/gma500-mdfld_dsi_dpi: using helper function " Satendra Singh Thakur [not found] ` <CGME20180503090123epcas5p263afd14e32bc2a50e446bc674f7498d7@epcas5p2.samsung.com> 2018-05-03 9:01 ` [PATCH 06/13] drm/kms/mode/hisilicon-kirin-dsi-ade: " Satendra Singh Thakur 2018-05-03 9:01 ` Satendra Singh Thakur [not found] ` <CGME20180503090930epcas5p23ef09c1e72c344bf8d879a344d0998cf@epcas5p2.samsung.com> 2018-05-03 9:09 ` [PATCH 07/13] drm/kms/mode/meson-encoder: " Satendra Singh Thakur 2018-05-03 9:09 ` Satendra Singh Thakur 2018-05-03 9:09 ` Satendra Singh Thakur [not found] ` <CGME20180503093553epcas5p35363f1990726114a9079be483cc26d9a@epcas5p3.samsung.com> 2018-05-03 9:35 ` [PATCH 08/13] drm/kms/mode/pl111-display: " Satendra Singh Thakur [not found] ` <CGME20180503105821epcas5p21a35d9eb29f83201d337a195d218fdd3@epcas5p2.samsung.com> 2018-05-03 10:58 ` Satendra Singh Thakur [this message] 2018-05-03 10:58 ` [PATCH 09/13] drm/kms/mode/sun4i-tv: using helper func drm_display_mode_from_videomode " Satendra Singh Thakur 2018-05-03 11:02 ` Maxime Ripard 2018-05-03 11:02 ` Maxime Ripard 2018-05-03 11:02 ` Maxime Ripard [not found] ` <CGME20180504082405epcas5p212d6a9fbb2a0baac4166cb5b68616055@epcas5p2.samsung.com> 2018-05-04 8:23 ` [PATCH v1 " Satendra Singh Thakur 2018-05-04 8:23 ` Satendra Singh Thakur [not found] ` <CGME20180503110352epcas5p32d2bbf72da59a6e2183c9eb67c58f1ba@epcas5p3.samsung.com> 2018-05-03 11:03 ` [PATCH 10/13] drm/kms/mode/ti-lcdc: using helper func drm_display_mode_to_videomode " Satendra Singh Thakur [not found] ` <CGME20180503110834epcas5p25cf074e5fe2292c8053dfa9ebe9f8dc7@epcas5p2.samsung.com> 2018-05-03 11:08 ` [PATCH 11/13] drm/kms/mode/tegra: " Satendra Singh Thakur [not found] ` <CGME20180503111008epcas5p26088af1ff767ac0bf06cae934f1da339@epcas5p2.samsung.com> 2018-05-03 11:09 ` [PATCH 12/13] drm/kms/mode/mtk_dpi_dsi: " Satendra Singh Thakur 2018-05-03 11:09 ` Satendra Singh Thakur [not found] ` <CGME20180503111248epcas5p4c2b8d1fd447cfbe0b53cf535faaf92c2@epcas5p4.samsung.com> 2018-05-03 11:12 ` [PATCH 13/13] drm/kms/mode/bridge-adv7533: " Satendra Singh Thakur 2018-05-07 13:46 ` [PATCH 00/13] drm/kms/mode: using helper func drm_display_mode_to/from_videomode " Daniel Vetter 2018-05-07 13:46 ` Daniel Vetter 2018-05-07 13:46 ` Daniel Vetter 2018-05-07 13:46 ` Daniel Vetter [not found] ` <CGME20180508105900epcas5p25ffe94a214e5ad0848d834d6c3562ad6@epcas5p2.samsung.com> 2018-05-08 10:58 ` Satendra Singh Thakur 2018-05-08 10:58 ` Satendra Singh Thakur 2018-05-08 10:58 ` Satendra Singh Thakur [not found] ` <CGME20180509115224epcas5p1c958418bc36fd224e8d36b9511c5beea@epcas5p1.samsung.com> 2018-05-09 11:52 ` Satendra Singh Thakur 2018-05-09 11:52 ` Satendra Singh Thakur 2018-05-09 11:52 ` Satendra Singh Thakur 2018-05-13 14:12 ` Daniel Vetter 2018-05-13 14:12 ` Daniel Vetter 2018-05-13 14:12 ` Daniel Vetter 2018-05-13 14:12 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6919c8943505fe0c1f700e223a77194f85e64a58.1525087679.git.satendra.t@samsung.com \ --to=satendra.t@samsung.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=hemanshu.s@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=madhur.verma@samsung.com \ --cc=maxime.ripard@bootlin.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.