From: Matthew Rosato <mjrosato@linux.ibm.com>
To: kernel test robot <lkp@intel.com>, linux-s390@vger.kernel.org
Cc: kbuild-all@lists.01.org, alex.williamson@redhat.com,
cohuck@redhat.com, schnelle@linux.ibm.com, farman@linux.ibm.com,
pmorel@linux.ibm.com, borntraeger@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, frankja@linux.ibm.com, david@redhat.com,
imbrenda@linux.ibm.com, vneethv@linux.ibm.com,
oberpar@linux.ibm.com, freude@linux.ibm.com, thuth@redhat.com,
pasic@linux.ibm.com, pbonzini@redhat.com, corbet@lwn.net,
jgg@nvidia.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 10/21] KVM: s390: pci: add basic kvm_zdev structure
Date: Wed, 27 Apr 2022 09:25:59 -0400 [thread overview]
Message-ID: <6a4db1a9-70c4-3ed1-b055-c5161d021d3d@linux.ibm.com> (raw)
In-Reply-To: <202204271653.1ZoYsV9W-lkp@intel.com>
On 4/27/22 4:41 AM, kernel test robot wrote:
> Hi Matthew,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on v5.18-rc4]
> [cannot apply to s390/features kvms390/next awilliam-vfio/next next-20220427]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20220427-041853
> base: af2d861d4cd2a4da5137f795ee3509e6f944a25b
> config: s390-defconfig (https://download.01.org/0day-ci/archive/20220427/202204271653.1ZoYsV9W-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/e6d8c620090a7b184afdf5b5123d10ac45776eaf
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20220427-041853
> git checkout e6d8c620090a7b184afdf5b5123d10ac45776eaf
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/kvm/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> arch/s390/kvm/pci.c:14:5: warning: no previous prototype for 'kvm_s390_pci_dev_open' [-Wmissing-prototypes]
> 14 | int kvm_s390_pci_dev_open(struct zpci_dev *zdev)
> | ^~~~~~~~~~~~~~~~~~~~~
>>> arch/s390/kvm/pci.c:29:6: warning: no previous prototype for 'kvm_s390_pci_dev_release' [-Wmissing-prototypes]
> 29 | void kvm_s390_pci_dev_release(struct zpci_dev *zdev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
Oops, these 2 functions no longer need to be externalized and can simply
be marked static.
>
> vim +/kvm_s390_pci_dev_open +14 arch/s390/kvm/pci.c
>
> 13
> > 14 int kvm_s390_pci_dev_open(struct zpci_dev *zdev)
> 15 {
> 16 struct kvm_zdev *kzdev;
> 17
> 18 kzdev = kzalloc(sizeof(struct kvm_zdev), GFP_KERNEL);
> 19 if (!kzdev)
> 20 return -ENOMEM;
> 21
> 22 kzdev->zdev = zdev;
> 23 zdev->kzdev = kzdev;
> 24
> 25 return 0;
> 26 }
> 27 EXPORT_SYMBOL_GPL(kvm_s390_pci_dev_open);
> 28
> > 29 void kvm_s390_pci_dev_release(struct zpci_dev *zdev)
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Rosato <mjrosato@linux.ibm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 10/21] KVM: s390: pci: add basic kvm_zdev structure
Date: Wed, 27 Apr 2022 09:25:59 -0400 [thread overview]
Message-ID: <6a4db1a9-70c4-3ed1-b055-c5161d021d3d@linux.ibm.com> (raw)
In-Reply-To: <202204271653.1ZoYsV9W-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2868 bytes --]
On 4/27/22 4:41 AM, kernel test robot wrote:
> Hi Matthew,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on v5.18-rc4]
> [cannot apply to s390/features kvms390/next awilliam-vfio/next next-20220427]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20220427-041853
> base: af2d861d4cd2a4da5137f795ee3509e6f944a25b
> config: s390-defconfig (https://download.01.org/0day-ci/archive/20220427/202204271653.1ZoYsV9W-lkp(a)intel.com/config)
> compiler: s390-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/e6d8c620090a7b184afdf5b5123d10ac45776eaf
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20220427-041853
> git checkout e6d8c620090a7b184afdf5b5123d10ac45776eaf
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/kvm/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> arch/s390/kvm/pci.c:14:5: warning: no previous prototype for 'kvm_s390_pci_dev_open' [-Wmissing-prototypes]
> 14 | int kvm_s390_pci_dev_open(struct zpci_dev *zdev)
> | ^~~~~~~~~~~~~~~~~~~~~
>>> arch/s390/kvm/pci.c:29:6: warning: no previous prototype for 'kvm_s390_pci_dev_release' [-Wmissing-prototypes]
> 29 | void kvm_s390_pci_dev_release(struct zpci_dev *zdev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
Oops, these 2 functions no longer need to be externalized and can simply
be marked static.
>
> vim +/kvm_s390_pci_dev_open +14 arch/s390/kvm/pci.c
>
> 13
> > 14 int kvm_s390_pci_dev_open(struct zpci_dev *zdev)
> 15 {
> 16 struct kvm_zdev *kzdev;
> 17
> 18 kzdev = kzalloc(sizeof(struct kvm_zdev), GFP_KERNEL);
> 19 if (!kzdev)
> 20 return -ENOMEM;
> 21
> 22 kzdev->zdev = zdev;
> 23 zdev->kzdev = kzdev;
> 24
> 25 return 0;
> 26 }
> 27 EXPORT_SYMBOL_GPL(kvm_s390_pci_dev_open);
> 28
> > 29 void kvm_s390_pci_dev_release(struct zpci_dev *zdev)
>
next prev parent reply other threads:[~2022-04-27 13:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 20:08 [PATCH v6 00/21] KVM: s390: enable zPCI for interpretive execution Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 01/21] s390/sclp: detect the zPCI load/store interpretation facility Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 02/21] s390/sclp: detect the AISII facility Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 03/21] s390/sclp: detect the AENI facility Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 04/21] s390/sclp: detect the AISI facility Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 05/21] s390/airq: pass more TPI info to airq handlers Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 06/21] s390/airq: allow for airq structure that uses an input vector Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 07/21] s390/pci: externalize the SIC operation controls and routine Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 08/21] s390/pci: stash associated GISA designation Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 09/21] s390/pci: stash dtsm and maxstbl Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 10/21] KVM: s390: pci: add basic kvm_zdev structure Matthew Rosato
2022-04-27 8:41 ` kernel test robot
2022-04-27 13:25 ` Matthew Rosato [this message]
2022-04-27 13:25 ` Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 11/21] KVM: s390: pci: do initial setup for AEN interpretation Matthew Rosato
2022-05-05 10:16 ` Christian Borntraeger
2022-04-26 20:08 ` [PATCH v6 12/21] KVM: s390: pci: enable host forwarding of Adapter Event Notifications Matthew Rosato
2022-05-05 12:37 ` Christian Borntraeger
2022-04-26 20:08 ` [PATCH v6 13/21] KVM: s390: mechanism to enable guest zPCI Interpretation Matthew Rosato
2022-05-05 13:10 ` Christian Borntraeger
2022-04-26 20:08 ` [PATCH v6 14/21] KVM: s390: pci: provide routines for enabling/disabling interrupt forwarding Matthew Rosato
2022-05-06 15:35 ` Christian Borntraeger
2022-05-06 15:55 ` Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 15/21] KVM: s390: pci: add routines to start/stop interpretive execution Matthew Rosato
2022-04-27 15:14 ` Jason Gunthorpe
2022-04-27 20:20 ` Matthew Rosato
2022-04-28 12:28 ` Jason Gunthorpe
2022-04-26 20:08 ` [PATCH v6 16/21] vfio-pci/zdev: add open/close device hooks Matthew Rosato
2022-04-27 14:04 ` Jason Gunthorpe
2022-04-27 14:42 ` Matthew Rosato
2022-04-27 15:01 ` Jason Gunthorpe
2022-04-27 15:26 ` Matthew Rosato
2022-04-27 15:39 ` Jason Gunthorpe
2022-05-06 15:56 ` Christian Borntraeger
2022-04-26 20:08 ` [PATCH v6 17/21] vfio-pci/zdev: add function handle to clp base capability Matthew Rosato
2022-05-06 16:02 ` Christian Borntraeger
2022-04-26 20:08 ` [PATCH v6 18/21] vfio-pci/zdev: different maxstbl for interpreted devices Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 19/21] KVM: s390: add KVM_S390_ZPCI_OP to manage guest zPCI devices Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 20/21] KVM: s390: introduce CPU feature for zPCI Interpretation Matthew Rosato
2022-04-26 20:08 ` [PATCH v6 21/21] MAINTAINERS: additional files related kvm s390 pci passthrough Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4db1a9-70c4-3ed1-b055-c5161d021d3d@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.