All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<robh+dt@kernel.org>, <lgirdwood@gmail.com>,
	<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
	<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
	<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
	<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
	<swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
Date: Sat, 29 Aug 2020 16:22:09 +0530	[thread overview]
Message-ID: <6c2bb431-c7d5-53b7-2f62-c1487e321680@nvidia.com> (raw)
In-Reply-To: <87eentvwab.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

Sorry for the delayed reply as I was on sick leave.
>> Sure. BTW, there are more such candidates which require 'lock' version
>> of these helpers.
>> For example: soc_find_component(), snd_soc_add/remove_pcm_runtime()
>> and snd_soc_register_dai().
> soc_find_component() is static function, no need to care about mutex.
> other functions are indeed exported function, but is used from
> topology.c which is calling it under mutex.
>
>
I was just thinking if we need to future proof these functions. As you 
mentioned, currently these have limited usage (in topology.c) and should 
just be fine to address snd_soc_find_dai() for now.

Thanks,
Sameer.


WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: jonathanh@nvidia.com, nicoleotsuka@gmail.com,
	alsa-devel@alsa-project.org, atalambedu@nvidia.com,
	swarren@nvidia.com, linux-kernel@vger.kernel.org,
	nwartikar@nvidia.com, lgirdwood@gmail.com, robh+dt@kernel.org,
	tiwai@suse.com, viswanathl@nvidia.com, sharadg@nvidia.com,
	broonie@kernel.org, thierry.reding@gmail.com,
	linux-tegra@vger.kernel.org, rlokhande@nvidia.com,
	mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
Date: Sat, 29 Aug 2020 16:22:09 +0530	[thread overview]
Message-ID: <6c2bb431-c7d5-53b7-2f62-c1487e321680@nvidia.com> (raw)
In-Reply-To: <87eentvwab.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

Sorry for the delayed reply as I was on sick leave.
>> Sure. BTW, there are more such candidates which require 'lock' version
>> of these helpers.
>> For example: soc_find_component(), snd_soc_add/remove_pcm_runtime()
>> and snd_soc_register_dai().
> soc_find_component() is static function, no need to care about mutex.
> other functions are indeed exported function, but is used from
> topology.c which is calling it under mutex.
>
>
I was just thinking if we need to future proof these functions. As you 
mentioned, currently these have limited usage (in topology.c) and should 
just be fine to address snd_soc_find_dai() for now.

Thanks,
Sameer.


  reply	other threads:[~2020-08-29 10:53 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  5:24 [PATCH v2 0/9] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-08-05  5:24 ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 1/9] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 2/9] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-18  2:39   ` Kuninori Morimoto
2020-08-18  2:39     ` Kuninori Morimoto
2020-08-05  5:24 ` [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-18  2:41   ` Kuninori Morimoto
2020-08-18  2:41     ` Kuninori Morimoto
2020-08-18  8:06     ` Sameer Pujar
2020-08-18  8:06       ` Sameer Pujar
2020-08-18  5:23   ` Kuninori Morimoto
2020-08-18  5:23     ` Kuninori Morimoto
2020-08-18  8:04     ` Sameer Pujar
2020-08-18  8:04       ` Sameer Pujar
2020-08-25  3:25       ` Sameer Pujar
2020-08-25  4:54         ` Kuninori Morimoto
2020-08-25  4:54           ` Kuninori Morimoto
2020-08-25  5:15           ` Sameer Pujar
2020-08-25  5:15             ` Sameer Pujar
2020-08-25  5:40             ` Kuninori Morimoto
2020-08-25  5:40               ` Kuninori Morimoto
2020-08-25  5:53               ` Sameer Pujar
2020-08-25  5:53                 ` Sameer Pujar
2020-08-25  6:46                 ` Kuninori Morimoto
2020-08-25  6:46                   ` Kuninori Morimoto
2020-08-25  7:18                   ` Sameer Pujar
2020-08-25  7:18                     ` Sameer Pujar
2020-08-26 23:12                     ` Kuninori Morimoto
2020-08-26 23:12                       ` Kuninori Morimoto
2020-08-29 10:52                       ` Sameer Pujar [this message]
2020-08-29 10:52                         ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 4/9] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 5/9] ASoC: dt-bindings: audio-graph-card: Support for component chaining Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 6/9] ASoC: audio-graph: Add support " Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 7/9] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 8/9] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-05  5:24 ` [PATCH v2 9/9] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-08-05  5:24   ` Sameer Pujar
2020-08-17  1:53 ` [PATCH v2 0/9] Audio graph card updates and usage with Tegra210 audio Kuninori Morimoto
2020-08-17  1:53   ` Kuninori Morimoto
2020-08-20  9:02   ` Sameer Pujar
2020-08-20  9:02     ` Sameer Pujar
2020-08-20 23:00     ` Kuninori Morimoto
2020-08-20 23:00       ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c2bb431-c7d5-53b7-2f62-c1487e321680@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=atalambedu@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=dramesh@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=nwartikar@nvidia.com \
    --cc=perex@perex.cz \
    --cc=rlokhande@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=swarren@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=viswanathl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.