From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Sameer Pujar <spujar@nvidia.com>
Cc: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<robh+dt@kernel.org>, <lgirdwood@gmail.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
<swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
Date: 25 Aug 2020 15:46:00 +0900 [thread overview]
Message-ID: <87lfi3w7hj.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <e9698ac3-0a2e-08a2-3f78-b0be0069d6ee@nvidia.com>
Hi Sameer
> > Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex().
> > I'm not sure which style is best.
>
> I don't know how complex it is to have a unified solution. But if we
> can protect snd_soc_find_dai() itself, things would be simpler may be
> in long term. Right now there are separate source files for soc-core,
> soc-dai and soc-component, but because of two approaches looks like
> the function need to be moved around and need to be placed in
> soc-core. Also the issue might go unnoticed if LOCKDEP is not enabled.
>
> May be start with a wrapper for now and eventually unify?
Yeah, it seems has _with_mutex() can be better idea.
I'm posting patch, but I noticed that Mark's branch vs Linus branch
have some mismatch (?), and now I'm asking it to him.
I can post _with_mutex() version as v2 if I could get answer.
After that I'm happy your next patch can re-use it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Sameer Pujar <spujar@nvidia.com>
Cc: jonathanh@nvidia.com, nicoleotsuka@gmail.com,
alsa-devel@alsa-project.org, atalambedu@nvidia.com,
swarren@nvidia.com, linux-kernel@vger.kernel.org,
nwartikar@nvidia.com, lgirdwood@gmail.com, robh+dt@kernel.org,
tiwai@suse.com, viswanathl@nvidia.com, sharadg@nvidia.com,
broonie@kernel.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org, rlokhande@nvidia.com,
mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM
Date: 25 Aug 2020 15:46:00 +0900 [thread overview]
Message-ID: <87lfi3w7hj.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <e9698ac3-0a2e-08a2-3f78-b0be0069d6ee@nvidia.com>
Hi Sameer
> > Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex().
> > I'm not sure which style is best.
>
> I don't know how complex it is to have a unified solution. But if we
> can protect snd_soc_find_dai() itself, things would be simpler may be
> in long term. Right now there are separate source files for soc-core,
> soc-dai and soc-component, but because of two approaches looks like
> the function need to be moved around and need to be placed in
> soc-core. Also the issue might go unnoticed if LOCKDEP is not enabled.
>
> May be start with a wrapper for now and eventually unify?
Yeah, it seems has _with_mutex() can be better idea.
I'm posting patch, but I noticed that Mark's branch vs Linus branch
have some mismatch (?), and now I'm asking it to him.
I can post _with_mutex() version as v2 if I could get answer.
After that I'm happy your next patch can re-use it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2020-08-25 6:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 5:24 [PATCH v2 0/9] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 1/9] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 2/9] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-18 2:39 ` Kuninori Morimoto
2020-08-18 2:39 ` Kuninori Morimoto
2020-08-05 5:24 ` [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-18 2:41 ` Kuninori Morimoto
2020-08-18 2:41 ` Kuninori Morimoto
2020-08-18 8:06 ` Sameer Pujar
2020-08-18 8:06 ` Sameer Pujar
2020-08-18 5:23 ` Kuninori Morimoto
2020-08-18 5:23 ` Kuninori Morimoto
2020-08-18 8:04 ` Sameer Pujar
2020-08-18 8:04 ` Sameer Pujar
2020-08-25 3:25 ` Sameer Pujar
2020-08-25 4:54 ` Kuninori Morimoto
2020-08-25 4:54 ` Kuninori Morimoto
2020-08-25 5:15 ` Sameer Pujar
2020-08-25 5:15 ` Sameer Pujar
2020-08-25 5:40 ` Kuninori Morimoto
2020-08-25 5:40 ` Kuninori Morimoto
2020-08-25 5:53 ` Sameer Pujar
2020-08-25 5:53 ` Sameer Pujar
2020-08-25 6:46 ` Kuninori Morimoto [this message]
2020-08-25 6:46 ` Kuninori Morimoto
2020-08-25 7:18 ` Sameer Pujar
2020-08-25 7:18 ` Sameer Pujar
2020-08-26 23:12 ` Kuninori Morimoto
2020-08-26 23:12 ` Kuninori Morimoto
2020-08-29 10:52 ` Sameer Pujar
2020-08-29 10:52 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 4/9] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 5/9] ASoC: dt-bindings: audio-graph-card: Support for component chaining Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 6/9] ASoC: audio-graph: Add support " Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 7/9] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 8/9] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-05 5:24 ` [PATCH v2 9/9] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-08-05 5:24 ` Sameer Pujar
2020-08-17 1:53 ` [PATCH v2 0/9] Audio graph card updates and usage with Tegra210 audio Kuninori Morimoto
2020-08-17 1:53 ` Kuninori Morimoto
2020-08-20 9:02 ` Sameer Pujar
2020-08-20 9:02 ` Sameer Pujar
2020-08-20 23:00 ` Kuninori Morimoto
2020-08-20 23:00 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfi3w7hj.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.