From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: dillon.minfei@gmail.com, mchehab@kernel.org,
mchehab+huawei@kernel.org, ezequiel@collabora.com,
gnurou@gmail.com, pihsun@chromium.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org
Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 7/9] media: docs: add doc for the stm32 dma2d driver
Date: Mon, 9 Aug 2021 11:15:59 +0200 [thread overview]
Message-ID: <7131ee03-fc81-cb9b-665f-80e4ce8435ab@xs4all.nl> (raw)
In-Reply-To: <1626341068-20253-18-git-send-email-dillon.minfei@gmail.com>
On 15/07/2021 11:24, dillon.minfei@gmail.com wrote:
> From: Dillon Min <dillon.minfei@gmail.com>
>
> add stm32-uapi.rst for stm32's dma2d driver, explain the details of ioctl
> V4L2_CID_DMA2D_R2M_MODE, V4L2_CID_DMA2D_R2M_COLOR.
>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> ---
> v2: introduce the stm32-uapi.rst to explain the detail of dma2d's ioctl.
>
> .../userspace-api/media/drivers/index.rst | 1 +
> .../userspace-api/media/drivers/stm32-uapi.rst | 22 ++++++++++++++++++++++
> 2 files changed, 23 insertions(+)
> create mode 100644 Documentation/userspace-api/media/drivers/stm32-uapi.rst
>
> diff --git a/Documentation/userspace-api/media/drivers/index.rst b/Documentation/userspace-api/media/drivers/index.rst
> index 12e3c512d718..ce42915d48f4 100644
> --- a/Documentation/userspace-api/media/drivers/index.rst
> +++ b/Documentation/userspace-api/media/drivers/index.rst
> @@ -38,4 +38,5 @@ For more details see the file COPYING in the source distribution of Linux.
> max2175
> meye-uapi
> omap3isp-uapi
> + stm32-uapi
> uvcvideo
> diff --git a/Documentation/userspace-api/media/drivers/stm32-uapi.rst b/Documentation/userspace-api/media/drivers/stm32-uapi.rst
> new file mode 100644
> index 000000000000..d7a4f717387d
> --- /dev/null
> +++ b/Documentation/userspace-api/media/drivers/stm32-uapi.rst
> @@ -0,0 +1,22 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +STM32 Chrom-Art 2D Graphics Accelerator unit (DMA2D) driver
> +================================================
> +
> +The DMA2D driver implements the following driver-specific controls:
> +
> +``V4L2_CID_DMA2D_R2M_MODE``
Please mention the control type as well.
> +-------------------------
> + Enable/Disable the Register-To-Memory mode, filling a part or the
> + whole of a destination image with a specific color.
> +
> + 1 for enable, 0 for disable.
> +
> +``V4L2_CID_DMA2D_R2M_COLOR``
Ditto.
> +-------------------------------
> + Set the color to fill a part or the whole of a destination image.
> + only used under Register-To-Memory mode, to set the DMA2D_OCOLR register
> + (RED, GREEN, BLUE) which is:
Here you mention RGB only,
> +
> + 31 .. 24 23 .. 16 15 .. 8 7 .. 0
> + ALPHA[7:0] RED[7:0] GREEN[7:0] BLUE[7:0]
but here you also mention Alpha. So which is it?
See also my review of patch 9/9.
>
I'm getting some warnings building this doc:
Documentation/media/userspace-api/drivers/stm32-uapi.rst:4: WARNING: Title underline too short.
STM32 Chrom-Art 2D Graphics Accelerator unit (DMA2D) driver
================================================
Documentation/media/userspace-api/drivers/stm32-uapi.rst:9: WARNING: Title underline too short.
``V4L2_CID_DMA2D_R2M_MODE``
-------------------------
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: dillon.minfei@gmail.com, mchehab@kernel.org,
mchehab+huawei@kernel.org, ezequiel@collabora.com,
gnurou@gmail.com, pihsun@chromium.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org
Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 7/9] media: docs: add doc for the stm32 dma2d driver
Date: Mon, 9 Aug 2021 11:15:59 +0200 [thread overview]
Message-ID: <7131ee03-fc81-cb9b-665f-80e4ce8435ab@xs4all.nl> (raw)
In-Reply-To: <1626341068-20253-18-git-send-email-dillon.minfei@gmail.com>
On 15/07/2021 11:24, dillon.minfei@gmail.com wrote:
> From: Dillon Min <dillon.minfei@gmail.com>
>
> add stm32-uapi.rst for stm32's dma2d driver, explain the details of ioctl
> V4L2_CID_DMA2D_R2M_MODE, V4L2_CID_DMA2D_R2M_COLOR.
>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
> ---
> v2: introduce the stm32-uapi.rst to explain the detail of dma2d's ioctl.
>
> .../userspace-api/media/drivers/index.rst | 1 +
> .../userspace-api/media/drivers/stm32-uapi.rst | 22 ++++++++++++++++++++++
> 2 files changed, 23 insertions(+)
> create mode 100644 Documentation/userspace-api/media/drivers/stm32-uapi.rst
>
> diff --git a/Documentation/userspace-api/media/drivers/index.rst b/Documentation/userspace-api/media/drivers/index.rst
> index 12e3c512d718..ce42915d48f4 100644
> --- a/Documentation/userspace-api/media/drivers/index.rst
> +++ b/Documentation/userspace-api/media/drivers/index.rst
> @@ -38,4 +38,5 @@ For more details see the file COPYING in the source distribution of Linux.
> max2175
> meye-uapi
> omap3isp-uapi
> + stm32-uapi
> uvcvideo
> diff --git a/Documentation/userspace-api/media/drivers/stm32-uapi.rst b/Documentation/userspace-api/media/drivers/stm32-uapi.rst
> new file mode 100644
> index 000000000000..d7a4f717387d
> --- /dev/null
> +++ b/Documentation/userspace-api/media/drivers/stm32-uapi.rst
> @@ -0,0 +1,22 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +STM32 Chrom-Art 2D Graphics Accelerator unit (DMA2D) driver
> +================================================
> +
> +The DMA2D driver implements the following driver-specific controls:
> +
> +``V4L2_CID_DMA2D_R2M_MODE``
Please mention the control type as well.
> +-------------------------
> + Enable/Disable the Register-To-Memory mode, filling a part or the
> + whole of a destination image with a specific color.
> +
> + 1 for enable, 0 for disable.
> +
> +``V4L2_CID_DMA2D_R2M_COLOR``
Ditto.
> +-------------------------------
> + Set the color to fill a part or the whole of a destination image.
> + only used under Register-To-Memory mode, to set the DMA2D_OCOLR register
> + (RED, GREEN, BLUE) which is:
Here you mention RGB only,
> +
> + 31 .. 24 23 .. 16 15 .. 8 7 .. 0
> + ALPHA[7:0] RED[7:0] GREEN[7:0] BLUE[7:0]
but here you also mention Alpha. So which is it?
See also my review of patch 9/9.
>
I'm getting some warnings building this doc:
Documentation/media/userspace-api/drivers/stm32-uapi.rst:4: WARNING: Title underline too short.
STM32 Chrom-Art 2D Graphics Accelerator unit (DMA2D) driver
================================================
Documentation/media/userspace-api/drivers/stm32-uapi.rst:9: WARNING: Title underline too short.
``V4L2_CID_DMA2D_R2M_MODE``
-------------------------
Regards,
Hans
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-09 9:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 9:24 [PATCH v2 0/9] Add support for DMA2D of STMicroelectronics STM32 Soc series dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 1/9] media: admin-guide: add stm32-dma2d description dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 2/9] media: dt-bindings: media: add document for STM32 DMA2d bindings dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 3/9] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 4/9] ARM: dts: stm32: Enable DMA2D support on STM32F429 MCU dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 5/9] ARM: dts: stm32: Enable DMA2D on STM32F469-DISCO board dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 6/9] media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 7/9] media: docs: add doc for the stm32 dma2d driver dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 8/9] media: v4l: uapi: Add user control base for stm32 dma2d controls dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 9/9] media: stm32-dma2d: STM32 DMA2D driver dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 0/9] Add support for DMA2D of STMicroelectronics STM32 Soc series dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 1/9] media: admin-guide: add stm32-dma2d description dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 2/9] media: dt-bindings: media: add document for STM32 DMA2d bindings dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 3/9] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 4/9] ARM: dts: stm32: Enable DMA2D support on STM32F429 MCU dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 5/9] ARM: dts: stm32: Enable DMA2D on STM32F469-DISCO board dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 6/9] media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 7/9] media: docs: add doc for the stm32 dma2d driver dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-08-09 9:15 ` Hans Verkuil [this message]
2021-08-09 9:15 ` Hans Verkuil
2021-08-10 8:52 ` Dillon Min
2021-08-10 8:52 ` Dillon Min
2021-07-15 9:24 ` [PATCH v2 8/9] media: v4l: uapi: Add user control base for stm32 dma2d controls dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-07-15 9:24 ` [PATCH v2 9/9] media: stm32-dma2d: STM32 DMA2D driver dillon.minfei
2021-07-15 9:24 ` dillon.minfei
2021-08-09 9:09 ` Hans Verkuil
2021-08-09 9:09 ` Hans Verkuil
2021-08-10 8:51 ` Dillon Min
2021-08-10 8:51 ` Dillon Min
2021-08-05 8:59 ` [PATCH v2 0/9] Add support for DMA2D of STMicroelectronics STM32 Soc series Dillon Min
2021-08-05 8:59 ` Dillon Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7131ee03-fc81-cb9b-665f-80e4ce8435ab@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gnurou@gmail.com \
--cc=hugues.fruchet@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=patrice.chotard@foss.st.com \
--cc=pihsun@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.