From: Michael Walle <michael@walle.cc> To: Vladimir Oltean <vladimir.oltean@nxp.com> Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Lee Jones <lee.jones@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Claudiu Manoil <claudiu.manoil@nxp.com>, Leo Li <leoyang.li@nxp.com>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld Date: Fri, 11 Feb 2022 14:29:16 +0100 [thread overview] Message-ID: <7444c54c0214552f1a565a8bd0c48850@walle.cc> (raw) In-Reply-To: <20220211132410.3qldvlpznlrxsgzg@skbuf> Am 2022-02-11 14:24, schrieb Vladimir Oltean: > On Fri, Feb 11, 2022 at 07:01:42AM -0600, Rob Herring wrote: >> On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote: >> > The LS1028A-QDS QIXIS FPGA has no problem working with the >> > simple-mfd-i2c.c driver, so extend the list of compatible strings to >> > include that part. >> > >> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> >> > --- >> > Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > index eb3b43547cb6..8c1216eb36ee 100644 >> > --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > @@ -16,7 +16,9 @@ description: | >> > >> > properties: >> > compatible: >> > - const: kontron,sl28cpld >> > + enum: >> > + - fsl,ls1028a-qds-qixis-i2c >> > + - kontron,sl28cpld >> >> Is there some relationship between these besides happening to use the >> same driver? Sharing a generic driver is not a reason to have the same >> binding doc. Ahh didn't notice this. Yes that should probably go into an own binding. >> Your DT has a mux-controller which is undocuemnted in this binding. >> >> Rob > > I'd guess they are both programmable FPGA's/CPLD's that are used for > board control. What I don't know is whether the sources for the Kontron > bit stream are derived in any way from the QIXIS. I can 100% guarantee that is not the case ;) > I can look into adding a separate binding doc for the QIXIS anyway. -michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc> To: Vladimir Oltean <vladimir.oltean@nxp.com> Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Lee Jones <lee.jones@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Claudiu Manoil <claudiu.manoil@nxp.com>, Leo Li <leoyang.li@nxp.com>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld Date: Fri, 11 Feb 2022 14:29:16 +0100 [thread overview] Message-ID: <7444c54c0214552f1a565a8bd0c48850@walle.cc> (raw) In-Reply-To: <20220211132410.3qldvlpznlrxsgzg@skbuf> Am 2022-02-11 14:24, schrieb Vladimir Oltean: > On Fri, Feb 11, 2022 at 07:01:42AM -0600, Rob Herring wrote: >> On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote: >> > The LS1028A-QDS QIXIS FPGA has no problem working with the >> > simple-mfd-i2c.c driver, so extend the list of compatible strings to >> > include that part. >> > >> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> >> > --- >> > Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > index eb3b43547cb6..8c1216eb36ee 100644 >> > --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > @@ -16,7 +16,9 @@ description: | >> > >> > properties: >> > compatible: >> > - const: kontron,sl28cpld >> > + enum: >> > + - fsl,ls1028a-qds-qixis-i2c >> > + - kontron,sl28cpld >> >> Is there some relationship between these besides happening to use the >> same driver? Sharing a generic driver is not a reason to have the same >> binding doc. Ahh didn't notice this. Yes that should probably go into an own binding. >> Your DT has a mux-controller which is undocuemnted in this binding. >> >> Rob > > I'd guess they are both programmable FPGA's/CPLD's that are used for > board control. What I don't know is whether the sources for the Kontron > bit stream are derived in any way from the QIXIS. I can 100% guarantee that is not the case ;) > I can look into adding a separate binding doc for the QIXIS anyway. -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-11 13:29 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-27 17:21 [PATCH 0/3] Use sl28cpld driver for the LS1028A-QDS QIXIS FPGA Vladimir Oltean 2022-01-27 17:21 ` Vladimir Oltean 2022-01-27 17:21 ` [PATCH 1/3] mfd: simple-mfd-i2c: add compatible string for LS1028A-QDS FPGA Vladimir Oltean 2022-01-27 17:21 ` Vladimir Oltean 2022-01-28 8:44 ` Lee Jones 2022-01-28 8:44 ` Lee Jones 2022-01-27 17:21 ` [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld Vladimir Oltean 2022-01-27 17:21 ` [PATCH 2/3] dt-bindings: mfd: add "fsl, ls1028a-qds-qixis-i2c" " Vladimir Oltean 2022-02-11 13:01 ` [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" " Rob Herring 2022-02-11 13:01 ` Rob Herring 2022-02-11 13:24 ` Vladimir Oltean 2022-02-11 13:24 ` Vladimir Oltean 2022-02-11 13:29 ` Michael Walle [this message] 2022-02-11 13:29 ` Michael Walle 2022-01-27 17:21 ` [PATCH 3/3] arm64: dts: ls1028a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c driver Vladimir Oltean 2022-01-27 17:21 ` Vladimir Oltean
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7444c54c0214552f1a565a8bd0c48850@walle.cc \ --to=michael@walle.cc \ --cc=andrew@lunn.ch \ --cc=claudiu.manoil@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=lee.jones@linaro.org \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=robh@kernel.org \ --cc=shawnguo@kernel.org \ --cc=vladimir.oltean@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.