Re: [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld

From: Rob Herring <robh@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Lee Jones <lee.jones@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Li Yang <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: add "fsl,ls1028a-qds-qixis-i2c" compatible to sl28cpld
Date: Fri, 11 Feb 2022 07:01:42 -0600	[thread overview]
Message-ID: <YgZeNqAbdisyeT+s@robh.at.kernel.org> (raw)
In-Reply-To: <20220127172105.4085950-3-vladimir.oltean@nxp.com>

On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote:
> The LS1028A-QDS QIXIS FPGA has no problem working with the
> simple-mfd-i2c.c driver, so extend the list of compatible strings to
> include that part.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
> index eb3b43547cb6..8c1216eb36ee 100644
> --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
> +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
> @@ -16,7 +16,9 @@ description: |
>  
>  properties:
>    compatible:
> -    const: kontron,sl28cpld
> +    enum:
> +      - fsl,ls1028a-qds-qixis-i2c
> +      - kontron,sl28cpld

Is there some relationship between these besides happening to use the 
same driver? Sharing a generic driver is not a reason to have the same 
binding doc.

Your DT has a mux-controller which is undocuemnted in this binding.

Rob