All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Russell King <linux@arm.linux.org.uk>, Greg KH <greg@kroah.com>,
	"ming.lei@canonical.com" <ming.lei@canonical.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Will Deacon <Will.Deacon@arm.com>, Marc Dietich <marvin24@gmx.de>,
	"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
	Mark Salter <msalter@redhat.com>,
	Chen Peter-B29397 <B29397@freescale.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] usb: ehci: make HC see up-to-date qh/qtd descriptor ASAP
Date: Fri, 2 Sep 2011 10:07:11 -0700	[thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04B327A5C1@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <4E60A702.1060504@arm.com>

Marc Zyngier wrote at Friday, September 02, 2011 3:51 AM:
> On 01/09/11 20:08, Stephen Warren wrote:
> > Marc Dietich wrote at Thursday, September 01, 2011 5:14 AM:
> >> I'll add Stephen Warren from NVIDIA to the CC list. He has more HW to test on.
> >
> > Here are the results I found:
> >
> > Harmony:
> > Tegra USB3 -> SMSC9514 hub: NOT affected
> > (Unplugging LAN cable, or disabling SMSC9514 LAN driver doesn't change this)
...
> I just noticed something else. Harmony is fast *most of the time*. In
> about one in 3 reboots, I get the slow behavior. When USB is fast, I
> also have I2C interrupts "screaming":
> 
>  85:     294321          0       GIC  tegra-i2c
> 116:          0          0       GIC  tegra-i2c
> 118:      98542          0       GIC  tps6586x
> 
> This is a couple of seconds after boot.
> 
> When USB is slow, I see the following:
> [    0.385270] tps6586x 3-0034: Chip ID read failed: -121
> [    0.390584] tps6586x: probe of 3-0034 failed with error -5
> 
> ... and I2C interrupt is quiet.
> 
> The I2C interrupt handler calls writel(), which does a cache sync. That
> would explain the "fast" behavior of Harmony.
> 
> Do you see the same this on your board?

Yes, I re-ran the test a few more times and see those exact same symptoms.

In a case with the screaming I2C interrupts and fast USB, I then did:

echo 3-0034 > /sys/bus/i2c/drivers/tps6586x/unbind
(I got a kernel BUG and bash crashed here, but just logged back in)

which caused the I2C interrupt handler to stop, then re-ran the test.
I then saw the slow USB speed.

So, now I think *all* platforms(boards) are affected, right?

-- 
nvpublic

WARNING: multiple messages have this Message-ID (diff)
From: swarren@nvidia.com (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: ehci: make HC see up-to-date qh/qtd descriptor ASAP
Date: Fri, 2 Sep 2011 10:07:11 -0700	[thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04B327A5C1@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <4E60A702.1060504@arm.com>

Marc Zyngier wrote at Friday, September 02, 2011 3:51 AM:
> On 01/09/11 20:08, Stephen Warren wrote:
> > Marc Dietich wrote at Thursday, September 01, 2011 5:14 AM:
> >> I'll add Stephen Warren from NVIDIA to the CC list. He has more HW to test on.
> >
> > Here are the results I found:
> >
> > Harmony:
> > Tegra USB3 -> SMSC9514 hub: NOT affected
> > (Unplugging LAN cable, or disabling SMSC9514 LAN driver doesn't change this)
...
> I just noticed something else. Harmony is fast *most of the time*. In
> about one in 3 reboots, I get the slow behavior. When USB is fast, I
> also have I2C interrupts "screaming":
> 
>  85:     294321          0       GIC  tegra-i2c
> 116:          0          0       GIC  tegra-i2c
> 118:      98542          0       GIC  tps6586x
> 
> This is a couple of seconds after boot.
> 
> When USB is slow, I see the following:
> [    0.385270] tps6586x 3-0034: Chip ID read failed: -121
> [    0.390584] tps6586x: probe of 3-0034 failed with error -5
> 
> ... and I2C interrupt is quiet.
> 
> The I2C interrupt handler calls writel(), which does a cache sync. That
> would explain the "fast" behavior of Harmony.
> 
> Do you see the same this on your board?

Yes, I re-ran the test a few more times and see those exact same symptoms.

In a case with the screaming I2C interrupts and fast USB, I then did:

echo 3-0034 > /sys/bus/i2c/drivers/tps6586x/unbind
(I got a kernel BUG and bash crashed here, but just logged back in)

which caused the I2C interrupt handler to stop, then re-ran the test.
I then saw the slow USB speed.

So, now I think *all* platforms(boards) are affected, right?

-- 
nvpublic

  reply	other threads:[~2011-09-02 17:07 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 16:03 [PATCH] usb: ehci: make HC see up-to-date qh/qtd descriptor ASAP ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw
2011-08-30 16:03 ` ming.lei at canonical.com
2011-08-30 16:15 ` Alan Stern
2011-08-30 16:15   ` Alan Stern
2011-08-30 16:38 ` Mark Salter
2011-08-30 16:38   ` Mark Salter
2011-08-30 17:15   ` Alan Stern
2011-08-30 17:15     ` Alan Stern
2011-08-30 18:45     ` Mark Salter
2011-08-30 18:45       ` Mark Salter
2011-08-30 17:26   ` Will Deacon
2011-08-30 17:26     ` Will Deacon
     [not found]     ` <20110830172642.GE3464-SGELLbQ0bobZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2011-08-30 17:48       ` Greg KH
2011-08-30 17:48         ` Greg KH
2011-08-30 17:54         ` Will Deacon
2011-08-30 17:54           ` Will Deacon
     [not found]           ` <20110830175432.GG3464-SGELLbQ0bobZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2011-08-31  0:23             ` Chen Peter-B29397
2011-08-31  0:23               ` Chen Peter-B29397
2011-08-31  8:49               ` Will Deacon
2011-08-31  8:49                 ` Will Deacon
2011-08-31 12:33                 ` Chen Peter-B29397
2011-08-31 12:33                   ` Chen Peter-B29397
2011-08-31 13:43                 ` Mark Salter
2011-08-31 13:43                   ` Mark Salter
2011-08-31 15:21                   ` Will Deacon
2011-08-31 15:21                     ` Will Deacon
2011-08-31 15:27                     ` Mark Salter
2011-08-31 15:27                       ` Mark Salter
2011-08-31 16:12                       ` Marc Zyngier
2011-08-31 16:12                         ` Marc Zyngier
2011-08-31 16:55                         ` Marc Dietrich
2011-08-31 16:55                           ` Marc Dietrich
2011-09-01 10:34                           ` Marc Zyngier
2011-09-01 10:34                             ` Marc Zyngier
     [not found]                             ` <4E5F5FA9.3010305-5wv7dgnIgG8@public.gmane.org>
2011-09-01 11:13                               ` Marc Dietich
2011-09-01 11:13                                 ` Marc Dietich
2011-09-01 19:08                                 ` Stephen Warren
2011-09-01 19:08                                   ` Stephen Warren
2011-09-02  9:50                                   ` Marc Zyngier
2011-09-02  9:50                                     ` Marc Zyngier
2011-09-02 17:07                                     ` Stephen Warren [this message]
2011-09-02 17:07                                       ` Stephen Warren
     [not found]                                   ` <74CDBE0F657A3D45AFBB94109FB122FF04B327A383-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-09-02 11:13                                     ` Marc Dietich
2011-09-02 11:13                                       ` Marc Dietich
2011-08-31 17:46                     ` Nicolas Pitre
2011-08-31 17:46                       ` Nicolas Pitre
2011-08-31 17:51                       ` Will Deacon
2011-08-31 17:51                         ` Will Deacon
     [not found]                         ` <20110831175147.GI8777-SGELLbQ0bobZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2011-08-31 18:19                           ` Rob Herring
2011-08-31 18:19                             ` Rob Herring
2011-08-31 18:35                             ` Mark Salter
2011-08-31 18:35                               ` Mark Salter
2011-08-31 18:49                               ` Rob Herring
2011-08-31 18:49                                 ` Rob Herring
     [not found]                                 ` <4E5E8230.9060307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-08-31 18:58                                   ` Mark Salter
2011-08-31 18:58                                     ` Mark Salter
2011-08-31 19:35                             ` Will Deacon
2011-08-31 19:35                               ` Will Deacon
2011-09-08 22:41                               ` Mark Salter
2011-09-08 22:41                                 ` Mark Salter
     [not found]                                 ` <1315521779.2313.29.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2011-10-31  6:49                                   ` Pandita, Vikram
2011-10-31  6:49                                     ` Pandita, Vikram
2011-08-31  0:56           ` Ming Lei
2011-08-31  0:56             ` Ming Lei
2011-09-01 23:16   ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF04B327A5C1@HQMAIL01.nvidia.com \
    --to=swarren@nvidia.com \
    --cc=B29397@freescale.com \
    --cc=Will.Deacon@arm.com \
    --cc=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=marvin24@gmx.de \
    --cc=ming.lei@canonical.com \
    --cc=msalter@redhat.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.