From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"Benson Leung" <bleung@chromium.org>,
linux-leds <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio
Date: Thu, 15 Oct 2020 15:32:57 +0800 [thread overview]
Message-ID: <78daaeae-dc13-91ca-a33e-6fcba5f7f3d5@huawei.com> (raw)
In-Reply-To: <20201015071256.GA1092695@demiurge.local>
On 2020/10/15 15:12, Lubomir Rintel wrote:
> Hi,
>
> On Wed, Oct 14, 2020 at 12:08:45AM +0800, Zhen Lei wrote:
>> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is
>> cmd-gpio.
>>
>> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235:
>> cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Thanks for the patch.
>
> I've sent out an equivalent one some time ago:
> https://lore.kernel.org/lkml/20200925234805.228251-3-lkundrak@v3.sk/
>
> In any case, either is fine with me.
Geert Uytterhoeven just replied me that the *-gpio form is deprecated. So your
patch is the correct one.
>
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
>
>> ---
>> Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> index b3c45c046ba5e37..c7a06a9650db2ed 100644
>> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> @@ -24,7 +24,7 @@ properties:
>> compatible:
>> const: olpc,xo1.75-ec
>>
>> - cmd-gpios:
>> + cmd-gpio:
>> description: GPIO uspecifier of the CMD pin
>> maxItems: 1
>>
>> @@ -32,7 +32,7 @@ properties:
>>
>> required:
>> - compatible
>> - - cmd-gpios
>> + - cmd-gpio
>>
>> additionalProperties: false
>>
>> @@ -49,7 +49,7 @@ examples:
>> slave {
>> compatible = "olpc,xo1.75-ec";
>> spi-cpha;
>> - cmd-gpios = <&gpio 155 GPIO_ACTIVE_HIGH>;
>> + cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
>> };
>> };
>>
>> --
>> 1.8.3
>>
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: devicetree <devicetree@vger.kernel.org>,
Benson Leung <bleung@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Mark Brown <broonie@kernel.org>, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>, Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
linux-leds <linux-leds@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio
Date: Thu, 15 Oct 2020 15:32:57 +0800 [thread overview]
Message-ID: <78daaeae-dc13-91ca-a33e-6fcba5f7f3d5@huawei.com> (raw)
In-Reply-To: <20201015071256.GA1092695@demiurge.local>
On 2020/10/15 15:12, Lubomir Rintel wrote:
> Hi,
>
> On Wed, Oct 14, 2020 at 12:08:45AM +0800, Zhen Lei wrote:
>> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is
>> cmd-gpio.
>>
>> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235:
>> cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Thanks for the patch.
>
> I've sent out an equivalent one some time ago:
> https://lore.kernel.org/lkml/20200925234805.228251-3-lkundrak@v3.sk/
>
> In any case, either is fine with me.
Geert Uytterhoeven just replied me that the *-gpio form is deprecated. So your
patch is the correct one.
>
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
>
>> ---
>> Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> index b3c45c046ba5e37..c7a06a9650db2ed 100644
>> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
>> @@ -24,7 +24,7 @@ properties:
>> compatible:
>> const: olpc,xo1.75-ec
>>
>> - cmd-gpios:
>> + cmd-gpio:
>> description: GPIO uspecifier of the CMD pin
>> maxItems: 1
>>
>> @@ -32,7 +32,7 @@ properties:
>>
>> required:
>> - compatible
>> - - cmd-gpios
>> + - cmd-gpio
>>
>> additionalProperties: false
>>
>> @@ -49,7 +49,7 @@ examples:
>> slave {
>> compatible = "olpc,xo1.75-ec";
>> spi-cpha;
>> - cmd-gpios = <&gpio 155 GPIO_ACTIVE_HIGH>;
>> + cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
>> };
>> };
>>
>> --
>> 1.8.3
>>
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-15 7:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 16:08 [PATCH 0/6] fix all errors except one reported by dt_binding_check Zhen Lei
2020-10-13 16:08 ` Zhen Lei
2020-10-13 16:08 ` [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led Zhen Lei
2020-10-13 16:08 ` Zhen Lei
2020-10-13 16:17 ` Dan Murphy
2020-10-13 16:17 ` Dan Murphy
2020-10-13 17:04 ` Pavel Machek
2020-10-13 17:04 ` Pavel Machek
2020-10-14 1:08 ` Leizhen (ThunderTown)
2020-10-14 1:08 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 2/6] dt-bindings: mfd: google,cros-ec: explicitly allow additional properties Zhen Lei
2020-10-13 16:08 ` [PATCH 2/6] dt-bindings: mfd: google, cros-ec: " Zhen Lei
2020-10-13 17:53 ` [PATCH 2/6] dt-bindings: mfd: google,cros-ec: " Dan Murphy
2020-10-13 17:53 ` Dan Murphy
2020-10-14 1:52 ` Leizhen (ThunderTown)
2020-10-14 1:52 ` Leizhen (ThunderTown)
2020-10-14 13:38 ` Rob Herring
2020-10-14 13:38 ` Rob Herring
2020-10-15 6:55 ` Leizhen (ThunderTown)
2020-10-15 6:55 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode Zhen Lei
2020-10-13 16:08 ` Zhen Lei
2020-10-14 13:41 ` Rob Herring
2020-10-14 13:41 ` Rob Herring
2020-10-13 16:08 ` [PATCH 4/6] dt-bindings: misc: explicitly add #address-cells " Zhen Lei
2020-10-13 16:08 ` Zhen Lei
2020-10-14 13:42 ` Rob Herring
2020-10-14 13:42 ` Rob Herring
2020-10-13 16:08 ` [PATCH 5/6] ARM: dts: mmp2-olpc-xo-1-75: explicitly add #address-cells=<0> " Zhen Lei
2020-10-13 16:08 ` Zhen Lei
2020-10-15 9:56 ` Leizhen (ThunderTown)
2020-10-15 9:56 ` Leizhen (ThunderTown)
2020-12-04 7:48 ` Leizhen (ThunderTown)
2020-12-04 7:48 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio Zhen Lei
2020-10-13 16:08 ` Zhen Lei
2020-10-13 17:32 ` Dan Murphy
2020-10-13 17:32 ` Dan Murphy
2020-10-14 1:29 ` Leizhen (ThunderTown)
2020-10-14 1:29 ` Leizhen (ThunderTown)
2020-10-14 13:50 ` Rob Herring
2020-10-14 13:50 ` Rob Herring
2020-10-15 3:23 ` Leizhen (ThunderTown)
2020-10-15 3:23 ` Leizhen (ThunderTown)
2020-10-16 14:13 ` Rob Herring
2020-10-16 14:13 ` Rob Herring
2020-10-15 7:12 ` Lubomir Rintel
2020-10-15 7:12 ` Lubomir Rintel
2020-10-15 7:32 ` Leizhen (ThunderTown) [this message]
2020-10-15 7:32 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78daaeae-dc13-91ca-a33e-6fcba5f7f3d5@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.