From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Al Grant <Al.Grant@arm.com>,
James Clark <James.Clark@arm.com>,
tglx@linutronix.de
Subject: Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer
Date: Thu, 30 Apr 2020 18:33:48 +0100 [thread overview]
Message-ID: <79ba3f5f9af951b2de52b8eb9e1bc25f@kernel.org> (raw)
In-Reply-To: <20200430161815.GE25258@willie-the-truck>
On 2020-04-30 17:18, Will Deacon wrote:
> On Thu, Apr 30, 2020 at 06:04:36PM +0200, Peter Zijlstra wrote:
>> On Thu, Apr 30, 2020 at 04:29:23PM +0100, Marc Zyngier wrote:
>>
>> > I wonder if we could/should make __sched_clock_offset available even when
>> > CONFIG_HAVE_UNSTABLE_SCHED_CLOCK isn't defined. It feels like it would
>> > help with this particular can or worm...
>>
>> Errrgh. __sched_clock_offset is only needed on x86 because we
>> transition
>> from one clock device to another on boot. It really shouldn't exist on
>> anything sane.
>
> I think we still transition from jiffies on arm64, because we don't
> register
> with sched_clock until the timer driver probes. Marc, is that right?
Indeed. The clocksource is only available relatively late, as we need to
discover the details of the platform and enable the various workarounds
(because nobody can get a simple 64bit counter right). So it is only at
that stage that we transition to it.
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>, Al Grant <Al.Grant@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, James Clark <James.Clark@arm.com>,
Leo Yan <leo.yan@linaro.org>, Namhyung Kim <namhyung@kernel.org>,
tglx@linutronix.de, Jiri Olsa <jolsa@redhat.com>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer
Date: Thu, 30 Apr 2020 18:33:48 +0100 [thread overview]
Message-ID: <79ba3f5f9af951b2de52b8eb9e1bc25f@kernel.org> (raw)
In-Reply-To: <20200430161815.GE25258@willie-the-truck>
On 2020-04-30 17:18, Will Deacon wrote:
> On Thu, Apr 30, 2020 at 06:04:36PM +0200, Peter Zijlstra wrote:
>> On Thu, Apr 30, 2020 at 04:29:23PM +0100, Marc Zyngier wrote:
>>
>> > I wonder if we could/should make __sched_clock_offset available even when
>> > CONFIG_HAVE_UNSTABLE_SCHED_CLOCK isn't defined. It feels like it would
>> > help with this particular can or worm...
>>
>> Errrgh. __sched_clock_offset is only needed on x86 because we
>> transition
>> from one clock device to another on boot. It really shouldn't exist on
>> anything sane.
>
> I think we still transition from jiffies on arm64, because we don't
> register
> with sched_clock until the timer driver probes. Marc, is that right?
Indeed. The clocksource is only available relatively late, as we need to
discover the details of the platform and enable the various workarounds
(because nobody can get a simple 64bit counter right). So it is only at
that stage that we transition to it.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-30 17:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 9:35 [PATCH] arm64: perf_event: Fix time_offset for arch timer Leo Yan
2020-03-20 9:35 ` Leo Yan
2020-04-01 1:24 ` Leo Yan
2020-04-01 1:24 ` Leo Yan
2020-04-30 14:58 ` Will Deacon
2020-04-30 14:58 ` Will Deacon
2020-04-30 15:29 ` Marc Zyngier
2020-04-30 15:29 ` Marc Zyngier
2020-04-30 16:04 ` Peter Zijlstra
2020-04-30 16:04 ` Peter Zijlstra
2020-04-30 16:18 ` Will Deacon
2020-04-30 16:18 ` Will Deacon
2020-04-30 17:33 ` Marc Zyngier [this message]
2020-04-30 17:33 ` Marc Zyngier
2020-05-01 15:14 ` Leo Yan
2020-05-01 15:14 ` Leo Yan
2020-05-01 15:26 ` Will Deacon
2020-05-01 15:26 ` Will Deacon
2020-05-01 16:10 ` Leo Yan
2020-05-01 16:10 ` Leo Yan
2020-05-01 17:13 ` Will Deacon
2020-05-01 17:13 ` Will Deacon
2020-05-01 15:29 ` Marc Zyngier
2020-05-01 15:29 ` Marc Zyngier
2020-04-30 16:27 ` Peter Zijlstra
2020-04-30 16:27 ` Peter Zijlstra
2020-04-30 16:45 ` Will Deacon
2020-04-30 16:45 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79ba3f5f9af951b2de52b8eb9e1bc25f@kernel.org \
--to=maz@kernel.org \
--cc=Al.Grant@arm.com \
--cc=James.Clark@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.