From: Marc Zyngier <maz@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-perf-users@vger.kernel.org, ito-yuichi@fujitsu.com,
Chen-Yu Tsai <wens@csie.org>, Ard Biesheuvel <ardb@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
kgdb-bugreport@lists.sourceforge.net,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Wei Li <liwei391@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 7/7] arm64: kgdb: Roundup cpus using the debug IPI
Date: Mon, 07 Aug 2023 12:08:06 +0100 [thread overview]
Message-ID: <7a295fcb4ff02542ff6835a77182fce8@kernel.org> (raw)
In-Reply-To: <ZNDNY_JfUxXm2vR5@FVFF77S0Q05N.cambridge.arm.com>
On 2023-08-07 11:54, Mark Rutland wrote:
> On Mon, Aug 07, 2023 at 11:47:04AM +0100, Marc Zyngier wrote:
>> On 2023-08-07 11:28, Mark Rutland wrote:
>> > On Thu, Jun 01, 2023 at 02:31:51PM -0700, Douglas Anderson wrote:
>> > > From: Sumit Garg <sumit.garg@linaro.org>
>> > >
>> > > Let's use the debug IPI for rounding up CPUs in kgdb. When the debug
>> > > IPI is backed by an NMI (or pseudo NMI) then this will let us debug
>> > > even hard locked CPUs. When the debug IPI isn't backed by an NMI then
>> > > this won't really have any huge benefit but it will still work.
>> > >
>> > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
>> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> > > ---
>> > >
>> > > Changes in v9:
>> > > - Remove fallback for when debug IPI isn't available.
>> > > - Renamed "NMI IPI" to "debug IPI" since it might not be backed by
>> > > NMI.
>> > >
>> > > arch/arm64/kernel/ipi_debug.c | 5 +++++
>> > > arch/arm64/kernel/kgdb.c | 14 ++++++++++++++
>> > > 2 files changed, 19 insertions(+)
>> >
>> > This looks fine to me, but I'd feel a bit happier if we had separate
>> > SGIs for
>> > the backtrace and the KGDB callback as they're logically unrelated.
>>
>> Well, we're a bit stuck here.
>>
>> We have exactly *one* spare SGI with GICv3, as we lose 8 of them
>> to the secure side. One possibility would be to mux some of the
>> lesser used IPIs onto two SGIs (one with standard priority, and
>> one with NMI priority).
>
> Understood; Doug and I suggested two options for that:
>
> 1) Unify/mux the IPI_CPU_STOP and IPI_CPU_CRASH_STOP IPIs
>
> The only *intended* difference between the two is that
> IPI_CPU_CRASH_STOP
> calls crash_save_cpu() before trying to stop the CPU, but the
> implementations have diverged significantly for unrelated reasons.
>
> 2) Remove IPI_WAKEUP
>
> We only use IPI_WAKEUP for the ACPI parking protocol, and we could
> reuse
> another IPI (e.g. IPI_RESCHEDULE) to achieve the same thing witout a
> dedicated IPI.
Sure. My concern is that we're papering over the fundamental problem,
which is that IPIs are limited resource, and that we're bound to pile
more stuff on them.
I'm all for reclaiming the ones that can be merged, but we may
ultimately
need a real fix for this.
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-perf-users@vger.kernel.org, ito-yuichi@fujitsu.com,
Chen-Yu Tsai <wens@csie.org>, Ard Biesheuvel <ardb@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
kgdb-bugreport@lists.sourceforge.net,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Wei Li <liwei391@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 7/7] arm64: kgdb: Roundup cpus using the debug IPI
Date: Mon, 07 Aug 2023 12:08:06 +0100 [thread overview]
Message-ID: <7a295fcb4ff02542ff6835a77182fce8@kernel.org> (raw)
In-Reply-To: <ZNDNY_JfUxXm2vR5@FVFF77S0Q05N.cambridge.arm.com>
On 2023-08-07 11:54, Mark Rutland wrote:
> On Mon, Aug 07, 2023 at 11:47:04AM +0100, Marc Zyngier wrote:
>> On 2023-08-07 11:28, Mark Rutland wrote:
>> > On Thu, Jun 01, 2023 at 02:31:51PM -0700, Douglas Anderson wrote:
>> > > From: Sumit Garg <sumit.garg@linaro.org>
>> > >
>> > > Let's use the debug IPI for rounding up CPUs in kgdb. When the debug
>> > > IPI is backed by an NMI (or pseudo NMI) then this will let us debug
>> > > even hard locked CPUs. When the debug IPI isn't backed by an NMI then
>> > > this won't really have any huge benefit but it will still work.
>> > >
>> > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
>> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> > > ---
>> > >
>> > > Changes in v9:
>> > > - Remove fallback for when debug IPI isn't available.
>> > > - Renamed "NMI IPI" to "debug IPI" since it might not be backed by
>> > > NMI.
>> > >
>> > > arch/arm64/kernel/ipi_debug.c | 5 +++++
>> > > arch/arm64/kernel/kgdb.c | 14 ++++++++++++++
>> > > 2 files changed, 19 insertions(+)
>> >
>> > This looks fine to me, but I'd feel a bit happier if we had separate
>> > SGIs for
>> > the backtrace and the KGDB callback as they're logically unrelated.
>>
>> Well, we're a bit stuck here.
>>
>> We have exactly *one* spare SGI with GICv3, as we lose 8 of them
>> to the secure side. One possibility would be to mux some of the
>> lesser used IPIs onto two SGIs (one with standard priority, and
>> one with NMI priority).
>
> Understood; Doug and I suggested two options for that:
>
> 1) Unify/mux the IPI_CPU_STOP and IPI_CPU_CRASH_STOP IPIs
>
> The only *intended* difference between the two is that
> IPI_CPU_CRASH_STOP
> calls crash_save_cpu() before trying to stop the CPU, but the
> implementations have diverged significantly for unrelated reasons.
>
> 2) Remove IPI_WAKEUP
>
> We only use IPI_WAKEUP for the ACPI parking protocol, and we could
> reuse
> another IPI (e.g. IPI_RESCHEDULE) to achieve the same thing witout a
> dedicated IPI.
Sure. My concern is that we're papering over the fundamental problem,
which is that IPIs are limited resource, and that we're bound to pile
more stuff on them.
I'm all for reclaiming the ones that can be merged, but we may
ultimately
need a real fix for this.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-07 11:08 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 21:31 [PATCH v9 0/7] arm64: Add debug IPI for backtraces / kgdb; try to use NMI for it Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-06-01 21:31 ` [PATCH v9 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-08-07 9:50 ` Mark Rutland
2023-08-07 9:50 ` Mark Rutland
2023-08-07 11:22 ` Sumit Garg
2023-08-07 11:22 ` Sumit Garg
2023-08-07 13:25 ` Mark Rutland
2023-08-07 13:25 ` Mark Rutland
2023-06-01 21:31 ` [PATCH v9 2/7] arm64: idle: Tag the arm64 idle functions as __cpuidle Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-08-07 9:52 ` Mark Rutland
2023-08-07 9:52 ` Mark Rutland
2023-06-01 21:31 ` [PATCH v9 3/7] arm64: Add framework for a debug IPI Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-08-07 10:12 ` Mark Rutland
2023-08-07 10:12 ` Mark Rutland
2023-08-21 22:16 ` Doug Anderson
2023-08-21 22:16 ` Doug Anderson
2023-08-22 6:42 ` Mark Rutland
2023-08-22 6:42 ` Mark Rutland
2023-06-01 21:31 ` [PATCH v9 4/7] arm64: smp: Assign and setup the " Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-08-07 10:17 ` Mark Rutland
2023-08-07 10:17 ` Mark Rutland
2023-06-01 21:31 ` [PATCH v9 5/7] arm64: ipi_debug: Add support for backtrace using " Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-08-07 10:23 ` Mark Rutland
2023-08-07 10:23 ` Mark Rutland
2023-08-22 0:06 ` Doug Anderson
2023-08-22 0:06 ` Doug Anderson
2023-08-22 6:35 ` Mark Rutland
2023-08-22 6:35 ` Mark Rutland
2023-06-01 21:31 ` [PATCH v9 6/7] kgdb: Provide a stub kgdb_nmicallback() if !CONFIG_KGDB Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-06-15 18:14 ` Doug Anderson
2023-06-15 18:14 ` Doug Anderson
2023-06-26 14:30 ` Daniel Thompson
2023-06-26 14:30 ` Daniel Thompson
2023-08-07 10:27 ` Mark Rutland
2023-08-07 10:27 ` Mark Rutland
2023-08-07 10:29 ` Mark Rutland
2023-08-07 10:29 ` Mark Rutland
2023-06-01 21:31 ` [PATCH v9 7/7] arm64: kgdb: Roundup cpus using the debug IPI Douglas Anderson
2023-06-01 21:31 ` Douglas Anderson
2023-08-07 10:28 ` Mark Rutland
2023-08-07 10:28 ` Mark Rutland
2023-08-07 10:47 ` Marc Zyngier
2023-08-07 10:47 ` Marc Zyngier
2023-08-07 10:54 ` Mark Rutland
2023-08-07 10:54 ` Mark Rutland
2023-08-07 11:08 ` Marc Zyngier [this message]
2023-08-07 11:08 ` Marc Zyngier
2023-08-07 11:13 ` Mark Rutland
2023-08-07 11:13 ` Mark Rutland
2023-08-07 15:24 ` Daniel Thompson
2023-08-07 15:24 ` Daniel Thompson
2023-08-07 16:04 ` Mark Rutland
2023-08-07 16:04 ` Mark Rutland
2023-08-08 11:17 ` Daniel Thompson
2023-08-08 11:17 ` Daniel Thompson
2023-06-02 5:19 ` [PATCH v9 0/7] arm64: Add debug IPI for backtraces / kgdb; try to use NMI for it Sumit Garg
2023-06-02 5:19 ` Sumit Garg
2023-07-24 15:55 ` Doug Anderson
2023-08-07 10:41 ` Mark Rutland
2023-08-07 10:41 ` Mark Rutland
2023-08-07 12:46 ` Sumit Garg
2023-08-07 12:46 ` Sumit Garg
2023-08-07 14:43 ` Mark Rutland
2023-08-07 14:43 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a295fcb4ff02542ff6835a77182fce8@kernel.org \
--to=maz@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=ito-yuichi@fujitsu.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=msys.mizuma@gmail.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.