Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor

From: Javier Carrasco <javier.carrasco@wolfvision.net>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor
Date: Tue, 6 Feb 2024 16:05:15 +0100	[thread overview]
Message-ID: <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net> (raw)
In-Reply-To: <ZcJDFi+iIQOWzgYw@finisterre.sirena.org.uk>

On 06.02.24 15:32, Mark Brown wrote:
> On Tue, Feb 06, 2024 at 02:59:34PM +0100, Javier Carrasco wrote:
> 
>> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
>> multicore controller for voice processing.
> 
> Acked-by: Mark Brown <broonie@kernel.org>
> 
> though...
> 
>> +  vdd-supply:
>> +    description:
>> +      Regulator for the 1V0 supply.
>> +
>> +  vdd2-supply:
>> +    description:
>> +      Regulator for the 3V3 supply.
> 
> ...it's a bit weird that the supplies are named like this, usually
> there'd be some sort of meaningful name (even if it's just VDD_1V0 and
> VDD_3V3 or something).  Are you sure these are the actual names?

The names in the datasheet are vdd for the 1V0 supply and vddio for the
3V3 supply. I named the latter vdd2 instead because this device does not
have its own driver and instead it uses the onboard_usb_hub generic
driver, where the supplies are named vdd and vdd2.

Those are the names used for devm_regulator_bulk_get(). Is that not the
right way to match them?

Thank you and best regards,
Javier Carrasco