Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor

From: Mark Brown <broonie@kernel.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor
Date: Tue, 6 Feb 2024 15:35:44 +0000	[thread overview]
Message-ID: <ZcJR0LrwaS5GAf5h@finisterre.sirena.org.uk> (raw)
In-Reply-To: <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net>

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On Tue, Feb 06, 2024 at 04:05:15PM +0100, Javier Carrasco wrote:

> The names in the datasheet are vdd for the 1V0 supply and vddio for the
> 3V3 supply. I named the latter vdd2 instead because this device does not
> have its own driver and instead it uses the onboard_usb_hub generic
> driver, where the supplies are named vdd and vdd2.

> Those are the names used for devm_regulator_bulk_get(). Is that not the
> right way to match them?

The binding should really use vddio instead of vdd2 but if that's an
existing binding then it gets more annoying, probably that existing
binding is wrong too since vddio does sound like an entirely plausible
standard name for a 3.3V supply. :/  At the very least the binding
should document the weird mapping, though ideally the driver would be
tought to request names matching the datasheet if the compatible is the
one for this device.  Doing the better naming might be too much hassle
though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]