Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor

From: Mark Brown <broonie@kernel.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500 voice processor
Date: Tue, 6 Feb 2024 16:22:40 +0000	[thread overview]
Message-ID: <ZcJc0JVr0nOGYK0B@finisterre.sirena.org.uk> (raw)
In-Reply-To: <42106e0c-109c-4ba2-a703-f95df92db5e3@wolfvision.net>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Tue, Feb 06, 2024 at 04:35:54PM +0100, Javier Carrasco wrote:

> I took a look at its datasheet and there is no vdd2 as such, so I think
> we are in a similar situation here. Actually that device requires five
> supplies and they have been grouped into vdd and vdd2 according to their
> voltage level.

That binding is just broken then and should be updated to reflect the
reality of the hardware.  The current thing just won't work if any of
those supplies come from different regulators.  It's really hard to
understand how bindings like this get written :/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]