From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Conor Dooley <mail@conchuod.ie>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
Serge Semin <fancer.lancer@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Palmer Dabbelt <palmer@rivosinc.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Niklas Cassel <niklas.cassel@wdc.com>,
Dillon Min <dillon.minfei@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-riscv@lists.infradead.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 03/13] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts
Date: Mon, 18 Jul 2022 16:12:28 +0100 [thread overview]
Message-ID: <7c68e645-efd7-c48c-77aa-9aa607c77033@codethink.co.uk> (raw)
In-Reply-To: <20220705215213.1802496-4-mail@conchuod.ie>
On 05/07/2022 22:52, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> The Canaan k210 apparently has a Sysnopsys Designware AXI DMA
> controller, but according to the documentation & devicetree it has 6
> interrupts rather than the standard one. Support the 6 interrupt
> configuration by unconditionally extending the binding to a maximum of
> 8 per-channel interrupts thereby matching the number of possible
> channels.
I think you can still configure it to produce a single interrupt
even if there are per-channel interrupts available. This is from
my reading of the driver a little while ago so may not be totally
correct now.
Having per-channel irqs might be useful in the future, but as above
I think it'll require the driver to be updated to do it (and possibly
some sort of detection)
> Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 4324a94b26b2..67aa7bb6d36a 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -34,7 +34,12 @@ properties:
> - const: axidma_apb_regs
>
> interrupts:
> - maxItems: 1
> + description:
> + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this
> + will be per-channel interrupts. Otherwise, this is a single combined IRQ
> + for all channels.
> + minItems: 1
> + maxItems: 8
>
> clocks:
> items:
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Conor Dooley <mail@conchuod.ie>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
Serge Semin <fancer.lancer@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Palmer Dabbelt <palmer@rivosinc.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Niklas Cassel <niklas.cassel@wdc.com>,
Dillon Min <dillon.minfei@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-riscv@lists.infradead.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 03/13] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts
Date: Mon, 18 Jul 2022 16:12:28 +0100 [thread overview]
Message-ID: <7c68e645-efd7-c48c-77aa-9aa607c77033@codethink.co.uk> (raw)
In-Reply-To: <20220705215213.1802496-4-mail@conchuod.ie>
On 05/07/2022 22:52, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> The Canaan k210 apparently has a Sysnopsys Designware AXI DMA
> controller, but according to the documentation & devicetree it has 6
> interrupts rather than the standard one. Support the 6 interrupt
> configuration by unconditionally extending the binding to a maximum of
> 8 per-channel interrupts thereby matching the number of possible
> channels.
I think you can still configure it to produce a single interrupt
even if there are per-channel interrupts available. This is from
my reading of the driver a little while ago so may not be totally
correct now.
Having per-channel irqs might be useful in the future, but as above
I think it'll require the driver to be updated to do it (and possibly
some sort of detection)
> Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 4324a94b26b2..67aa7bb6d36a 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -34,7 +34,12 @@ properties:
> - const: axidma_apb_regs
>
> interrupts:
> - maxItems: 1
> + description:
> + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this
> + will be per-channel interrupts. Otherwise, this is a single combined IRQ
> + for all channels.
> + minItems: 1
> + maxItems: 8
>
> clocks:
> items:
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Conor Dooley <mail@conchuod.ie>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
Serge Semin <fancer.lancer@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Palmer Dabbelt <palmer@rivosinc.com>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
devicetree@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Conor Dooley <conor.dooley@microchip.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
dmaengine@vger.kernel.org, linux-riscv@lists.infradead.org,
Dillon Min <dillon.minfei@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v5 03/13] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts
Date: Mon, 18 Jul 2022 16:12:28 +0100 [thread overview]
Message-ID: <7c68e645-efd7-c48c-77aa-9aa607c77033@codethink.co.uk> (raw)
In-Reply-To: <20220705215213.1802496-4-mail@conchuod.ie>
On 05/07/2022 22:52, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> The Canaan k210 apparently has a Sysnopsys Designware AXI DMA
> controller, but according to the documentation & devicetree it has 6
> interrupts rather than the standard one. Support the 6 interrupt
> configuration by unconditionally extending the binding to a maximum of
> 8 per-channel interrupts thereby matching the number of possible
> channels.
I think you can still configure it to produce a single interrupt
even if there are per-channel interrupts available. This is from
my reading of the driver a little while ago so may not be totally
correct now.
Having per-channel irqs might be useful in the future, but as above
I think it'll require the driver to be updated to do it (and possibly
some sort of detection)
> Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 4324a94b26b2..67aa7bb6d36a 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -34,7 +34,12 @@ properties:
> - const: axidma_apb_regs
>
> interrupts:
> - maxItems: 1
> + description:
> + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this
> + will be per-channel interrupts. Otherwise, this is a single combined IRQ
> + for all channels.
> + minItems: 1
> + maxItems: 8
>
> clocks:
> items:
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2022-07-18 15:56 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 21:52 [PATCH v5 00/13] Canaan devicetree fixes Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 01/13] dt-bindings: display: convert ilitek,ili9341.txt to dt-schema Conor Dooley
2022-07-05 21:52 ` [PATCH v5 01/13] dt-bindings: display: convert ilitek, ili9341.txt " Conor Dooley
2022-07-05 21:52 ` [PATCH v5 01/13] dt-bindings: display: convert ilitek,ili9341.txt " Conor Dooley
2022-07-05 21:52 ` [PATCH v5 02/13] dt-bindings: display: ili9341: document canaan kd233's lcd Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-12 7:56 ` Conor.Dooley
2022-07-12 7:56 ` Conor.Dooley
2022-07-12 7:56 ` Conor.Dooley
2022-07-05 21:52 ` [PATCH v5 03/13] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-06 5:45 ` Vinod Koul
2022-07-06 5:45 ` Vinod Koul
2022-07-06 5:45 ` Vinod Koul
2022-07-18 15:12 ` Ben Dooks [this message]
2022-07-18 15:12 ` Ben Dooks
2022-07-18 15:12 ` Ben Dooks
2022-07-18 15:23 ` Conor.Dooley
2022-07-18 15:23 ` Conor.Dooley
2022-07-18 15:23 ` Conor.Dooley
2022-07-05 21:52 ` [PATCH v5 04/13] dt-bindings: memory-controllers: add canaan k210 sram controller Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-06 14:48 ` Rob Herring
2022-07-06 14:48 ` Rob Herring
2022-07-06 14:48 ` Rob Herring
2022-07-10 19:39 ` Conor.Dooley
2022-07-10 19:39 ` Conor.Dooley
2022-07-10 19:39 ` Conor.Dooley
2022-07-10 23:21 ` Damien Le Moal
2022-07-10 23:21 ` Damien Le Moal
2022-07-10 23:21 ` Damien Le Moal
2022-07-12 15:54 ` Conor.Dooley
2022-07-12 15:54 ` Conor.Dooley
2022-07-12 15:54 ` Conor.Dooley
2022-07-12 15:59 ` Krzysztof Kozlowski
2022-07-12 15:59 ` Krzysztof Kozlowski
2022-07-12 15:59 ` Krzysztof Kozlowski
2022-07-12 16:04 ` Conor.Dooley
2022-07-12 16:04 ` Conor.Dooley
2022-07-12 16:04 ` Conor.Dooley
2022-08-16 9:27 ` Krzysztof Kozlowski
2022-08-16 9:27 ` Krzysztof Kozlowski
2022-08-16 9:27 ` Krzysztof Kozlowski
2022-08-16 9:31 ` Conor.Dooley
2022-08-16 9:31 ` Conor.Dooley
2022-08-16 9:31 ` Conor.Dooley
2022-07-05 21:52 ` [PATCH v5 05/13] riscv: dts: canaan: fix the k210's memory node Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 06/13] riscv: dts: canaan: fix the k210's timer nodes Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 07/13] riscv: dts: canaan: fix mmc node names Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 08/13] riscv: dts: canaan: fix kd233 display spi frequency Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 09/13] riscv: dts: canaan: use custom compatible for k210 i2s Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 10/13] riscv: dts: canaan: remove spi-max-frequency from controllers Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 11/13] riscv: dts: canaan: fix bus {ranges,reg} warnings Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 12/13] riscv: dts: canaan: add specific compatible for kd233's LCD Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` [PATCH v5 13/13] riscv: dts: canaan: build all devicetress if SOC_CANAAN Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-05 21:52 ` Conor Dooley
2022-07-06 8:03 ` [PATCH v5 00/13] Canaan devicetree fixes Geert Uytterhoeven
2022-07-06 8:03 ` Geert Uytterhoeven
2022-07-06 8:03 ` Geert Uytterhoeven
2022-07-06 8:21 ` Conor.Dooley
2022-07-06 8:21 ` Conor.Dooley
2022-07-06 8:21 ` Conor.Dooley
2022-07-06 11:55 ` Damien Le Moal
2022-07-06 11:55 ` Damien Le Moal
2022-07-06 11:55 ` Damien Le Moal
2022-07-06 12:01 ` Conor.Dooley
2022-07-06 12:01 ` Conor.Dooley
2022-07-06 12:01 ` Conor.Dooley
2022-07-06 8:09 ` Geert Uytterhoeven
2022-07-06 8:09 ` Geert Uytterhoeven
2022-07-06 8:09 ` Geert Uytterhoeven
2022-07-14 22:04 ` Palmer Dabbelt
2022-07-14 22:04 ` Palmer Dabbelt
2022-07-14 22:04 ` Palmer Dabbelt
2022-07-14 22:11 ` Conor.Dooley
2022-07-14 22:11 ` Conor.Dooley
2022-07-14 22:11 ` Conor.Dooley
2022-08-05 17:51 ` Conor.Dooley
2022-08-05 17:51 ` Conor.Dooley
2022-08-05 17:51 ` Conor.Dooley
2022-08-10 22:01 ` Palmer Dabbelt
2022-08-10 22:01 ` Palmer Dabbelt
2022-08-10 22:01 ` Palmer Dabbelt
2022-08-11 6:26 ` Conor.Dooley
2022-08-11 6:26 ` Conor.Dooley
2022-08-11 6:26 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c68e645-efd7-c48c-77aa-9aa607c77033@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=airlied@linux.ie \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fancer.lancer@gmail.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=masahiroy@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.