Re: [PATCH 09/11] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd

From: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <jassisinghbrar@gmail.com>,
	<mathieu.poirier@linaro.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <quic_gurus@quicinc.com>,
	<loic.poulain@linaro.org>, <quic_eberman@quicinc.com>,
	<robimarko@gmail.com>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>, <linux-clk@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
	<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
	<quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
	<quic_poovendh@quicinc.com>
Subject: Re: [PATCH 09/11] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd
Date: Fri, 19 May 2023 11:19:48 +0530	[thread overview]
Message-ID: <7d831dd2-8be3-2061-e566-7d1d4e95c10d@quicinc.com> (raw)
In-Reply-To: <2fe8e4fe-c4ba-188c-60eb-71e05be82cb8@linaro.org>


On 3/7/2023 9:11 PM, Krzysztof Kozlowski wrote:
> On 07/03/2023 05:41, Manikanta Mylavarapu wrote:
>> Enable nodes required for multipd remoteproc bring up
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 130 ++++++++++++++++++++++++++
>>   1 file changed, 130 insertions(+)
>>   	soc: soc@0 {
>>   		#address-cells = <1>;
>>   		#size-cells = <1>;
>> @@ -217,5 +259,93 @@ frame@b128000 {
>>   				status = "disabled";
>>   			};
>>   		};
>> +
>> +		tcsr_mutex: hwlock@1905000 {
> 
> This does not look like in correct order. Don't stuff things to the end
> of lists.
> 
Sure. I will keep nodes as per order.

>> +			compatible = "qcom,tcsr-mutex";
>> +			reg = <0x01905000 0x8000>;
>> +			#hwlock-cells = <1>;
>> +		};
>> +
>> +		apcs_glb: mailbox@b111000 {
>> +			compatible = "qcom,ipq5018-apcs-apps-global";
>> +			reg = <0x0b111000 0x1000>;
>> +			#clock-cells = <1>;
>> +			#mbox-cells = <1>;
>> +		};
>> +
>> +		q6v5_wcss: remoteproc@cd00000 {
>> +			compatible = "qcom,ipq5018-q6-mpd";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges;
>> +			reg = <0x0cd00000 0x4040>;
>> +			interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>,
>> +					      <&wcss_smp2p_in 0 0>,
>> +					      <&wcss_smp2p_in 1 0>,
>> +					      <&wcss_smp2p_in 2 0>,
>> +					      <&wcss_smp2p_in 3 0>;
>> +			interrupt-names = "wdog",
>> +					  "fatal",
>> +					  "ready",
>> +					  "handover",
>> +					  "stop-ack";
>> +
>> +			qcom,smem-states = <&wcss_smp2p_out 0>,
>> +					   <&wcss_smp2p_out 1>;
>> +			qcom,smem-state-names = "shutdown",
>> +						"stop";
>> +			memory-region = <&q6_region>;
>> +
>> +			glink-edge {
>> +				interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>;
>> +				label = "rtr";
>> +				qcom,remote-pid = <1>;
>> +				mboxes = <&apcs_glb 8>;
>> +			};
>> +
>> +			q6_wcss_pd1: remoteproc_pd1 {
> 
> No underscores in node names, generic node names. Actually I don't get
> why do you need empty node at all.
> 
I removed underscores, now name should be pd-1/pd-2/pd-3. Yeah, it 
should not be empty node. I will correct it.

Thanks & Regards,
Manikanta.
>> +				compatible = "qcom,ipq5018-wcss-ahb-mpd";
>> +			};
>> +
>> +			q6_wcss_pd2: remoteproc_pd2 {
>> +				compatible = "qcom,ipq5018-wcss-pcie-mpd";
>> +				interrupts-extended = <&wcss_smp2p_in 16 0>,
>> +					<&wcss_smp2p_in 17 0>,
>> +					<&wcss_smp2p_in 20 0>,
>> +					<&wcss_smp2p_in 19 0>;
> 
> 
> Best regards,
> Krzysztof
>