Re: [PATCH 08/11] remoteproc: qcom: Add Hexagon based multipd rproc driver

From: Robert Marko <robimarko@gmail.com>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	agross@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, jassisinghbrar@gmail.com,
	mathieu.poirier@linaro.org, mturquette@baylibre.com,
	sboyd@kernel.org, quic_gurus@quicinc.com,
	loic.poulain@linaro.org, quic_eberman@quicinc.com,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-clk@vger.kernel.org, quic_srichara@quicinc.com,
	quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com,
	quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com,
	quic_anusha@quicinc.com, quic_poovendh@quicinc.com
Subject: Re: [PATCH 08/11] remoteproc: qcom: Add Hexagon based multipd rproc driver
Date: Wed, 22 Mar 2023 11:53:18 +0100	[thread overview]
Message-ID: <CAOX2RU79jGYc0wV4t0zbQHKYWtUFmTUzMGKcma7v9BMSt09X5A@mail.gmail.com> (raw)
In-Reply-To: <0bad147f-46b6-c52f-536f-92eeba8896ec@quicinc.com>

On Wed, 22 Mar 2023 at 11:52, Manikanta Mylavarapu
<quic_mmanikan@quicinc.com> wrote:
>
>
>
> On 3/22/2023 3:51 PM, Robert Marko wrote:
> > On Wed, 22 Mar 2023 at 11:19, Manikanta Mylavarapu
> > <quic_mmanikan@quicinc.com> wrote:
> >>
> >>
> >>
> >> On 3/7/2023 9:09 PM, Krzysztof Kozlowski wrote:
> >>> Why exactly do you need a new driver for this instead of extending
> >>> existing PIL? I feel all this is growing because no one wants to touch
> >>> existing code and merge with it...
> >>
> >> Previously we raised patch to add secure-pil to existing rproc driver.
> >> Bjorn suggested to introduce a new secure-pil driver.
> >>
> >> https://patchwork.kernel.org/project/linux-arm-msm/patch/1611984013-10201-3-git-send-email-gokulsri@codeaurora.org/
> >>
> >>
> >> Also IPQ5018, IPQ9574 soc's follows multipd model. So we decided to
> >> have new driver which consists 'secure-pil + multi pd' in one
> >> place.
> >
> > Would it be possible to have IPQ8074 and IPQ6018 support in it as well?
> > Cause, those are supported by ath11k but remoteproc support is missing,
> > I have been upstreaming parts for IPQ8074 for years now and it is usable but
> > we are still missing remoteproc.
> >
> > Regards,
> > Robert
> > >>
> >> Thanks & Regards,
> >> Manikanta.
>
> Yes. It's possible. Currently we added support for IPQ5018, IPQ9574.
> In subsequent patches, we will add IPQ8074, IPQ6018 & IPQ5332 support
> as well.

Great, that is rather nice to hear.

Regards,
Robert
>
> Regards,
> Manikanta.