Re: [PATCH 01/11] dt-bindings: remoteproc: qcom: Add support for multipd model

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
	Rob Herring <robh@kernel.org>
Cc: quic_sjaganat@quicinc.com, quic_gurus@quicinc.com,
	quic_gokulsri@quicinc.com, linux-arm-msm@vger.kernel.org,
	andersson@kernel.org, jassisinghbrar@gmail.com,
	konrad.dybcio@linaro.org, quic_eberman@quicinc.com,
	quic_poovendh@quicinc.com, robimarko@gmail.com,
	mturquette@baylibre.com, mathieu.poirier@linaro.org,
	krzysztof.kozlowski+dt@linaro.org, quic_arajkuma@quicinc.com,
	sboyd@kernel.org, robh+dt@kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, loic.poulain@linaro.org,
	quic_anusha@quicinc.com, linux-kernel@vger.kernel.org,
	quic_srichara@quicinc.com, quic_kathirav@quicinc.com,
	agross@kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 01/11] dt-bindings: remoteproc: qcom: Add support for multipd model
Date: Wed, 3 May 2023 18:27:33 +0200	[thread overview]
Message-ID: <fdb8e5a9-d8a0-1881-894f-1202ceefcc21@linaro.org> (raw)
In-Reply-To: <9de5629f-0a69-7b5b-c312-ab6fe19d60f8@quicinc.com>

On 03/05/2023 12:59, Manikanta Mylavarapu wrote:
> 
> 
> On 3/7/2023 6:53 PM, Rob Herring wrote:
>>
>> On Tue, 07 Mar 2023 10:11:27 +0530, Manikanta Mylavarapu wrote:
>>> Add new binding document for multipd model remoteproc.
>>> IPQ5018, IPQ9574 follows multipd model.
>>>
>>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>>> ---
>>>   .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++
>>>   1 file changed, 282 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dts:22:18: fatal error: dt-bindings/clock/qcom,gcc-ipq5018.h: No such file or directory
>>     22 |         #include <dt-bindings/clock/qcom,gcc-ipq5018.h>
>>        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1512: dt_binding_check] Error 2
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1678164097-13247-2-git-send-email-quic_mmanikan@quicinc.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
>>
> 
> I mentioned dependency link 
> (https://lore.kernel.org/linux-arm-msm/20220621161126.15883-1-quic_srichara@quicinc.com/) 
> in cover page patch because it's required for entire series. I will add 
> dependency link's and raise new patchset.

Is the dependency merged for v6.4-rc1? Looks not, so this means the
patch cannot be merged for next three months.

Why do you need any dependency here in this binding?

Best regards,
Krzysztof