From: Kevin Hilman <khilman@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>, linus.walleij@linaro.org
Cc: jbrunet@baylibre.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/6] Add drive-strength in Meson pinctrl driver
Date: Thu, 09 May 2019 10:34:34 -0700 [thread overview]
Message-ID: <7h36lnh6qd.fsf@baylibre.com> (raw)
In-Reply-To: <20190509162920.7054-1-glaroque@baylibre.com>
Guillaume La Roque <glaroque@baylibre.com> writes:
> The purpose of this patchset is to add drive-strength support in meson pinconf
> driver. This is a new feature that was added on the g12a. It is critical for us
> to support this since many functions are failing with default pad drive-strength.
>
> The value achievable by the SoC are 0.5mA, 2.5mA, 3mA and 4mA and the DT property
> 'drive-strength' is expressed in mA.
> So this patch add another generic property "drive-strength-uA". The change to do so
Looks like you forgot to update the cover letter.
The new property in this series is actually named
"drive-strengh-micromap"
> would be minimal and could be benefit to other platforms later on.
>
> Cheers
> Guillaume
>
> Changes since v3:
> - remove dev_err in meson_get_drive_strength
> - cleanup code
You didn't mention the property rename.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
jbrunet@baylibre.com
Subject: Re: [PATCH v4 0/6] Add drive-strength in Meson pinctrl driver
Date: Thu, 09 May 2019 10:34:34 -0700 [thread overview]
Message-ID: <7h36lnh6qd.fsf@baylibre.com> (raw)
In-Reply-To: <20190509162920.7054-1-glaroque@baylibre.com>
Guillaume La Roque <glaroque@baylibre.com> writes:
> The purpose of this patchset is to add drive-strength support in meson pinconf
> driver. This is a new feature that was added on the g12a. It is critical for us
> to support this since many functions are failing with default pad drive-strength.
>
> The value achievable by the SoC are 0.5mA, 2.5mA, 3mA and 4mA and the DT property
> 'drive-strength' is expressed in mA.
> So this patch add another generic property "drive-strength-uA". The change to do so
Looks like you forgot to update the cover letter.
The new property in this series is actually named
"drive-strengh-micromap"
> would be minimal and could be benefit to other platforms later on.
>
> Cheers
> Guillaume
>
> Changes since v3:
> - remove dev_err in meson_get_drive_strength
> - cleanup code
You didn't mention the property rename.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-05-09 17:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 16:29 [PATCH v4 0/6] Add drive-strength in Meson pinctrl driver Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 16:29 ` [PATCH v4 1/6] dt-bindings: pinctrl: add a 'drive-strength-microamp' property Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 17:35 ` Kevin Hilman
2019-05-09 17:35 ` Kevin Hilman
2019-05-09 16:29 ` [PATCH v4 2/6] pinctrl: generic: add new 'drive-strength-microamp' property support Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 16:29 ` [PATCH v4 3/6] dt-bindings: pinctrl: meson: Add drive-strength-microamp property Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 16:29 ` [PATCH v4 4/6] pinctrl: meson: Rework enable/disable bias part Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 16:29 ` [PATCH v4 5/6] pinctrl: meson: add support of drive-strength-microamp Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 16:29 ` [PATCH v4 6/6] pinctrl: meson: g12a: add DS bank value Guillaume La Roque
2019-05-09 16:29 ` Guillaume La Roque
2019-05-09 17:34 ` Kevin Hilman [this message]
2019-05-09 17:34 ` [PATCH v4 0/6] Add drive-strength in Meson pinctrl driver Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2019-05-09 16:28 Guillaume La Roque
2019-05-09 16:28 ` Guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h36lnh6qd.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.