From: "Jernej Škrabec" <jernej.skrabec@gmail.com> To: Andre Przywara <andre.przywara@arm.com>, Maxime Ripard <maxime@cerno.tech> Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>, Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman <megous@megous.com>, devicetree@vger.kernel.org Subject: Re: [PATCH v7 16/19] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Date: Thu, 17 Jun 2021 17:47:29 +0200 [thread overview] Message-ID: <8040051.UxXjYCDM83@jernej-laptop> (raw) In-Reply-To: <20210617154242.iovbze64up4u7wba@gilmour> Dne četrtek, 17. junij 2021 ob 17:42:42 CEST je Maxime Ripard napisal(a): > On Wed, Jun 16, 2021 at 11:06:30AM +0100, Andre Przywara wrote: > > > > + reserved-memory { > > > > + #address-cells = <2>; > > > > + #size-cells = <2>; > > > > + ranges; > > > > + > > > > + /* 512KiB reserved for ARM Trusted Firmware (BL31) */ > > > > + secmon_reserved: secmon@40000000 { > > > > + reg = <0x0 0x40000000 0x0 0x80000>; > > > > + no-map; > > > > + }; > > > > + }; > > > > > > Can't this be added by ATF directly? > > > > It actually is, and if you use U-Boot's DT ($fdtcontroladdr), that > > actually works. But as it stands right now, U-Boot fails to propagate > > this to any DTB that gets *loaded*. Fixing this requires generic code > > fixes, so I can't just hack this in for sunxi quickly. > > So I wanted to keep this around for a while, as missing this is a > > showstopper for booting Linux. > > It looks like we didn't need it for the H6, what makes it any different? H616 TF-A resides in DRAM and H6 resides in SRAM A2 (IIRC). H616 has much less useful SRAM due to ARISC removal. Best regards, Jernej > > > > > + mmc0: mmc@4020000 { > > > > + compatible = "allwinner,sun50i-h616-mmc", > > > > + "allwinner,sun50i-a100- mmc"; > > > > + reg = <0x04020000 0x1000>; > > > > + clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>; > > > > + clock-names = "ahb", "mmc"; > > > > + resets = <&ccu RST_BUS_MMC0>; > > > > + reset-names = "ahb"; > > > > + interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&mmc0_pins>; > > > > + status = "disabled"; > > > > + max-frequency = <150000000>; > > > > + cap-sd-highspeed; > > > > + cap-mmc-highspeed; > > > > + mmc-ddr-3_3v; > > > > + mmc-ddr-1_8v; > > > > > > This is not something you know in the DTSI? It entirely depends on how > > > the board has been designed. > > > > Are you referring just to the last property? > > Initially, yes, but the argument is for both... > > > This is copying what the driver unconditionally sets for the other > > > > SoCs at the moment (minus the H5 screwup): > > mmc->caps |= MMC_CAP_1_8V_DDR | MMC_CAP_3_3V_DDR; > > > > IIUC 1.8V operation requires a 1.8V regulator for vqmmc to actually > > work, so this property alone won't enable anything. > > But if it's just about the 1.8V property, I can of course move this to > > the board dts files. > > ... Since we've seen boards with only 3.3v or 1.8v wired to vqmmc, so we > should really just push this to the boards for new SoCs > > Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com> To: Andre Przywara <andre.przywara@arm.com>, Maxime Ripard <maxime@cerno.tech> Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>, Samuel Holland <samuel@sholland.org>, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman <megous@megous.com>, devicetree@vger.kernel.org Subject: Re: [PATCH v7 16/19] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Date: Thu, 17 Jun 2021 17:47:29 +0200 [thread overview] Message-ID: <8040051.UxXjYCDM83@jernej-laptop> (raw) In-Reply-To: <20210617154242.iovbze64up4u7wba@gilmour> Dne četrtek, 17. junij 2021 ob 17:42:42 CEST je Maxime Ripard napisal(a): > On Wed, Jun 16, 2021 at 11:06:30AM +0100, Andre Przywara wrote: > > > > + reserved-memory { > > > > + #address-cells = <2>; > > > > + #size-cells = <2>; > > > > + ranges; > > > > + > > > > + /* 512KiB reserved for ARM Trusted Firmware (BL31) */ > > > > + secmon_reserved: secmon@40000000 { > > > > + reg = <0x0 0x40000000 0x0 0x80000>; > > > > + no-map; > > > > + }; > > > > + }; > > > > > > Can't this be added by ATF directly? > > > > It actually is, and if you use U-Boot's DT ($fdtcontroladdr), that > > actually works. But as it stands right now, U-Boot fails to propagate > > this to any DTB that gets *loaded*. Fixing this requires generic code > > fixes, so I can't just hack this in for sunxi quickly. > > So I wanted to keep this around for a while, as missing this is a > > showstopper for booting Linux. > > It looks like we didn't need it for the H6, what makes it any different? H616 TF-A resides in DRAM and H6 resides in SRAM A2 (IIRC). H616 has much less useful SRAM due to ARISC removal. Best regards, Jernej > > > > > + mmc0: mmc@4020000 { > > > > + compatible = "allwinner,sun50i-h616-mmc", > > > > + "allwinner,sun50i-a100- mmc"; > > > > + reg = <0x04020000 0x1000>; > > > > + clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>; > > > > + clock-names = "ahb", "mmc"; > > > > + resets = <&ccu RST_BUS_MMC0>; > > > > + reset-names = "ahb"; > > > > + interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&mmc0_pins>; > > > > + status = "disabled"; > > > > + max-frequency = <150000000>; > > > > + cap-sd-highspeed; > > > > + cap-mmc-highspeed; > > > > + mmc-ddr-3_3v; > > > > + mmc-ddr-1_8v; > > > > > > This is not something you know in the DTSI? It entirely depends on how > > > the board has been designed. > > > > Are you referring just to the last property? > > Initially, yes, but the argument is for both... > > > This is copying what the driver unconditionally sets for the other > > > > SoCs at the moment (minus the H5 screwup): > > mmc->caps |= MMC_CAP_1_8V_DDR | MMC_CAP_3_3V_DDR; > > > > IIUC 1.8V operation requires a 1.8V regulator for vqmmc to actually > > work, so this property alone won't enable anything. > > But if it's just about the 1.8V property, I can of course move this to > > the board dts files. > > ... Since we've seen boards with only 3.3v or 1.8v wired to vqmmc, so we > should really just push this to the boards for new SoCs > > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-17 15:47 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-15 11:06 [PATCH v7 00/19] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 01/19] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 23:33 ` Rob Herring 2021-06-15 23:33 ` Rob Herring 2021-06-16 14:57 ` Andre Przywara 2021-06-16 14:57 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 02/19] mfd: axp20x: Allow AXP 806 chips without interrupt lines Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 03/19] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 23:35 ` Rob Herring 2021-06-15 23:35 ` Rob Herring 2021-06-16 14:59 ` Andre Przywara 2021-06-16 14:59 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 04/19] rtc: sun6i: Add support for linear day storage Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-17 18:16 ` kernel test robot 2021-06-17 18:16 ` kernel test robot 2021-06-17 18:16 ` kernel test robot 2021-06-17 20:07 ` kernel test robot 2021-06-17 20:07 ` kernel test robot 2021-06-17 20:07 ` kernel test robot 2021-06-18 15:43 ` Andre Przywara 2021-06-18 15:43 ` Andre Przywara 2021-06-18 15:43 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 05/19] rtc: sun6i: Add support for broken-down alarm registers Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-17 23:17 ` kernel test robot 2021-06-17 23:17 ` kernel test robot 2021-06-17 23:17 ` kernel test robot 2021-06-15 11:06 ` [PATCH v7 06/19] rtc: sun6i: Add support for RTCs without external LOSCs Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-16 9:14 ` Maxime Ripard 2021-06-16 9:14 ` Maxime Ripard 2021-06-16 10:14 ` Andre Przywara 2021-06-16 10:14 ` Andre Przywara 2021-06-16 13:47 ` Maxime Ripard 2021-06-16 13:47 ` Maxime Ripard 2021-07-22 23:17 ` Andre Przywara 2021-07-22 23:17 ` Andre Przywara 2021-07-26 14:59 ` Maxime Ripard 2021-07-26 14:59 ` Maxime Ripard 2021-07-29 8:04 ` Icenowy Zheng 2021-07-29 8:04 ` Icenowy Zheng 2021-07-29 8:04 ` Icenowy Zheng 2021-07-29 10:32 ` Maxime Ripard 2021-07-29 10:32 ` Maxime Ripard 2021-07-29 13:04 ` Icenowy Zheng 2021-07-29 13:04 ` Icenowy Zheng 2021-06-15 11:06 ` [PATCH v7 07/19] rtc: sun6i: Add Allwinner H616 support Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 08/19] dt-bindings: net: sun8i-emac: Add H616 compatible string Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 09/19] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 10/19] dt-bindings: usb: Add H616 compatible string Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 11/19] dt-bindings: usb: sunxi-musb: " Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 12/19] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 13/19] phy: sun4i-usb: Allow reset line to be shared Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:25 ` Philipp Zabel 2021-06-15 11:25 ` Philipp Zabel 2021-06-15 11:25 ` Philipp Zabel 2021-06-15 11:25 ` Philipp Zabel 2021-06-15 11:06 ` [PATCH v7 14/19] phy: sun4i-usb: Introduce port2 SIDDQ quirk Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-21 4:36 ` Vinod Koul 2021-06-21 4:36 ` Vinod Koul 2021-06-21 4:36 ` Vinod Koul 2021-06-21 9:14 ` Andre Przywara 2021-06-21 9:14 ` Andre Przywara 2021-06-21 9:14 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 15/19] phy: sun4i-usb: Add support for the H616 USB PHY Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-07-12 16:50 ` Evgeny Boger 2021-07-12 16:50 ` Evgeny Boger 2021-07-12 16:50 ` Evgeny Boger 2021-06-15 11:06 ` [PATCH v7 16/19] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-16 9:23 ` Maxime Ripard 2021-06-16 9:23 ` Maxime Ripard 2021-06-16 10:06 ` Andre Przywara 2021-06-16 10:06 ` Andre Przywara 2021-06-17 15:42 ` Maxime Ripard 2021-06-17 15:42 ` Maxime Ripard 2021-06-17 15:47 ` Jernej Škrabec [this message] 2021-06-17 15:47 ` Jernej Škrabec 2021-06-15 11:06 ` [PATCH v7 17/19] dt-bindings: arm: sunxi: Add two H616 board compatible strings Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-16 17:38 ` Rob Herring 2021-06-16 17:38 ` Rob Herring 2021-06-15 11:06 ` [PATCH v7 18/19] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara 2021-06-15 11:06 ` Andre Przywara 2021-06-15 11:06 ` [PATCH v7 19/19] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara 2021-06-15 11:06 ` Andre Przywara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8040051.UxXjYCDM83@jernej-laptop \ --to=jernej.skrabec@gmail.com \ --cc=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=icenowy@aosc.io \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=linux-sunxi@lists.linux.dev \ --cc=maxime@cerno.tech \ --cc=megous@megous.com \ --cc=robh@kernel.org \ --cc=samuel@sholland.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.