From: Chanwoo Choi <cwchoi00@gmail.com>
To: Dong Aisheng <aisheng.dong@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, abel.vesa@nxp.com
Subject: Re: [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats
Date: Wed, 10 Mar 2021 01:02:25 +0900 [thread overview]
Message-ID: <819323f6-3b2e-403b-3068-06d4c09af354@gmail.com> (raw)
In-Reply-To: <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com>
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
> Check .get_dev_status() in devfreq_update_stats in case it's abused
> when a device does not provide it.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/devfreq/governor.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index 31af6d072a10..67a6dbdd5d23 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
> @@ -89,6 +89,9 @@ int devfreq_update_target(struct devfreq *devfreq, unsigned long freq);
>
> static inline int devfreq_update_stats(struct devfreq *df)
> {
> + if (!df->profile->get_dev_status)
> + return -EINVAL;
> +
> return df->profile->get_dev_status(df->dev.parent, &df->last_status);
> }
> #endif /* _GOVERNOR_H */
>
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cwchoi00@gmail.com>
To: Dong Aisheng <aisheng.dong@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, abel.vesa@nxp.com
Subject: Re: [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats
Date: Wed, 10 Mar 2021 01:02:25 +0900 [thread overview]
Message-ID: <819323f6-3b2e-403b-3068-06d4c09af354@gmail.com> (raw)
In-Reply-To: <1615294733-22761-9-git-send-email-aisheng.dong@nxp.com>
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
> Check .get_dev_status() in devfreq_update_stats in case it's abused
> when a device does not provide it.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/devfreq/governor.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index 31af6d072a10..67a6dbdd5d23 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
> @@ -89,6 +89,9 @@ int devfreq_update_target(struct devfreq *devfreq, unsigned long freq);
>
> static inline int devfreq_update_stats(struct devfreq *df)
> {
> + if (!df->profile->get_dev_status)
> + return -EINVAL;
> +
> return df->profile->get_dev_status(df->dev.parent, &df->last_status);
> }
> #endif /* _GOVERNOR_H */
>
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-09 16:03 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 12:58 [PATCH 00/11] PM / devfreq: a few small fixes and improvements Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 01/11] doc: ABI: devfreq: remove invalid central_polling description Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 15:01 ` Chanwoo Choi
2021-03-09 15:01 ` Chanwoo Choi
2021-03-09 12:58 ` [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 15:02 ` Chanwoo Choi
2021-03-09 15:02 ` Chanwoo Choi
2021-03-09 15:14 ` Dong Aisheng
2021-03-09 15:14 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 03/11] PM / devfreq: fix the wrong set_freq path for userspace governor Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 15:13 ` Chanwoo Choi
2021-03-09 15:13 ` Chanwoo Choi
2021-03-09 15:16 ` Dong Aisheng
2021-03-09 15:16 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 15:47 ` Chanwoo Choi
2021-03-09 15:47 ` Chanwoo Choi
2021-03-10 2:42 ` Dong Aisheng
2021-03-10 2:42 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 15:53 ` Chanwoo Choi
2021-03-09 15:53 ` Chanwoo Choi
2021-03-10 2:43 ` Dong Aisheng
2021-03-10 2:43 ` Dong Aisheng
2021-03-10 3:07 ` Chanwoo Choi
2021-03-10 3:07 ` Chanwoo Choi
2021-03-10 3:04 ` Dong Aisheng
2021-03-10 3:04 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 06/11] PM / devfreq: drop the unnecessary low variable initialization Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 15:58 ` Chanwoo Choi
2021-03-09 15:58 ` Chanwoo Choi
2021-03-09 16:12 ` Chanwoo Choi
2021-03-09 16:12 ` Chanwoo Choi
2021-03-10 2:56 ` Dong Aisheng
2021-03-10 2:56 ` Dong Aisheng
2021-03-10 3:25 ` Chanwoo Choi
2021-03-10 3:25 ` Chanwoo Choi
2021-03-10 4:56 ` Dong Aisheng
2021-03-10 4:56 ` Dong Aisheng
2021-03-11 7:10 ` Chanwoo Choi
2021-03-11 7:10 ` Chanwoo Choi
2021-03-12 10:57 ` Dong Aisheng
2021-03-12 10:57 ` Dong Aisheng
2021-03-12 16:09 ` Chanwoo Choi
2021-03-12 16:09 ` Chanwoo Choi
2021-03-13 6:45 ` Dong Aisheng
2021-03-13 6:45 ` Dong Aisheng
2021-03-18 8:03 ` Dong Aisheng
2021-03-18 8:03 ` Dong Aisheng
2021-03-18 9:54 ` Chanwoo Choi
2021-03-18 9:54 ` Chanwoo Choi
2021-03-18 9:59 ` Chanwoo Choi
2021-03-18 9:59 ` Chanwoo Choi
2021-03-18 10:51 ` Dong Aisheng
2021-03-18 10:51 ` Dong Aisheng
2021-03-10 2:51 ` Dong Aisheng
2021-03-10 2:51 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 16:02 ` Chanwoo Choi [this message]
2021-03-09 16:02 ` Chanwoo Choi
2021-03-09 16:20 ` Chanwoo Choi
2021-03-09 16:20 ` Chanwoo Choi
2021-03-10 3:00 ` Dong Aisheng
2021-03-10 3:00 ` Dong Aisheng
2021-03-11 7:01 ` Chanwoo Choi
2021-03-11 7:01 ` Chanwoo Choi
2021-03-09 12:58 ` [PATCH 09/11] PM / devfreq: governor: optimize simpleondemand get_target_freq Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 16:09 ` Chanwoo Choi
2021-03-09 16:09 ` Chanwoo Choi
2021-03-10 3:02 ` Dong Aisheng
2021-03-10 3:02 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 10/11] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 16:22 ` Chanwoo Choi
2021-03-09 16:22 ` Chanwoo Choi
2021-03-09 12:58 ` [PATCH 11/11] PM / devfreq: imx8m-ddrc: drop polling_ms Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 16:23 ` Chanwoo Choi
2021-03-09 16:23 ` Chanwoo Choi
2021-03-10 3:03 ` Dong Aisheng
2021-03-10 3:03 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 00/11] PM / devfreq: a few small fixes and improvements Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 01/11] doc: ABI: devfreq: remove invalid central_polling description Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 03/11] PM / devfreq: fix the wrong set_freq path for userspace governor Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 06/11] PM / devfreq: drop the unnecessary low variable initialization Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 09/11] PM / devfreq: governor: optimize simpleondemand get_target_freq Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 10/11] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
2021-03-09 12:58 ` [PATCH 11/11] PM / devfreq: imx8m-ddrc: drop polling_ms Dong Aisheng
2021-03-09 12:58 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819323f6-3b2e-403b-3068-06d4c09af354@gmail.com \
--to=cwchoi00@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=dongas86@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.