From: Dong Aisheng <dongas86@gmail.com> To: Chanwoo Choi <cw00.choi@samsung.com> Cc: Chanwoo Choi <cwchoi00@gmail.com>, Dong Aisheng <aisheng.dong@nxp.com>, Linux PM <linux-pm@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Sascha Hauer <kernel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, open list <linux-kernel@vger.kernel.org>, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Abel Vesa <abel.vesa@nxp.com> Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq Date: Wed, 10 Mar 2021 11:04:27 +0800 [thread overview] Message-ID: <CAA+hA=Tv9SThyu3C33Kij8XikAiT1eb666VW328bxhUyrvYgfw@mail.gmail.com> (raw) In-Reply-To: <aea8cf18-ebe3-6140-e202-5f082040bbae@samsung.com> On Wed, Mar 10, 2021 at 10:50 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > On 3/10/21 11:43 AM, Dong Aisheng wrote: > > On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi <cwchoi00@gmail.com> wrote: > >> > >> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > >>> Use the more accurate returned new_freq as resume_freq. > >>> It's the same as how devfreq->previous_freq was updated. > >>> > >>> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > >>> --- > >>> drivers/devfreq/devfreq.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > >>> index 6e80bf70e7b3..ce569bd9adfa 100644 > >>> --- a/drivers/devfreq/devfreq.c > >>> +++ b/drivers/devfreq/devfreq.c > >>> @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > >>> devfreq->previous_freq = new_freq; > >>> > >>> if (devfreq->suspend_freq) > >>> - devfreq->resume_freq = cur_freq; > >>> + devfreq->resume_freq = new_freq; > >>> > >>> return err; > >>> } > >>> > >> > >> This patch fixes the previous patch[1]. So that you need to > >> add 'Fixes' tag as following: > >> > >> Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a > >> devfreq device") > >> > > > > Will add Fixes tag in next version. > > > On next version, recommend to place this patch at the first. Yes, good practice as it's a fix. Regards Aisheng > > > > >> commit 83f8ca45afbf041e312909f442128b99657d90b7 > >> Refs: v4.20-rc6-2-g83f8ca45afbf > >> Author: Lukasz Luba <lukasz.luba@arm.com> > >> AuthorDate: Wed Dec 5 12:05:53 2018 +0100 > >> Commit: MyungJoo Ham <myungjoo.ham@samsung.com> > >> CommitDate: Tue Dec 11 11:09:47 2018 +0900 > >> > >> PM / devfreq: add support for suspend/resume of a devfreq device > >> > >> > >> -- > >> Best Regards, > >> Samsung Electronics > >> Chanwoo Choi > > > > > > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <dongas86@gmail.com> To: Chanwoo Choi <cw00.choi@samsung.com> Cc: Chanwoo Choi <cwchoi00@gmail.com>, Dong Aisheng <aisheng.dong@nxp.com>, Linux PM <linux-pm@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Sascha Hauer <kernel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, open list <linux-kernel@vger.kernel.org>, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, Abel Vesa <abel.vesa@nxp.com> Subject: Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq Date: Wed, 10 Mar 2021 11:04:27 +0800 [thread overview] Message-ID: <CAA+hA=Tv9SThyu3C33Kij8XikAiT1eb666VW328bxhUyrvYgfw@mail.gmail.com> (raw) In-Reply-To: <aea8cf18-ebe3-6140-e202-5f082040bbae@samsung.com> On Wed, Mar 10, 2021 at 10:50 AM Chanwoo Choi <cw00.choi@samsung.com> wrote: > > On 3/10/21 11:43 AM, Dong Aisheng wrote: > > On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi <cwchoi00@gmail.com> wrote: > >> > >> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > >>> Use the more accurate returned new_freq as resume_freq. > >>> It's the same as how devfreq->previous_freq was updated. > >>> > >>> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > >>> --- > >>> drivers/devfreq/devfreq.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > >>> index 6e80bf70e7b3..ce569bd9adfa 100644 > >>> --- a/drivers/devfreq/devfreq.c > >>> +++ b/drivers/devfreq/devfreq.c > >>> @@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > >>> devfreq->previous_freq = new_freq; > >>> > >>> if (devfreq->suspend_freq) > >>> - devfreq->resume_freq = cur_freq; > >>> + devfreq->resume_freq = new_freq; > >>> > >>> return err; > >>> } > >>> > >> > >> This patch fixes the previous patch[1]. So that you need to > >> add 'Fixes' tag as following: > >> > >> Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a > >> devfreq device") > >> > > > > Will add Fixes tag in next version. > > > On next version, recommend to place this patch at the first. Yes, good practice as it's a fix. Regards Aisheng > > > > >> commit 83f8ca45afbf041e312909f442128b99657d90b7 > >> Refs: v4.20-rc6-2-g83f8ca45afbf > >> Author: Lukasz Luba <lukasz.luba@arm.com> > >> AuthorDate: Wed Dec 5 12:05:53 2018 +0100 > >> Commit: MyungJoo Ham <myungjoo.ham@samsung.com> > >> CommitDate: Tue Dec 11 11:09:47 2018 +0900 > >> > >> PM / devfreq: add support for suspend/resume of a devfreq device > >> > >> > >> -- > >> Best Regards, > >> Samsung Electronics > >> Chanwoo Choi > > > > > > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-10 3:05 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-09 12:58 [PATCH 00/11] PM / devfreq: a few small fixes and improvements Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 01/11] doc: ABI: devfreq: remove invalid central_polling description Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 15:01 ` Chanwoo Choi 2021-03-09 15:01 ` Chanwoo Choi 2021-03-09 12:58 ` [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 15:02 ` Chanwoo Choi 2021-03-09 15:02 ` Chanwoo Choi 2021-03-09 15:14 ` Dong Aisheng 2021-03-09 15:14 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 03/11] PM / devfreq: fix the wrong set_freq path for userspace governor Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 15:13 ` Chanwoo Choi 2021-03-09 15:13 ` Chanwoo Choi 2021-03-09 15:16 ` Dong Aisheng 2021-03-09 15:16 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 15:47 ` Chanwoo Choi 2021-03-09 15:47 ` Chanwoo Choi 2021-03-10 2:42 ` Dong Aisheng 2021-03-10 2:42 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 15:53 ` Chanwoo Choi 2021-03-09 15:53 ` Chanwoo Choi 2021-03-10 2:43 ` Dong Aisheng 2021-03-10 2:43 ` Dong Aisheng 2021-03-10 3:07 ` Chanwoo Choi 2021-03-10 3:07 ` Chanwoo Choi 2021-03-10 3:04 ` Dong Aisheng [this message] 2021-03-10 3:04 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 06/11] PM / devfreq: drop the unnecessary low variable initialization Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 15:58 ` Chanwoo Choi 2021-03-09 15:58 ` Chanwoo Choi 2021-03-09 16:12 ` Chanwoo Choi 2021-03-09 16:12 ` Chanwoo Choi 2021-03-10 2:56 ` Dong Aisheng 2021-03-10 2:56 ` Dong Aisheng 2021-03-10 3:25 ` Chanwoo Choi 2021-03-10 3:25 ` Chanwoo Choi 2021-03-10 4:56 ` Dong Aisheng 2021-03-10 4:56 ` Dong Aisheng 2021-03-11 7:10 ` Chanwoo Choi 2021-03-11 7:10 ` Chanwoo Choi 2021-03-12 10:57 ` Dong Aisheng 2021-03-12 10:57 ` Dong Aisheng 2021-03-12 16:09 ` Chanwoo Choi 2021-03-12 16:09 ` Chanwoo Choi 2021-03-13 6:45 ` Dong Aisheng 2021-03-13 6:45 ` Dong Aisheng 2021-03-18 8:03 ` Dong Aisheng 2021-03-18 8:03 ` Dong Aisheng 2021-03-18 9:54 ` Chanwoo Choi 2021-03-18 9:54 ` Chanwoo Choi 2021-03-18 9:59 ` Chanwoo Choi 2021-03-18 9:59 ` Chanwoo Choi 2021-03-18 10:51 ` Dong Aisheng 2021-03-18 10:51 ` Dong Aisheng 2021-03-10 2:51 ` Dong Aisheng 2021-03-10 2:51 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 16:02 ` Chanwoo Choi 2021-03-09 16:02 ` Chanwoo Choi 2021-03-09 16:20 ` Chanwoo Choi 2021-03-09 16:20 ` Chanwoo Choi 2021-03-10 3:00 ` Dong Aisheng 2021-03-10 3:00 ` Dong Aisheng 2021-03-11 7:01 ` Chanwoo Choi 2021-03-11 7:01 ` Chanwoo Choi 2021-03-09 12:58 ` [PATCH 09/11] PM / devfreq: governor: optimize simpleondemand get_target_freq Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 16:09 ` Chanwoo Choi 2021-03-09 16:09 ` Chanwoo Choi 2021-03-10 3:02 ` Dong Aisheng 2021-03-10 3:02 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 10/11] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 16:22 ` Chanwoo Choi 2021-03-09 16:22 ` Chanwoo Choi 2021-03-09 12:58 ` [PATCH 11/11] PM / devfreq: imx8m-ddrc: drop polling_ms Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 16:23 ` Chanwoo Choi 2021-03-09 16:23 ` Chanwoo Choi 2021-03-10 3:03 ` Dong Aisheng 2021-03-10 3:03 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 00/11] PM / devfreq: a few small fixes and improvements Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 01/11] doc: ABI: devfreq: remove invalid central_polling description Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 03/11] PM / devfreq: fix the wrong set_freq path for userspace governor Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 06/11] PM / devfreq: drop the unnecessary low variable initialization Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 08/11] PM / devfreq: check get_dev_status in devfreq_update_stats Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 09/11] PM / devfreq: governor: optimize simpleondemand get_target_freq Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 10/11] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng 2021-03-09 12:58 ` [PATCH 11/11] PM / devfreq: imx8m-ddrc: drop polling_ms Dong Aisheng 2021-03-09 12:58 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAA+hA=Tv9SThyu3C33Kij8XikAiT1eb666VW328bxhUyrvYgfw@mail.gmail.com' \ --to=dongas86@gmail.com \ --cc=abel.vesa@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=cw00.choi@samsung.com \ --cc=cwchoi00@gmail.com \ --cc=kernel@pengutronix.de \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.