Re: RESEND [PATCH v2] bsd-user: Add new maintainers - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Ed Maste <emaste@freebsd.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Kyle Evans <kevans@freebsd.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>,
	Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Li-Wen Hsu <lwhsu@freebsd.org>, Warner Losh <imp@bsdimp.com>
Subject: Re: RESEND [PATCH v2] bsd-user: Add new maintainers
Date: Mon, 8 Mar 2021 14:14:30 +0100	[thread overview]
Message-ID: <843150bc-7a6e-38e7-8957-22087ce0d80e@redhat.com> (raw)
In-Reply-To: <YEYVPsRcE1S9vuo3@redhat.com>

On 3/8/21 1:14 PM, Daniel P. Berrangé wrote:
> On Mon, Mar 08, 2021 at 12:55:10PM +0100, Thomas Huth wrote:
>> On 08/03/2021 12.16, Philippe Mathieu-Daudé wrote:
>>> Hi Peter,
>>>
>>> +Markus/Paolo/Laurent/Richard
>>>
>>> On 3/8/21 11:24 AM, Peter Maydell wrote:
>>>> On Mon, 8 Mar 2021 at 10:09, Thomas Huth <thuth@redhat.com> wrote:
>>>>>
>>>>> On 07/03/2021 16.56, Warner Losh wrote:
>>>>>> The FreeBSD project has a number of enhancements to bsd-user. Add myself
>>>>>> as maintainer and Kyle Evans as a reviewer. Also add our github repo.
>>>>>>
>>>>>> Signed-off-by: Warner Losh <imp@bsdimp.com>
>>>>>> Signed-off-by: Kyle Evans <kevans@freebsd.org>
>>>>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>>>>> ---
>>>>>>    MAINTAINERS | 5 ++++-
>>>>>>    1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index 26c9454823..ec0e935038 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -2896,9 +2896,12 @@ F: thunk.c
>>>>>>    F: accel/tcg/user-exec*.c
>>>>>>
>>>>>>    BSD user
>>>>>> -S: Orphan
>>>>>> +M: Warner Losh <imp@bsdimp.com>
>>>>>> +R: Kyle Evans <kevans@freebsd.org>
>>>>>> +S: Maintained
>>>>>>    F: bsd-user/
>>>>>>    F: default-configs/targets/*-bsd-user.mak
>>>>>> +T: git https://github.com/qemu-bsd-user/qemu-bsd-user bsd-user-rebase-3.1
>>>>>
>>>>> BSD is not really my home turf, but since nobody else picked this up and I
>>>>> plan to send a pull request for a bunch of patches anyway this week, I can
>>>>> also put it into my queue.
>>>>
>>>> Fine with me. (The v1 was in my to-review queue, but I'm currently
>>>> running somewhat behind on processing patches.)
>>>
>>> This is a patch for mainstream QEMU, I'm having hard time
>>> understanding the point of it. This is some official way
>>> to say that BSD-user is not maintained in mainstream but
>>> has to be used in the referred fork which is way different
>>> that mainstream...
>>>
>>> I'd rather wait for more mainstream contributions from Warner
>>> and Kyle, or blow the current orphan/dead code and import
>>> bsd-user-rebase-3.1 adding the maintainer entries along, but
>>> certainly not mark this dead code as maintained.
>>>
>>> Please convince me why I'm wrong, because I'd prefer NAck this
>>> patch...
>>
>> The idea has been discussed here:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg01399.html
>>
>> So this is not about declaring that bsd-user is maintained in a different
>> repository, but about giving Warner et al. a chance to finally upstream
>> their work.
> 
> Yep, I think this change in MAINTAINERS file is primarily about signalling
> intent for future.
> 
> Marking the subsystem as maintained isn't saying the current code is great,
> just that there is someone committed to improving it hereafter.

OK, thank Thomas / Daniel for explaining and referring to the "BSD-user
plans" (which I didn't notice earlier).

Warner, what about mentioning your plans here in this patch?

Resumed ideally, else a simple link to the thread.

> If we want to warn people that the current impl isn't great, that's goes
> back to the topic of having a way to classify QEMU features into quality
> levels Tier 1/2/3.

That indeed sounds good w.r.t. contributors / users expectations.

I suppose 1=hw_accel/security, 2=tested, 3=rest?

Not a single clue how to do that although.