Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

From: Thomas Huth <thuth@redhat.com>
To: Warner Losh <imp@bsdimp.com>, Roman Bolshakov <r.bolshakov@yadro.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Stefan Weil" <sw@weilnetz.de>
Subject: Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release
Date: Tue, 9 Mar 2021 06:08:12 +0100	[thread overview]
Message-ID: <ad56d549-295f-20cf-593c-4aa677fcb19e@redhat.com> (raw)
In-Reply-To: <CANCZdfow0RmLFJch1Kk3JhVhKLbBC_W0_BzkZG_HX+VDo9ZLmQ@mail.gmail.com>

On 08/03/2021 20.57, Warner Losh wrote:
> 
> 
> On Mon, Mar 8, 2021 at 12:51 PM Warner Losh <imp@bsdimp.com 
> <mailto:imp@bsdimp.com>> wrote:
> 
> 
> 
>     On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov <r.bolshakov@yadro.com
>     <mailto:r.bolshakov@yadro.com>> wrote:
> 
> 
>          > 8 марта 2021 г., в 18:41, Thomas Huth <thuth@redhat.com
>         <mailto:thuth@redhat.com>> написал(а):
>          >
>          > On 08/03/2021 16.26, Warner Losh wrote:
>          >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth <thuth@redhat.com
>         <mailto:thuth@redhat.com> <mailto:thuth@redhat.com
>         <mailto:thuth@redhat.com>>> wrote:
>          >>    On 07/03/2021 16.56, Warner Losh wrote:
>          >>     > FreeBSD 12.1 has reached end of life. Use 12.2 instead so
>         that FreeBSD's
>          >>     > project's packages will work.  Update which timezone to
>         pick. Work
>          >>    around a QEMU
>          >>     > bug that incorrectly raises an exception on a CRC32
>         instruction with
>          >>    the FPU
>          >>     > disabled.  The qemu bug is described here:
>          >>     >
>         https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html
>         <https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html>
>          >>   
>         <https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html
>         <https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html>>
>          >>     >
>          >>     > Signed-off-by: Warner Losh <imp@bsdimp.com
>         <mailto:imp@bsdimp.com> <mailto:imp@bsdimp.com <mailto:imp@bsdimp.com>>>
>          >>     >
>          >>     > ---
>          >>     >   tests/vm/freebsd | 14 +++++++++-----
>          >>     >   1 file changed, 9 insertions(+), 5 deletions(-)
>          >>    I gave this a try, but it's currently failing in the unit tests:
>          >>    Running test test-crypto-tlscredsx509
>          >>    ** (tests/test-crypto-tlscredsx509:9999): CRITICAL **:
>         12:56:35.157: Failed
>          >>    to sign certificate ASN1 parser: Value is not valid.
>          >>    ERROR test-crypto-tlscredsx509 - Bail out! FATAL-CRITICAL:
>         Failed to sign
>          >>    certificate ASN1 parser: Value is not valid.
>          >>    gmake: *** [Makefile.mtest:576: run-test-70] Error 1
>          >>    gmake: *** Waiting for unfinished jobs....
>          >>    Running test test-crypto-tlssession
>          >>    ** (tests/test-crypto-tlssession:10002): CRITICAL **:
>         12:56:35.288: Failed
>          >>    to sign certificate ASN1 parser: Value is not valid.
>          >>    ERROR test-crypto-tlssession - Bail out! FATAL-CRITICAL:
>         Failed to sign
>          >>    certificate ASN1 parser: Value is not valid.
>          >> That's totally unrelated to my change. Was it failing before?
>         What environment was it failing in because it all seemed to work for
>         me...
>          >
>          > It's been a while since I last ran "make vm-build-freebsd", so I
>         can't really tell whether the problem was already there before ...
>         when I now try to run it without your patch, it fails for me, too,
>         but rather due to FreeBSD 12.1 being out of service instead.
>          >
>          >>    I guess it's the same problem as:
>          >>
>         https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html
>         <https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html>
>          >>   
>         <https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html
>         <https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html>>
>          >>    ... so this would require a bug fix in the libtasn of FreeBSD
>         first? See:
>          >> https://gitlab.com/gnutls/libtasn1/-/merge_requests/71
>         <https://gitlab.com/gnutls/libtasn1/-/merge_requests/71>
>          >>    <https://gitlab.com/gnutls/libtasn1/-/merge_requests/71
>         <https://gitlab.com/gnutls/libtasn1/-/merge_requests/71>>
>          >>  Is this on the host that built qemu, or inside the VM or where
>         exactly?
>          >
>          > It's inside the VM ... I assume the libtasn there has the same
>         bug as the one on macOS?
>          >
> 
>         The gnutls failures on macOS and FreeBSD (with clang as main
>         compiler) won’t happen only if libtasn1 from master is used.
>         Otherwise libtasn1 has to be compiled with -O1/-O0.
> 
> 
>     Forgive my ignorance...
> 
>     Does this come from a submodule? From something I've built and installed
>     on my FreeBSD host? Or something that's installed into the FreeBSD guest
> 
> 
> ah, it's inside the guest.

Yes, IIUC it's the pre-installed libtasn1 in the guest, and the problem 
likely occurs just now since the clang that has been used to compile the 
library has been updated, too?

Anyway, can you reproduce the issue? If so, could you please file a bug 
ticket against libtasn1 there, so that it gets fixed? (sorry, I don't have 
any clue about the FreeBSD process here)

  Thomas