Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Warner Losh <imp@bsdimp.com>
Cc: "Stefan Weil" <sw@weilnetz.de>, "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>
Subject: Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release
Date: Mon, 8 Mar 2021 15:31:46 +0000	[thread overview]
Message-ID: <YEZDYtnx/Qp76aIz@redhat.com> (raw)
In-Reply-To: <CANCZdfq+ocyZnMt2td3ynx3gWqdPm1csddTjuhAEbxV-QL3Gow@mail.gmail.com>

On Mon, Mar 08, 2021 at 08:26:50AM -0700, Warner Losh wrote:
> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth <thuth@redhat.com> wrote:
> 
> > On 07/03/2021 16.56, Warner Losh wrote:
> > > FreeBSD 12.1 has reached end of life. Use 12.2 instead so that FreeBSD's
> > > project's packages will work.  Update which timezone to pick. Work
> > around a QEMU
> > > bug that incorrectly raises an exception on a CRC32 instruction with the
> > FPU
> > > disabled.  The qemu bug is described here:
> > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html
> > >
> > > Signed-off-by: Warner Losh <imp@bsdimp.com>
> > >
> > > ---
> > >   tests/vm/freebsd | 14 +++++++++-----
> > >   1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > I gave this a try, but it's currently failing in the unit tests:
> >
> > Running test test-crypto-tlscredsx509
> >
> > ** (tests/test-crypto-tlscredsx509:9999): CRITICAL **: 12:56:35.157:
> > Failed
> > to sign certificate ASN1 parser: Value is not valid.
> > ERROR test-crypto-tlscredsx509 - Bail out! FATAL-CRITICAL: Failed to sign
> > certificate ASN1 parser: Value is not valid.
> > gmake: *** [Makefile.mtest:576: run-test-70] Error 1
> > gmake: *** Waiting for unfinished jobs....
> > Running test test-crypto-tlssession
> >
> > ** (tests/test-crypto-tlssession:10002): CRITICAL **: 12:56:35.288: Failed
> > to sign certificate ASN1 parser: Value is not valid.
> > ERROR test-crypto-tlssession - Bail out! FATAL-CRITICAL: Failed to sign
> > certificate ASN1 parser: Value is not valid.
> >
> 
> That's totally unrelated to my change. Was it failing before? What
> environment was it failing in because it all seemed to work for me...

Do you have  gnutls package present ? These tests are only run if both
gnutls and libtasn1 development packages are present.

> 
> 
> > I guess it's the same problem as:
> >
> > https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html
> >
> > ... so this would require a bug fix in the libtasn of FreeBSD first? See:
> >
> > https://gitlab.com/gnutls/libtasn1/-/merge_requests/71
> 
> 
>  Is this on the host that built qemu, or inside the VM or where exactly?

IIUC, it applies to anywhere the libtasn1 is built with modern clang.
IOW, the FreeBSD ports build of libtasn1 would need the patch.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|