Re: [PATCH] irqchip/stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested

From: Fabien DESSENNE <fabien.dessenne@foss.st.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Marek Vasut <marex@denx.de>, <linux-gpio@vger.kernel.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested
Date: Fri, 22 Apr 2022 12:25:30 +0200	[thread overview]
Message-ID: <85d3b83b-4c2c-7cd8-2147-0a58c5bb8251@foss.st.com> (raw)
In-Reply-To: <878rrxa0rr.wl-maz@kernel.org>

Hi Mark and Marek,

My intention was to have a single commit, instead of two commits with 
the second one making a part of the previous one obsolete.

Nevertheless I understand your points which are valid, so I will review 
Marek's patch first before submitting another patch.

BR
Fabien

On 22/04/2022 12:08, Marc Zyngier wrote:
> On Fri, 22 Apr 2022 10:20:36 +0100,
> Fabien DESSENNE <fabien.dessenne@foss.st.com> wrote:
>>
>> Hi Marek,
>>
>> I agree there is something wrong with the clock management in IRQ
>> context here and your patch goes in the right way.
>> There are also some other problems regarding performance (enabling /
>> disabling clock each time we want to change the IO value, ...).
>> For these both issues I have a patch, which basically keeps the GPIO
>> clocks enabled from probe.
>> I did not have time to submit it, but, considering your concerns, I
>> will do it in the coming days.
>> For the time being I suggest that we do not apply your patch.
> 
> Why? This fixes a glaring issue, and there are no alternatives at the
> moment. So if there is something to improve on, please base your patch
> on top of Marek's.
> 
> Thanks,
> 
> 	M.
> 