Re: [PATCH] irqchip/stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested

From: Marc Zyngier <maz@kernel.org>
To: Fabien DESSENNE <fabien.dessenne@foss.st.com>
Cc: Marek Vasut <marex@denx.de>, <linux-gpio@vger.kernel.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/stm32: Keep pinctrl block clock enabled when LEVEL IRQ requested
Date: Fri, 22 Apr 2022 11:08:24 +0100	[thread overview]
Message-ID: <878rrxa0rr.wl-maz@kernel.org> (raw)
In-Reply-To: <5f3aa91e-0ca3-a13a-1ea3-daae982b3d8f@foss.st.com>

On Fri, 22 Apr 2022 10:20:36 +0100,
Fabien DESSENNE <fabien.dessenne@foss.st.com> wrote:
> 
> Hi Marek,
> 
> I agree there is something wrong with the clock management in IRQ
> context here and your patch goes in the right way.
> There are also some other problems regarding performance (enabling /
> disabling clock each time we want to change the IO value, ...).
> For these both issues I have a patch, which basically keeps the GPIO
> clocks enabled from probe.
> I did not have time to submit it, but, considering your concerns, I
> will do it in the coming days.
> For the time being I suggest that we do not apply your patch.

Why? This fixes a glaring issue, and there are no alternatives at the
moment. So if there is something to improve on, please base your patch
on top of Marek's.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.