Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS
Date: Fri, 18 Nov 2022 13:37:31 -0800	[thread overview]
Message-ID: <871qq0q6zo.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <be06273fc45d5cc758a57c2244a1ba43e26458d3.camel@intel.com>

On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote:
>
> On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote:
> > From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> >
> > By defaut idle messaging is disabled for GSC CS so to unblock RC6
> > entry on media tile idle messaging need to be enabled.
> >
> > v2:
> >  - Fix review comments (Vinay)
> >  - Set GSC idle hysteresis as per spec (Badal)
> > v3:
> >  - Fix review comments (Rodrigo)
> >
> > Bspec: 71496
> >
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> > Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> > Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>
> He is the author of the patch, no?!
> or you can remove this or change the author to be you and keep his
> reviewed-by...
>
> or I can just remove his rv-b while merging.. just let me know..

Not sure if that is the case here, but when multiple people contribute to a
patch, the original author can review changes by others and add his
Reviewed-by, no? Or are we saying it is redundant for the author to add his
R-b?

Similarly, are S-o-b and R-b by the same person ok? I add changes to
someone's patch so add my S-o-b but also review other's changes so add my
R-b? Sometimes finding a 3rd person to add a R-b is hard. But two poeple
can contribute to a patch and review each other's changes so add both their
S-o-b's and R-b's or no?

:)

Ashutosh