From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com> To: "Nilawar, Badal" <badal.nilawar@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org> Cc: "Gupta, Anshuman" <anshuman.gupta@intel.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "Dixit, Ashutosh" <ashutosh.dixit@intel.com>, "Ewins, Jon" <jon.ewins@intel.com>, "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>, "Belgaumkar, Vinay" <vinay.belgaumkar@intel.com> Subject: Re: [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS Date: Fri, 18 Nov 2022 18:37:37 +0000 [thread overview] Message-ID: <be06273fc45d5cc758a57c2244a1ba43e26458d3.camel@intel.com> (raw) In-Reply-To: <20221118183354.1047829-1-badal.nilawar@intel.com> On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > From: Vinay Belgaumkar <vinay.belgaumkar@intel.com> > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > entry on media tile idle messaging need to be enabled. > > v2: > - Fix review comments (Vinay) > - Set GSC idle hysteresis as per spec (Badal) > v3: > - Fix review comments (Rodrigo) > > Bspec: 71496 > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> > Signed-off-by: Badal Nilawar <badal.nilawar@intel.com> > Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> He is the author of the patch, no?! or you can remove this or change the author to be you and keep his reviewed-by... or I can just remove his rv-b while merging.. just let me know.. > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 18 ++++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 ++++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > index b0a4a2dbe3ee..e971b153fda9 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > @@ -15,6 +15,22 @@ > #include "intel_rc6.h" > #include "intel_ring.h" > #include "shmem_utils.h" > +#include "intel_gt_regs.h" > + > +static void intel_gsc_idle_msg_enable(struct intel_engine_cs > *engine) > +{ > + struct drm_i915_private *i915 = engine->i915; > + > + if (IS_METEORLAKE(i915) && engine->id == GSC0) { > + intel_uncore_write(engine->gt->uncore, > + RC_PSMI_CTRL_GSCCS, > + > _MASKED_BIT_DISABLE(IDLE_MSG_DISABLE)); > + /* hysteresis 0xA=5us as recommended in spec*/ > + intel_uncore_write(engine->gt->uncore, > + PWRCTX_MAXCNT_GSCCS, > + 0xA); > + } > +} > > static void dbg_poison_ce(struct intel_context *ce) > { > @@ -275,6 +291,8 @@ void intel_engine_init__pm(struct intel_engine_cs > *engine) > > intel_wakeref_init(&engine->wakeref, rpm, &wf_ops); > intel_engine_init_heartbeat(engine); > + > + intel_gsc_idle_msg_enable(engine); > } > > /** > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > index c3cd92691795..80a979e6f6be 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > @@ -917,6 +917,10 @@ > #define MSG_IDLE_FW_MASK REG_GENMASK(13, 9) > #define MSG_IDLE_FW_SHIFT 9 > > +#define RC_PSMI_CTRL_GSCCS _MMIO(0x11a050) > +#define IDLE_MSG_DISABLE REG_BIT(0) > +#define PWRCTX_MAXCNT_GSCCS _MMIO(0x11a054) > + > #define FORCEWAKE_MEDIA_GEN9 _MMIO(0xa270) > #define FORCEWAKE_RENDER_GEN9 _MMIO(0xa278) >
WARNING: multiple messages have this Message-ID (diff)
From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com> To: "Nilawar, Badal" <badal.nilawar@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org> Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS Date: Fri, 18 Nov 2022 18:37:37 +0000 [thread overview] Message-ID: <be06273fc45d5cc758a57c2244a1ba43e26458d3.camel@intel.com> (raw) In-Reply-To: <20221118183354.1047829-1-badal.nilawar@intel.com> On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > From: Vinay Belgaumkar <vinay.belgaumkar@intel.com> > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > entry on media tile idle messaging need to be enabled. > > v2: > - Fix review comments (Vinay) > - Set GSC idle hysteresis as per spec (Badal) > v3: > - Fix review comments (Rodrigo) > > Bspec: 71496 > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> > Signed-off-by: Badal Nilawar <badal.nilawar@intel.com> > Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> He is the author of the patch, no?! or you can remove this or change the author to be you and keep his reviewed-by... or I can just remove his rv-b while merging.. just let me know.. > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 18 ++++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 ++++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > index b0a4a2dbe3ee..e971b153fda9 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > @@ -15,6 +15,22 @@ > #include "intel_rc6.h" > #include "intel_ring.h" > #include "shmem_utils.h" > +#include "intel_gt_regs.h" > + > +static void intel_gsc_idle_msg_enable(struct intel_engine_cs > *engine) > +{ > + struct drm_i915_private *i915 = engine->i915; > + > + if (IS_METEORLAKE(i915) && engine->id == GSC0) { > + intel_uncore_write(engine->gt->uncore, > + RC_PSMI_CTRL_GSCCS, > + > _MASKED_BIT_DISABLE(IDLE_MSG_DISABLE)); > + /* hysteresis 0xA=5us as recommended in spec*/ > + intel_uncore_write(engine->gt->uncore, > + PWRCTX_MAXCNT_GSCCS, > + 0xA); > + } > +} > > static void dbg_poison_ce(struct intel_context *ce) > { > @@ -275,6 +291,8 @@ void intel_engine_init__pm(struct intel_engine_cs > *engine) > > intel_wakeref_init(&engine->wakeref, rpm, &wf_ops); > intel_engine_init_heartbeat(engine); > + > + intel_gsc_idle_msg_enable(engine); > } > > /** > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > index c3cd92691795..80a979e6f6be 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > @@ -917,6 +917,10 @@ > #define MSG_IDLE_FW_MASK REG_GENMASK(13, 9) > #define MSG_IDLE_FW_SHIFT 9 > > +#define RC_PSMI_CTRL_GSCCS _MMIO(0x11a050) > +#define IDLE_MSG_DISABLE REG_BIT(0) > +#define PWRCTX_MAXCNT_GSCCS _MMIO(0x11a054) > + > #define FORCEWAKE_MEDIA_GEN9 _MMIO(0xa270) > #define FORCEWAKE_RENDER_GEN9 _MMIO(0xa278) >
next prev parent reply other threads:[~2022-11-18 18:37 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-18 18:33 [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS Badal Nilawar 2022-11-18 18:33 ` [Intel-gfx] " Badal Nilawar 2022-11-18 18:37 ` Vivi, Rodrigo [this message] 2022-11-18 18:37 ` Vivi, Rodrigo 2022-11-18 21:37 ` Dixit, Ashutosh 2022-11-18 21:37 ` Dixit, Ashutosh 2022-11-21 18:06 ` Vivi, Rodrigo 2022-11-21 18:06 ` [Intel-gfx] " Vivi, Rodrigo 2022-11-19 3:32 ` Nilawar, Badal 2022-11-19 3:32 ` [Intel-gfx] " Nilawar, Badal 2022-11-21 18:07 ` Vivi, Rodrigo 2022-11-21 18:07 ` [Intel-gfx] " Vivi, Rodrigo 2022-11-18 20:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Enable Idle Messaging for GSC CS (rev2) Patchwork 2022-11-19 11:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2022-11-17 8:15 [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS Badal Nilawar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=be06273fc45d5cc758a57c2244a1ba43e26458d3.camel@intel.com \ --to=rodrigo.vivi@intel.com \ --cc=anshuman.gupta@intel.com \ --cc=ashutosh.dixit@intel.com \ --cc=badal.nilawar@intel.com \ --cc=daniele.ceraolospurio@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jon.ewins@intel.com \ --cc=vinay.belgaumkar@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.