Re: [PATCH for-6.2 07/12] [automated] Use DECLARE_*CHECKER* macros when possible

From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Jason Wang" <jasowang@redhat.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Vijai Kumar K" <vijai@behindbytes.com>,
	"Taylor Simpson" <tsimpson@quicinc.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Vikram Garhwal" <fnu.vikram@xilinx.com>,
	qemu-block@nongnu.org, qemu-ppc@nongnu.org,
	"David Hildenbrand" <david@redhat.com>,
	"Havard Skinnemoen" <hskinnemoen@google.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-s390x@nongnu.org,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Greg Kurz" <groug@kaod.org>, "Alexander Bulekov" <alxndr@bu.edu>,
	"Bandan Das" <bsd@redhat.com>,
	qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Keith Busch" <kbusch@kernel.org>,
	qemu-riscv@nongnu.org,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Francisco Iglesias" <francisco.iglesias@xilinx.com>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Patrick Venture" <venture@google.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH for-6.2 07/12] [automated] Use DECLARE_*CHECKER* macros when possible
Date: Tue, 10 Aug 2021 08:09:55 +0200	[thread overview]
Message-ID: <871r71ygng.fsf@redhat.com> (raw)
In-Reply-To: <20210806211127.646908-8-ehabkost@redhat.com>

On Fri, Aug 06 2021, Eduardo Habkost <ehabkost@redhat.com> wrote:

> Converting existing QOM types to OBJECT_DECLARE_TYPE is not
> always trivial (due to inconsistent type/macro naming schemes),
> but at least converting existing manual QOM type checking macros
> to use DECLARE_*CHECKER* is a simpler process, and should at
> least discourage people from defining new QOM type checker macros
> manually.
>
> Generated using:
>
>   $ ./scripts/codeconverter/converter.py -i \
>     --pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Patrick Venture <venture@google.com>
> Cc: Thomas Huth <huth@tuxfamily.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Alexander Bulekov <alxndr@bu.edu>
> Cc: Bandan Das <bsd@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Klaus Jensen <its@irrelevant.dk>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Havard Skinnemoen <hskinnemoen@google.com>
> Cc: Tyrone Ting <kfting@nuvoton.com>
> Cc: Vijai Kumar K <vijai@behindbytes.com>
> Cc: Alistair Francis <Alistair.Francis@wdc.com>
> Cc: Bin Meng <bin.meng@windriver.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Cc: "Cédric Le Goater" <clg@kaod.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Vikram Garhwal <fnu.vikram@xilinx.com>
> Cc: Francisco Iglesias <francisco.iglesias@xilinx.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Cc: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org
> Cc: qemu-block@nongnu.org
> Cc: qemu-s390x@nongnu.org
> Cc: qemu-arm@nongnu.org
> Cc: qemu-riscv@nongnu.org
> Cc: qemu-ppc@nongnu.org
> ---
>  hw/nvme/nvme.h                              | 12 ++++++------
>  hw/usb/hcd-xhci-pci.h                       |  4 ++--
>  hw/usb/hcd-xhci-sysbus.h                    |  4 ++--
>  hw/usb/u2f.h                                |  8 ++------
>  include/hw/adc/npcm7xx_adc.h                |  4 ++--
>  include/hw/arm/npcm7xx.h                    | 15 ++++-----------
>  include/hw/char/shakti_uart.h               |  4 ++--
>  include/hw/dma/sifive_pdma.h                |  4 ++--
>  include/hw/dma/xlnx_csu_dma.h               |  4 ++--
>  include/hw/gpio/npcm7xx_gpio.h              |  4 ++--
>  include/hw/i2c/npcm7xx_smbus.h              |  4 ++--
>  include/hw/intc/m68k_irqc.h                 |  4 ++--
>  include/hw/intc/sifive_clint.h              |  4 ++--
>  include/hw/mem/npcm7xx_mc.h                 |  3 ++-
>  include/hw/misc/aspeed_lpc.h                |  3 ++-
>  include/hw/misc/mchp_pfsoc_dmc.h            | 10 ++++------
>  include/hw/misc/mchp_pfsoc_ioscb.h          |  4 ++--
>  include/hw/misc/mchp_pfsoc_sysreg.h         |  5 ++---
>  include/hw/misc/npcm7xx_clk.h               |  3 ++-
>  include/hw/misc/npcm7xx_gcr.h               |  3 ++-
>  include/hw/misc/npcm7xx_mft.h               |  4 ++--
>  include/hw/misc/npcm7xx_pwm.h               |  4 ++--
>  include/hw/misc/npcm7xx_rng.h               |  3 ++-
>  include/hw/misc/xlnx-versal-xramc.h         |  4 ++--
>  include/hw/net/npcm7xx_emc.h                |  4 ++--
>  include/hw/net/xlnx-zynqmp-can.h            |  4 ++--
>  include/hw/nvram/npcm7xx_otp.h              |  3 ++-
>  include/hw/ppc/spapr_drc.h                  | 13 ++++---------
>  include/hw/ppc/spapr_xive.h                 |  7 ++-----
>  include/hw/riscv/microchip_pfsoc.h          |  9 ++++-----
>  include/hw/riscv/shakti_c.h                 |  8 ++++----
>  include/hw/riscv/sifive_e.h                 |  8 ++++----
>  include/hw/riscv/sifive_u.h                 |  8 ++++----
>  include/hw/sd/cadence_sdhci.h               |  4 ++--
>  include/hw/ssi/npcm7xx_fiu.h                |  3 ++-
>  include/hw/ssi/sifive_spi.h                 |  3 ++-
>  include/hw/timer/npcm7xx_timer.h            |  4 ++--
>  include/hw/tricore/tricore_testdevice.h     |  4 ++--
>  include/hw/usb/hcd-dwc3.h                   |  4 ++--
>  include/hw/usb/xlnx-usb-subsystem.h         |  4 ++--
>  include/hw/usb/xlnx-versal-usb2-ctrl-regs.h |  4 ++--
>  include/hw/watchdog/sbsa_gwdt.h             |  4 ++--
>  include/qemu/accel.h                        |  8 ++------
>  target/hexagon/cpu.h                        |  8 ++------
>  chardev/char-parallel.c                     |  6 ++----
>  hw/i2c/i2c_mux_pca954x.c                    |  4 ++--
>  hw/m68k/mcf5206.c                           |  3 ++-
>  hw/mem/sparse-mem.c                         |  3 ++-
>  hw/misc/sbsa_ec.c                           |  3 ++-
>  hw/s390x/vhost-user-fs-ccw.c                |  4 ++--
>  hw/sensor/adm1272.c                         |  3 ++-
>  hw/sensor/max34451.c                        |  3 ++-
>  hw/usb/u2f-emulated.c                       |  4 ++--
>  hw/usb/u2f-passthru.c                       |  4 ++--
>  54 files changed, 126 insertions(+), 146 deletions(-)

Acked-by: Cornelia Huck <cohuck@redhat.com>