Re: [PATCH for-6.2 06/12] [automated] Split QOM "typedef struct T { ... } T" declarations

From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	qemu-block@nongnu.org, qemu-ppc@nongnu.org,
	"David Hildenbrand" <david@redhat.com>,
	"Havard Skinnemoen" <hskinnemoen@google.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Greg Kurz" <groug@kaod.org>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>,
	"Keith Busch" <kbusch@kernel.org>,
	qemu-riscv@nongnu.org,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Patrick Venture" <venture@google.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH for-6.2 06/12] [automated] Split QOM "typedef struct T { ... } T" declarations
Date: Tue, 10 Aug 2021 08:08:43 +0200	[thread overview]
Message-ID: <874kbxygpg.fsf@redhat.com> (raw)
In-Reply-To: <20210806211127.646908-7-ehabkost@redhat.com>

On Fri, Aug 06 2021, Eduardo Habkost <ehabkost@redhat.com> wrote:

> Automatically split struct definition and typedef declaration in
> separate declarations, using a codeconverter rule.  The rule will
> only touch declarations of structs/typedefs actually used by QOM
> types.
>
> This will make automated changes to use OBJECT_DECLARE* macros
> easier to implement, because automated removal of typedef lines
> will be easier and safer.
>
> Generated using:
>
>   $ ./scripts/codeconverter/converter.py -i \
>     --pattern=QOMStructTypedefSplit $(git grep -l '' -- '*.[ch]')
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Patrick Venture <venture@google.com>
> Cc: Thomas Huth <huth@tuxfamily.org>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Klaus Jensen <its@irrelevant.dk>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Havard Skinnemoen <hskinnemoen@google.com>
> Cc: Tyrone Ting <kfting@nuvoton.com>
> Cc: Alistair Francis <Alistair.Francis@wdc.com>
> Cc: Bin Meng <bin.meng@windriver.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Andrew Baumann <Andrew.Baumann@microsoft.com>
> Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Cc: "Cédric Le Goater" <clg@kaod.org>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: Laurent Vivier <lvivier@redhat.com>
> Cc: qemu-devel@nongnu.org
> Cc: qemu-block@nongnu.org
> Cc: qemu-s390x@nongnu.org
> Cc: qemu-arm@nongnu.org
> Cc: qemu-riscv@nongnu.org
> Cc: qemu-ppc@nongnu.org
> ---
>  hw/nvme/nvme.h                      | 10 ++++++----
>  hw/usb/hcd-uhci.h                   |  5 +++--
>  hw/usb/u2f.h                        |  5 +++--
>  include/hw/adc/npcm7xx_adc.h        |  5 +++--
>  include/hw/arm/npcm7xx.h            | 10 ++++++----
>  include/hw/core/accel-cpu.h         |  5 +++--
>  include/hw/dma/sifive_pdma.h        |  5 +++--
>  include/hw/dma/xlnx_csu_dma.h       |  5 +++--
>  include/hw/gpio/npcm7xx_gpio.h      |  5 +++--
>  include/hw/i2c/npcm7xx_smbus.h      |  5 +++--
>  include/hw/mem/npcm7xx_mc.h         |  5 +++--
>  include/hw/misc/bcm2835_cprman.h    | 20 ++++++++++++--------
>  include/hw/misc/mchp_pfsoc_dmc.h    | 10 ++++++----
>  include/hw/misc/mchp_pfsoc_ioscb.h  |  5 +++--
>  include/hw/misc/mchp_pfsoc_sysreg.h |  5 +++--
>  include/hw/misc/npcm7xx_clk.h       | 15 +++++++++------
>  include/hw/misc/npcm7xx_gcr.h       |  5 +++--
>  include/hw/misc/npcm7xx_mft.h       |  5 +++--
>  include/hw/misc/npcm7xx_rng.h       |  5 +++--
>  include/hw/nvram/npcm7xx_otp.h      |  5 +++--
>  include/hw/riscv/microchip_pfsoc.h  | 10 ++++++----
>  include/hw/riscv/sifive_e.h         |  5 +++--
>  include/hw/sd/cadence_sdhci.h       |  5 +++--
>  include/qemu/accel.h                | 10 ++++++----
>  chardev/char-parallel.c             | 10 ++++++----
>  hw/i2c/i2c_mux_pca954x.c            |  5 +++--
>  hw/m68k/mcf5206.c                   |  5 +++--
>  hw/misc/sbsa_ec.c                   |  5 +++--
>  hw/s390x/vhost-user-fs-ccw.c        |  5 +++--
>  tests/qtest/pnv-xscom-test.c        |  5 +++--
>  30 files changed, 123 insertions(+), 82 deletions(-)

Acked-by: Cornelia Huck <cohuck@redhat.com>