From: Kevin Hilman <khilman@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Alessandro Rubini <rubini@unipv.it>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>, Chris Ball <chris@printf.net>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend
Date: Tue, 04 Feb 2014 11:22:42 -0800 [thread overview]
Message-ID: <8738jyu1h9.fsf@paris.lan> (raw)
In-Reply-To: <1391529538-21685-6-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Tue, 4 Feb 2014 16:58:46 +0100")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Due to the available runtime PM callbacks, we are now able to put our
> device into low power state at system suspend.
>
> Earlier we could not accomplish this without trusting a power domain
> for the device to take care of it. Now we are able to cope with
> scenarios both with and without a power domain.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/host/mmci.c | 45 +++++++++++++++++++++++++--------------------
> 1 file changed, 25 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index c88da1c..074e0cb 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -1723,33 +1723,38 @@ static int mmci_remove(struct amba_device *dev)
> return 0;
> }
>
> -#ifdef CONFIG_SUSPEND
> -static int mmci_suspend(struct device *dev)
> +#ifdef CONFIG_PM_SLEEP
> +static int mmci_suspend_late(struct device *dev)
> {
> - struct amba_device *adev = to_amba_device(dev);
> - struct mmc_host *mmc = amba_get_drvdata(adev);
> + int ret = 0;
>
> - if (mmc) {
> - struct mmci_host *host = mmc_priv(mmc);
> - pm_runtime_get_sync(dev);
> - writel(0, host->base + MMCIMASK0);
> - }
> + if (pm_runtime_status_suspended(dev))
> + return 0;
>
> - return 0;
> + if (dev->pm_domain && dev->pm_domain->ops.runtime_suspend)
> + ret = dev->pm_domain->ops.runtime_suspend(dev);
> + else
> + ret = dev->bus->pm->runtime_suspend(dev);
> +
> + if (!ret)
> + pm_runtime_set_suspended(dev);
Isn't this basically open-coding pm_runtime_suspend()...
> + return ret;
> }
>
> -static int mmci_resume(struct device *dev)
> +static int mmci_resume_early(struct device *dev)
> {
> - struct amba_device *adev = to_amba_device(dev);
> - struct mmc_host *mmc = amba_get_drvdata(adev);
> + int ret = 0;
>
> - if (mmc) {
> - struct mmci_host *host = mmc_priv(mmc);
> - writel(MCI_IRQENABLE, host->base + MMCIMASK0);
> - pm_runtime_put(dev);
> - }
> + if (pm_runtime_status_suspended(dev))
> + return 0;
>
> - return 0;
> + if (dev->pm_domain && dev->pm_domain->ops.runtime_resume)
> + ret = dev->pm_domain->ops.runtime_resume(dev);
> + else
> + ret = dev->bus->pm->runtime_resume(dev);
> +
> + return ret;
...and this is pm_runtime_resume()? (though both terribly simplified.)
This is starting to show that building with PM_SLEEP but not PM_RUNTIME
is going to force open-coding a lot of stuff that the runtime PM
framework already provides. So either we need some helper functions so
we're not sprinkling manual calls to bus/pm_domain callbacks all over
the place, or maybe where we need to go is have a way for platforms that
really are "runtime PM centric" to declare that even PM_SLEEP depends on
PM_RUNTIME.
I'm trying to thing of a good reason to not make PM_SLEEP depend on
PM_RUNTIME for platforms like this.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Alessandro Rubini <rubini-9wsNiZum9E8@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Chris Ball <chris-OsFVWbfNK3isTnJN9+BGXg@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend
Date: Tue, 04 Feb 2014 11:22:42 -0800 [thread overview]
Message-ID: <8738jyu1h9.fsf@paris.lan> (raw)
In-Reply-To: <1391529538-21685-6-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (Ulf Hansson's message of "Tue, 4 Feb 2014 16:58:46 +0100")
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> writes:
> Due to the available runtime PM callbacks, we are now able to put our
> device into low power state at system suspend.
>
> Earlier we could not accomplish this without trusting a power domain
> for the device to take care of it. Now we are able to cope with
> scenarios both with and without a power domain.
>
> Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> drivers/mmc/host/mmci.c | 45 +++++++++++++++++++++++++--------------------
> 1 file changed, 25 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index c88da1c..074e0cb 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -1723,33 +1723,38 @@ static int mmci_remove(struct amba_device *dev)
> return 0;
> }
>
> -#ifdef CONFIG_SUSPEND
> -static int mmci_suspend(struct device *dev)
> +#ifdef CONFIG_PM_SLEEP
> +static int mmci_suspend_late(struct device *dev)
> {
> - struct amba_device *adev = to_amba_device(dev);
> - struct mmc_host *mmc = amba_get_drvdata(adev);
> + int ret = 0;
>
> - if (mmc) {
> - struct mmci_host *host = mmc_priv(mmc);
> - pm_runtime_get_sync(dev);
> - writel(0, host->base + MMCIMASK0);
> - }
> + if (pm_runtime_status_suspended(dev))
> + return 0;
>
> - return 0;
> + if (dev->pm_domain && dev->pm_domain->ops.runtime_suspend)
> + ret = dev->pm_domain->ops.runtime_suspend(dev);
> + else
> + ret = dev->bus->pm->runtime_suspend(dev);
> +
> + if (!ret)
> + pm_runtime_set_suspended(dev);
Isn't this basically open-coding pm_runtime_suspend()...
> + return ret;
> }
>
> -static int mmci_resume(struct device *dev)
> +static int mmci_resume_early(struct device *dev)
> {
> - struct amba_device *adev = to_amba_device(dev);
> - struct mmc_host *mmc = amba_get_drvdata(adev);
> + int ret = 0;
>
> - if (mmc) {
> - struct mmci_host *host = mmc_priv(mmc);
> - writel(MCI_IRQENABLE, host->base + MMCIMASK0);
> - pm_runtime_put(dev);
> - }
> + if (pm_runtime_status_suspended(dev))
> + return 0;
>
> - return 0;
> + if (dev->pm_domain && dev->pm_domain->ops.runtime_resume)
> + ret = dev->pm_domain->ops.runtime_resume(dev);
> + else
> + ret = dev->bus->pm->runtime_resume(dev);
> +
> + return ret;
...and this is pm_runtime_resume()? (though both terribly simplified.)
This is starting to show that building with PM_SLEEP but not PM_RUNTIME
is going to force open-coding a lot of stuff that the runtime PM
framework already provides. So either we need some helper functions so
we're not sprinkling manual calls to bus/pm_domain callbacks all over
the place, or maybe where we need to go is have a way for platforms that
really are "runtime PM centric" to declare that even PM_SLEEP depends on
PM_RUNTIME.
I'm trying to thing of a good reason to not make PM_SLEEP depend on
PM_RUNTIME for platforms like this.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend
Date: Tue, 04 Feb 2014 11:22:42 -0800 [thread overview]
Message-ID: <8738jyu1h9.fsf@paris.lan> (raw)
In-Reply-To: <1391529538-21685-6-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Tue, 4 Feb 2014 16:58:46 +0100")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Due to the available runtime PM callbacks, we are now able to put our
> device into low power state at system suspend.
>
> Earlier we could not accomplish this without trusting a power domain
> for the device to take care of it. Now we are able to cope with
> scenarios both with and without a power domain.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/host/mmci.c | 45 +++++++++++++++++++++++++--------------------
> 1 file changed, 25 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index c88da1c..074e0cb 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -1723,33 +1723,38 @@ static int mmci_remove(struct amba_device *dev)
> return 0;
> }
>
> -#ifdef CONFIG_SUSPEND
> -static int mmci_suspend(struct device *dev)
> +#ifdef CONFIG_PM_SLEEP
> +static int mmci_suspend_late(struct device *dev)
> {
> - struct amba_device *adev = to_amba_device(dev);
> - struct mmc_host *mmc = amba_get_drvdata(adev);
> + int ret = 0;
>
> - if (mmc) {
> - struct mmci_host *host = mmc_priv(mmc);
> - pm_runtime_get_sync(dev);
> - writel(0, host->base + MMCIMASK0);
> - }
> + if (pm_runtime_status_suspended(dev))
> + return 0;
>
> - return 0;
> + if (dev->pm_domain && dev->pm_domain->ops.runtime_suspend)
> + ret = dev->pm_domain->ops.runtime_suspend(dev);
> + else
> + ret = dev->bus->pm->runtime_suspend(dev);
> +
> + if (!ret)
> + pm_runtime_set_suspended(dev);
Isn't this basically open-coding pm_runtime_suspend()...
> + return ret;
> }
>
> -static int mmci_resume(struct device *dev)
> +static int mmci_resume_early(struct device *dev)
> {
> - struct amba_device *adev = to_amba_device(dev);
> - struct mmc_host *mmc = amba_get_drvdata(adev);
> + int ret = 0;
>
> - if (mmc) {
> - struct mmci_host *host = mmc_priv(mmc);
> - writel(MCI_IRQENABLE, host->base + MMCIMASK0);
> - pm_runtime_put(dev);
> - }
> + if (pm_runtime_status_suspended(dev))
> + return 0;
>
> - return 0;
> + if (dev->pm_domain && dev->pm_domain->ops.runtime_resume)
> + ret = dev->pm_domain->ops.runtime_resume(dev);
> + else
> + ret = dev->bus->pm->runtime_resume(dev);
> +
> + return ret;
...and this is pm_runtime_resume()? (though both terribly simplified.)
This is starting to show that building with PM_SLEEP but not PM_RUNTIME
is going to force open-coding a lot of stuff that the runtime PM
framework already provides. So either we need some helper functions so
we're not sprinkling manual calls to bus/pm_domain callbacks all over
the place, or maybe where we need to go is have a way for platforms that
really are "runtime PM centric" to declare that even PM_SLEEP depends on
PM_RUNTIME.
I'm trying to thing of a good reason to not make PM_SLEEP depend on
PM_RUNTIME for platforms like this.
Kevin
next prev parent reply other threads:[~2014-02-04 19:22 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 15:58 [PATCH 00/17] amba: PM fixups for amba bus and some amba drivers Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 01/17] amba: Let runtime PM callbacks be available for CONFIG_PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-19 9:40 ` Russell King - ARM Linux
2014-02-19 9:40 ` Russell King - ARM Linux
2014-02-19 9:40 ` Russell King - ARM Linux
2014-02-19 11:40 ` Ulf Hansson
2014-02-19 11:40 ` Ulf Hansson
2014-02-19 11:40 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 02/17] amba: Add late and early PM callbacks Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 03/17] mmc: mmci: Mask IRQs for all variants during runtime suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-18 16:05 ` Russell King - ARM Linux
2014-02-18 16:05 ` Russell King - ARM Linux
2014-02-18 16:05 ` Russell King - ARM Linux
2014-02-18 16:36 ` Ulf Hansson
2014-02-18 16:36 ` Ulf Hansson
2014-02-18 16:36 ` Ulf Hansson
2014-02-18 16:46 ` Russell King - ARM Linux
2014-02-18 16:46 ` Russell King - ARM Linux
2014-02-18 16:46 ` Russell King - ARM Linux
2014-02-18 17:02 ` Ulf Hansson
2014-02-18 17:02 ` Ulf Hansson
2014-02-18 17:02 ` Ulf Hansson
2014-02-24 14:54 ` Linus Walleij
2014-02-24 14:54 ` Linus Walleij
2014-02-24 14:54 ` Linus Walleij
2014-02-04 15:58 ` [PATCH 04/17] mmc: mmci: Let runtime PM callbacks be available for CONFIG_PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:22 ` Kevin Hilman [this message]
2014-02-04 19:22 ` Kevin Hilman
2014-02-04 19:22 ` Kevin Hilman
2014-02-05 12:49 ` Linus Walleij
2014-02-05 12:49 ` Linus Walleij
2014-02-05 12:49 ` Linus Walleij
2014-02-05 14:13 ` Mark Brown
2014-02-05 14:13 ` Mark Brown
2014-02-05 14:13 ` Mark Brown
2014-02-05 20:08 ` Kevin Hilman
2014-02-05 20:08 ` Kevin Hilman
2014-02-05 20:08 ` Kevin Hilman
2014-02-05 20:08 ` Kevin Hilman
2014-02-10 11:11 ` Ulf Hansson
2014-02-10 11:11 ` Ulf Hansson
2014-02-10 11:11 ` Ulf Hansson
2014-02-10 18:03 ` Kevin Hilman
2014-02-10 18:03 ` Kevin Hilman
2014-02-10 18:03 ` Kevin Hilman
2014-02-10 18:03 ` Kevin Hilman
2014-02-04 15:58 ` [PATCH 06/17] spi: pl022: Let runtime PM callbacks be available for CONFIG_PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-19 14:20 ` Ulf Hansson
2014-02-19 14:20 ` Ulf Hansson
2014-02-19 14:20 ` Ulf Hansson
2014-02-19 15:10 ` Mark Brown
2014-02-19 15:10 ` Mark Brown
2014-02-19 15:10 ` Mark Brown
2014-02-19 18:02 ` Ulf Hansson
2014-02-19 18:02 ` Ulf Hansson
2014-02-19 18:02 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:16 ` Mark Brown
2014-02-04 19:16 ` Mark Brown
2014-02-10 12:33 ` Ulf Hansson
2014-02-10 12:33 ` Ulf Hansson
2014-02-10 12:33 ` Ulf Hansson
2014-02-10 12:51 ` Mark Brown
2014-02-10 12:51 ` Mark Brown
2014-02-10 12:51 ` Mark Brown
2014-02-19 14:15 ` Ulf Hansson
2014-02-19 14:15 ` Ulf Hansson
2014-02-19 14:15 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 08/17] spi: pl022: Fully gate clocks at request inactivity Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 17:07 ` Mark Brown
2014-02-04 17:07 ` Mark Brown
2014-02-04 17:07 ` Mark Brown
2014-02-10 10:36 ` Ulf Hansson
2014-02-10 10:36 ` Ulf Hansson
2014-02-10 10:36 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 09/17] spi: pl022: Simplify clock handling Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:19 ` Mark Brown
2014-02-04 19:19 ` Mark Brown
2014-02-10 10:42 ` Ulf Hansson
2014-02-10 10:42 ` Ulf Hansson
2014-02-10 10:42 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 10/17] spi: pl022: Remove redundant pinctrl to default state in probe Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:20 ` Mark Brown
2014-02-04 19:20 ` Mark Brown
2014-02-04 19:20 ` Mark Brown
2014-02-05 12:53 ` Linus Walleij
2014-02-05 12:53 ` Linus Walleij
2014-02-05 12:53 ` Linus Walleij
2014-02-04 15:58 ` [PATCH 11/17] i2c: nomadik: Convert to devm functions Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-05 14:32 ` Linus Walleij
2014-02-05 14:32 ` Linus Walleij
2014-02-05 14:32 ` Linus Walleij
2014-02-04 15:58 ` [PATCH 12/17] i2c: nomadik: Remove redundant call to pm_runtime_disable Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 13/17] i2c: nomadik: Leave probe with the device in active state Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-05 14:34 ` Linus Walleij
2014-02-05 14:34 ` Linus Walleij
2014-02-05 14:34 ` Linus Walleij
2014-02-10 10:14 ` Ulf Hansson
2014-02-10 10:14 ` Ulf Hansson
2014-02-10 10:14 ` Ulf Hansson
2014-02-13 14:12 ` Ulf Hansson
2014-02-13 14:12 ` Ulf Hansson
2014-02-13 14:12 ` Ulf Hansson
2014-02-05 14:45 ` Fabio Estevam
2014-02-05 14:45 ` Fabio Estevam
2014-02-05 14:45 ` Fabio Estevam
2014-02-10 10:16 ` Ulf Hansson
2014-02-10 10:16 ` Ulf Hansson
2014-02-10 10:16 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 15/17] i2c: nomadik: Convert to late and early system PM callbacks Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 16/17] i2c: nomadik: Remove busy check for transfers at suspend late Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 17/17] i2c: nomadik: Fixup system suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 18:49 ` [PATCH 00/17] amba: PM fixups for amba bus and some amba drivers Mark Brown
2014-02-04 18:49 ` Mark Brown
2014-02-04 18:49 ` Mark Brown
2014-02-10 10:25 ` Ulf Hansson
2014-02-10 10:25 ` Ulf Hansson
2014-02-10 10:25 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738jyu1h9.fsf@paris.lan \
--to=khilman@linaro.org \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@unipv.it \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.