From: Ulf Hansson <ulf.hansson@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alessandro Rubini <rubini@unipv.it>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>, Chris Ball <chris@printf.net>,
Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM
Date: Mon, 10 Feb 2014 11:16:53 +0100 [thread overview]
Message-ID: <CAPDyKFphK8Zo1i7=w-n-VbGWpmLvUZs_U2Ekq0NCeqVxZ7VKvw@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5CzUuQrmbk6FpFGR56jHBtW-1d_AGcdgB2xyMG0Nkf+Fw@mail.gmail.com>
On 5 February 2014 15:45, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
>> +static int nmk_i2c_runtime_resume(struct device *dev)
>> +{
>> + struct amba_device *adev = to_amba_device(dev);,
>> + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev);
>> +
>> + clk_prepare_enable(nmk_i2c->clk);
>
> Previously the code was checking the return value from
> clk_prepare_enable(). You should keep the check here.
Will fix in v2! Thanks for reviewing!
Kind regards
Ulf Hansson
>
> Regards,
>
> Fabio Estevam
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Alessandro Rubini <rubini-9wsNiZum9E8@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Chris Ball <chris-OsFVWbfNK3isTnJN9+BGXg@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-i2c <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM
Date: Mon, 10 Feb 2014 11:16:53 +0100 [thread overview]
Message-ID: <CAPDyKFphK8Zo1i7=w-n-VbGWpmLvUZs_U2Ekq0NCeqVxZ7VKvw@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5CzUuQrmbk6FpFGR56jHBtW-1d_AGcdgB2xyMG0Nkf+Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 5 February 2014 15:45, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>
>> +static int nmk_i2c_runtime_resume(struct device *dev)
>> +{
>> + struct amba_device *adev = to_amba_device(dev);,
>> + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev);
>> +
>> + clk_prepare_enable(nmk_i2c->clk);
>
> Previously the code was checking the return value from
> clk_prepare_enable(). You should keep the check here.
Will fix in v2! Thanks for reviewing!
Kind regards
Ulf Hansson
>
> Regards,
>
> Fabio Estevam
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM
Date: Mon, 10 Feb 2014 11:16:53 +0100 [thread overview]
Message-ID: <CAPDyKFphK8Zo1i7=w-n-VbGWpmLvUZs_U2Ekq0NCeqVxZ7VKvw@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5CzUuQrmbk6FpFGR56jHBtW-1d_AGcdgB2xyMG0Nkf+Fw@mail.gmail.com>
On 5 February 2014 15:45, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
>> +static int nmk_i2c_runtime_resume(struct device *dev)
>> +{
>> + struct amba_device *adev = to_amba_device(dev);,
>> + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev);
>> +
>> + clk_prepare_enable(nmk_i2c->clk);
>
> Previously the code was checking the return value from
> clk_prepare_enable(). You should keep the check here.
Will fix in v2! Thanks for reviewing!
Kind regards
Ulf Hansson
>
> Regards,
>
> Fabio Estevam
next prev parent reply other threads:[~2014-02-10 10:16 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 15:58 [PATCH 00/17] amba: PM fixups for amba bus and some amba drivers Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 01/17] amba: Let runtime PM callbacks be available for CONFIG_PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-19 9:40 ` Russell King - ARM Linux
2014-02-19 9:40 ` Russell King - ARM Linux
2014-02-19 9:40 ` Russell King - ARM Linux
2014-02-19 11:40 ` Ulf Hansson
2014-02-19 11:40 ` Ulf Hansson
2014-02-19 11:40 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 02/17] amba: Add late and early PM callbacks Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 03/17] mmc: mmci: Mask IRQs for all variants during runtime suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-18 16:05 ` Russell King - ARM Linux
2014-02-18 16:05 ` Russell King - ARM Linux
2014-02-18 16:05 ` Russell King - ARM Linux
2014-02-18 16:36 ` Ulf Hansson
2014-02-18 16:36 ` Ulf Hansson
2014-02-18 16:36 ` Ulf Hansson
2014-02-18 16:46 ` Russell King - ARM Linux
2014-02-18 16:46 ` Russell King - ARM Linux
2014-02-18 16:46 ` Russell King - ARM Linux
2014-02-18 17:02 ` Ulf Hansson
2014-02-18 17:02 ` Ulf Hansson
2014-02-18 17:02 ` Ulf Hansson
2014-02-24 14:54 ` Linus Walleij
2014-02-24 14:54 ` Linus Walleij
2014-02-24 14:54 ` Linus Walleij
2014-02-04 15:58 ` [PATCH 04/17] mmc: mmci: Let runtime PM callbacks be available for CONFIG_PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:22 ` Kevin Hilman
2014-02-04 19:22 ` Kevin Hilman
2014-02-04 19:22 ` Kevin Hilman
2014-02-05 12:49 ` Linus Walleij
2014-02-05 12:49 ` Linus Walleij
2014-02-05 12:49 ` Linus Walleij
2014-02-05 14:13 ` Mark Brown
2014-02-05 14:13 ` Mark Brown
2014-02-05 14:13 ` Mark Brown
2014-02-05 20:08 ` Kevin Hilman
2014-02-05 20:08 ` Kevin Hilman
2014-02-05 20:08 ` Kevin Hilman
2014-02-05 20:08 ` Kevin Hilman
2014-02-10 11:11 ` Ulf Hansson
2014-02-10 11:11 ` Ulf Hansson
2014-02-10 11:11 ` Ulf Hansson
2014-02-10 18:03 ` Kevin Hilman
2014-02-10 18:03 ` Kevin Hilman
2014-02-10 18:03 ` Kevin Hilman
2014-02-10 18:03 ` Kevin Hilman
2014-02-04 15:58 ` [PATCH 06/17] spi: pl022: Let runtime PM callbacks be available for CONFIG_PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-19 14:20 ` Ulf Hansson
2014-02-19 14:20 ` Ulf Hansson
2014-02-19 14:20 ` Ulf Hansson
2014-02-19 15:10 ` Mark Brown
2014-02-19 15:10 ` Mark Brown
2014-02-19 15:10 ` Mark Brown
2014-02-19 18:02 ` Ulf Hansson
2014-02-19 18:02 ` Ulf Hansson
2014-02-19 18:02 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:16 ` Mark Brown
2014-02-04 19:16 ` Mark Brown
2014-02-10 12:33 ` Ulf Hansson
2014-02-10 12:33 ` Ulf Hansson
2014-02-10 12:33 ` Ulf Hansson
2014-02-10 12:51 ` Mark Brown
2014-02-10 12:51 ` Mark Brown
2014-02-10 12:51 ` Mark Brown
2014-02-19 14:15 ` Ulf Hansson
2014-02-19 14:15 ` Ulf Hansson
2014-02-19 14:15 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 08/17] spi: pl022: Fully gate clocks at request inactivity Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 17:07 ` Mark Brown
2014-02-04 17:07 ` Mark Brown
2014-02-04 17:07 ` Mark Brown
2014-02-10 10:36 ` Ulf Hansson
2014-02-10 10:36 ` Ulf Hansson
2014-02-10 10:36 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 09/17] spi: pl022: Simplify clock handling Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:19 ` Mark Brown
2014-02-04 19:19 ` Mark Brown
2014-02-10 10:42 ` Ulf Hansson
2014-02-10 10:42 ` Ulf Hansson
2014-02-10 10:42 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 10/17] spi: pl022: Remove redundant pinctrl to default state in probe Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 19:20 ` Mark Brown
2014-02-04 19:20 ` Mark Brown
2014-02-04 19:20 ` Mark Brown
2014-02-05 12:53 ` Linus Walleij
2014-02-05 12:53 ` Linus Walleij
2014-02-05 12:53 ` Linus Walleij
2014-02-04 15:58 ` [PATCH 11/17] i2c: nomadik: Convert to devm functions Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-05 14:32 ` Linus Walleij
2014-02-05 14:32 ` Linus Walleij
2014-02-05 14:32 ` Linus Walleij
2014-02-04 15:58 ` [PATCH 12/17] i2c: nomadik: Remove redundant call to pm_runtime_disable Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 13/17] i2c: nomadik: Leave probe with the device in active state Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-05 14:34 ` Linus Walleij
2014-02-05 14:34 ` Linus Walleij
2014-02-05 14:34 ` Linus Walleij
2014-02-10 10:14 ` Ulf Hansson
2014-02-10 10:14 ` Ulf Hansson
2014-02-10 10:14 ` Ulf Hansson
2014-02-13 14:12 ` Ulf Hansson
2014-02-13 14:12 ` Ulf Hansson
2014-02-13 14:12 ` Ulf Hansson
2014-02-05 14:45 ` Fabio Estevam
2014-02-05 14:45 ` Fabio Estevam
2014-02-05 14:45 ` Fabio Estevam
2014-02-10 10:16 ` Ulf Hansson [this message]
2014-02-10 10:16 ` Ulf Hansson
2014-02-10 10:16 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 15/17] i2c: nomadik: Convert to late and early system PM callbacks Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 16/17] i2c: nomadik: Remove busy check for transfers at suspend late Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` [PATCH 17/17] i2c: nomadik: Fixup system suspend Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 15:58 ` Ulf Hansson
2014-02-04 18:49 ` [PATCH 00/17] amba: PM fixups for amba bus and some amba drivers Mark Brown
2014-02-04 18:49 ` Mark Brown
2014-02-04 18:49 ` Mark Brown
2014-02-10 10:25 ` Ulf Hansson
2014-02-10 10:25 ` Ulf Hansson
2014-02-10 10:25 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFphK8Zo1i7=w-n-VbGWpmLvUZs_U2Ekq0NCeqVxZ7VKvw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@unipv.it \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.