All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: "Varadarajan, Charulatha" <charu@ti.com>
Cc: Tarun Kanti DebBarma <tarun.kanti@ti.com>,
	linux-omap@vger.kernel.org, santosh.shilimkar@ti.com,
	tony@atomide.com, linux-arm-kernel@lists.infradead.org, "Cousson,
	Benoit" <b-cousson@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids
Date: Thu, 26 May 2011 10:15:10 -0700	[thread overview]
Message-ID: <8762oxgz8h.fsf@ti.com> (raw)
In-Reply-To: <BANLkTik2=da94cZh23gwx1hzZQK6H_hy2Q@mail.gmail.com> (Charulatha Varadarajan's message of "Thu, 26 May 2011 15:08:06 +0530")

"Varadarajan, Charulatha" <charu@ti.com> writes:

> On Thu, May 26, 2011 at 03:04, Kevin Hilman <khilman@ti.com> wrote:
>> Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
>>
>>> From: Charulatha V <charu@ti.com>
>>>
>>> Non-wakeup GPIOs are available only in OMAP2420 and OMAP3430. But
>>> the GPIO driver initializes the non-wakeup GPIO bits for OMAP24xx
>>> (bothe OMAP 2420 and 2430) & not for OMAP3 which is incorrect.
>>
>> Can you cite the documentation you're using for the OMAP3 non-wakeup
>> GPIOs?
>
> I am referring to Table 25-5. GPIO Channel Description at page no 3354
> OMAP3430 public TRM Version P.
>

Based on how I understand that, those non-wakeup GPIOs are non-wakeup
because they're not actually mapped anywhere, and not available on
external pins.  Therefore, they should not need any special case
handling for this triggering workaround.

Kevin


WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids
Date: Thu, 26 May 2011 10:15:10 -0700	[thread overview]
Message-ID: <8762oxgz8h.fsf@ti.com> (raw)
In-Reply-To: <BANLkTik2=da94cZh23gwx1hzZQK6H_hy2Q@mail.gmail.com> (Charulatha Varadarajan's message of "Thu, 26 May 2011 15:08:06 +0530")

"Varadarajan, Charulatha" <charu@ti.com> writes:

> On Thu, May 26, 2011 at 03:04, Kevin Hilman <khilman@ti.com> wrote:
>> Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
>>
>>> From: Charulatha V <charu@ti.com>
>>>
>>> Non-wakeup GPIOs are available only in OMAP2420 and OMAP3430. But
>>> the GPIO driver initializes the non-wakeup GPIO bits for OMAP24xx
>>> (bothe OMAP 2420 and 2430) & not for OMAP3 which is incorrect.
>>
>> Can you cite the documentation you're using for the OMAP3 non-wakeup
>> GPIOs?
>
> I am referring to Table 25-5. GPIO Channel Description at page no 3354
> OMAP3430 public TRM Version P.
>

Based on how I understand that, those non-wakeup GPIOs are non-wakeup
because they're not actually mapped anywhere, and not available on
external pins.  Therefore, they should not need any special case
handling for this triggering workaround.

Kevin

  reply	other threads:[~2011-05-26 17:15 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 14:24 [PATCH 00/15] OMAP: GPIO: Cleanup OMAP GPIO driver Tarun Kanti DebBarma
2011-05-24 14:24 ` Tarun Kanti DebBarma
2011-05-24 14:24 ` [PATCH 01/15] OMAP: GPIO: Avoid cpu_is checks during module ena/disable Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 21:19   ` Kevin Hilman
2011-05-25 21:19     ` Kevin Hilman
2011-05-26  9:38     ` Varadarajan, Charulatha
2011-05-26  9:38       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 21:34   ` Kevin Hilman
2011-05-25 21:34     ` Kevin Hilman
2011-05-26  9:38     ` Varadarajan, Charulatha
2011-05-26  9:38       ` Varadarajan, Charulatha
2011-05-26 17:15       ` Kevin Hilman [this message]
2011-05-26 17:15         ` Kevin Hilman
2011-05-26 17:39         ` Varadarajan, Charulatha
2011-05-26 17:39           ` Varadarajan, Charulatha
2011-05-26 18:32           ` Kevin Hilman
2011-05-26 18:32             ` Kevin Hilman
2011-05-26  9:23   ` Premi, Sanjeev
2011-05-26  9:23     ` Premi, Sanjeev
2011-05-26  9:43     ` Varadarajan, Charulatha
2011-05-26  9:43       ` Varadarajan, Charulatha
2011-05-26 10:11     ` Cousson, Benoit
2011-05-26 10:11       ` Cousson, Benoit
2011-05-26 11:47       ` Premi, Sanjeev
2011-05-26 11:47         ` Premi, Sanjeev
2011-05-26 12:11         ` Cousson, Benoit
2011-05-26 12:11           ` Cousson, Benoit
2011-05-26 12:38           ` Premi, Sanjeev
2011-05-26 12:38             ` Premi, Sanjeev
2011-05-26 12:46             ` Cousson, Benoit
2011-05-26 12:46               ` Cousson, Benoit
2011-05-26 13:19               ` Premi, Sanjeev
2011-05-26 13:19                 ` Premi, Sanjeev
2011-05-26 13:38               ` B.J. Buchalter
2011-05-26 13:38                 ` B.J. Buchalter
2011-05-26 14:12                 ` Cousson, Benoit
2011-05-26 14:12                   ` Cousson, Benoit
2011-05-24 14:24 ` [PATCH 03/15] OMAP: GPIO: Remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-24 14:24 ` [PATCH 04/15] OMAP2PLUS: GPIO: Use flag to identify wkup dmn GPIO Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 21:40   ` Kevin Hilman
2011-05-25 21:40     ` Kevin Hilman
2011-05-24 14:24 ` [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 21:41   ` Kevin Hilman
2011-05-25 21:41     ` Kevin Hilman
2011-05-26  9:58   ` Premi, Sanjeev
2011-05-26  9:58     ` Premi, Sanjeev
2011-05-26 10:07     ` Varadarajan, Charulatha
2011-05-26 10:07       ` Varadarajan, Charulatha
2011-05-26  9:59   ` Premi, Sanjeev
2011-05-26  9:59     ` Premi, Sanjeev
2011-05-24 14:24 ` [PATCH 06/15] OMAP4: GPIO: Save/restore context Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 21:43   ` Kevin Hilman
2011-05-25 21:43     ` Kevin Hilman
2011-05-26  9:37     ` Varadarajan, Charulatha
2011-05-26  9:37       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 07/15] OMAP: GPIO: handle save/restore ctx in GPIO driver Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 22:33   ` Kevin Hilman
2011-05-25 22:33     ` Kevin Hilman
2011-05-25 22:36     ` Kevin Hilman
2011-05-25 22:36       ` Kevin Hilman
2011-05-24 14:24 ` [PATCH 08/15] OMAP2+: GPIO: make workaround_enabled bank specific Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 22:39   ` Kevin Hilman
2011-05-25 22:39     ` Kevin Hilman
2011-05-26  9:37     ` Varadarajan, Charulatha
2011-05-26  9:37       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 09/15] OMAP: GPIO: cleanup suspend and resume functions Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 22:57   ` Kevin Hilman
2011-05-25 22:57     ` Kevin Hilman
2011-05-26 10:02     ` Varadarajan, Charulatha
2011-05-26 10:02       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 10/15] OMAP: GPIO: cleanup prepare/resume idle functions Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 23:00   ` Kevin Hilman
2011-05-25 23:00     ` Kevin Hilman
2011-05-24 14:24 ` [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 23:01   ` Kevin Hilman
2011-05-25 23:01     ` Kevin Hilman
2011-05-26  9:36     ` Varadarajan, Charulatha
2011-05-26  9:36       ` Varadarajan, Charulatha
2011-05-26  9:42   ` Premi, Sanjeev
2011-05-26  9:42     ` Premi, Sanjeev
2011-05-26  9:48     ` Varadarajan, Charulatha
2011-05-26  9:48       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 12/15] OMAP: GPIO: Fix: use wake set/clear regs Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 23:14   ` Kevin Hilman
2011-05-25 23:14     ` Kevin Hilman
2011-05-26  9:36     ` Varadarajan, Charulatha
2011-05-26  9:36       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 13/15] OMAP: GPIO: clean set_gpio_triggering function Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 23:27   ` Kevin Hilman
2011-05-25 23:27     ` Kevin Hilman
2011-05-26  9:55     ` Varadarajan, Charulatha
2011-05-26  9:55       ` Varadarajan, Charulatha
2011-05-24 14:24 ` [PATCH 14/15] OMAP: GPIO: Use memset for omap_gpio_reg_offs Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 23:30   ` Kevin Hilman
2011-05-25 23:30     ` Kevin Hilman
2011-05-24 14:24 ` [PATCH 15/15] OMAP: GPIO: clean omap_gpio_mod_init function Tarun Kanti DebBarma
2011-05-24 14:24   ` Tarun Kanti DebBarma
2011-05-25 23:48   ` Kevin Hilman
2011-05-25 23:48     ` Kevin Hilman
2011-06-03 11:20     ` Varadarajan, Charulatha
2011-06-03 11:20       ` Varadarajan, Charulatha
2011-06-03 14:31       ` Kevin Hilman
2011-06-03 14:31         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762oxgz8h.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=b-cousson@ti.com \
    --cc=charu@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tarun.kanti@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.